MultiThreaded server : first socketclient work the other dosent work

[Amit Shef]

Hey.

I got a problem that the first socket that connects to the server works but the second one WORKS BUT than the first dosen't work.

And it keeps on and on..

If you connect even the 8 client it works but than the 7 and earlier clients wont work.

Server:

public static void main(String[] args) throws URISyntaxException,
			IOException {
		try {
			serverSocket = new ServerSocket(PORT);
			System.out.println("SERVER STARTED!");
		} catch (IOException e) {
			System.out.println("ERROR ON STARTING SERVER" + e);
			e.printStackTrace();
		}
		try {
			while (true) {
				clientSocket = serverSocket.accept();
				ClientServiceThread cst = new ClientServiceThread(clientSocket,
						id++);
				cst.start();
				System.out.println("ServerSocket IP/PORT : " + clientSocket);
				clientList.add(clientSocket);
				System.out.println("ClientList : " + clientList);

			}
		} catch (IOException e) {
			System.out.println("ERROR : " + e);
		}
	}


	public static class ClientServiceThread extends Thread {
		Socket clientSocket;
		int clientID = -1;
		boolean running = true;

		ClientServiceThread(Socket s, int i) {
			clientSocket = s;
			clientID = i;
		}

		public void run() {
			System.out.println("Accepted Client : ID - " + clientID
					+ " : Address - "
					+ clientSocket.getInetAddress().getHostName());
			try {

				out = new PrintWriter(new OutputStreamWriter(
						clientSocket.getOutputStream()), true);
				bufferedReader = new BufferedReader(new InputStreamReader(
						clientSocket.getInputStream()));

				while (running) {

if (output == null) {
						running = false;
						System.out.print("Stopping client thread for client : "
								+ clientID);

					} else {	
	System.out.println("Ready for writing/Println..."
								+ clientCommand);
	out.println("HELLO");
					out.flush();
			} catch (Exception e) {
				e.printStackTrace();
			}
		}
	}

Thanks in advance.

[Henry Wong]

Your client service thread is using lots of variables -- out, bufferedReader, output, etc. -- perhaps you can show us more code that include those declarations?

Henry

[Amit Shef]

This is basically all my code on the Server.class

My client is the basic client like

Socket socket = new Socket(IP,PORT);
output..
input..
....

[Henry Wong]

Amit Shef wrote:This is basically all my code on the Server.class

The ClientServiceThread class is a nested class. And it is using variables that it did not declare -- which is assumed to be declared in the outer class (as static variables)... so, obviously, you haven't show us all your code.

Anyway, if you happened to do what I just described, then the issue is that your nested class instances are using the same static variables of the outer class, and stepping on each other.

Henry

[Amit Shef]

You were right

Thank you.