Sum of Arraylist

[david foley]

For some reason i am getting the following

   java.lang.IllegalStateException: Could not execute method of the activity
            at android.view.View$1.onClick(View.java:3823)
            at android.view.View.performClick(View.java:4438)
            at android.view.View$PerformClick.run(View.java:18422)
            at android.os.Handler.handleCallback(Handler.java:733)
            at android.os.Handler.dispatchMessage(Handler.java:95)
            at android.os.Looper.loop(Looper.java:136)
            at android.app.ActivityThread.main(ActivityThread.java:5017)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
            at dalvik.system.NativeStart.main(Native Method)
     Caused by: java.lang.reflect.InvocationTargetException
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at android.view.View$1.onClick(View.java:3818)
            at android.view.View.performClick(View.java:4438)
            at android.view.View$PerformClick.run(View.java:18422)
            at android.os.Handler.handleCallback(Handler.java:733)
            at android.os.Handler.dispatchMessage(Handler.java:95)
            at android.os.Looper.loop(Looper.java:136)
            at android.app.ActivityThread.main(ActivityThread.java:5017)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
            at dalvik.system.NativeStart.main(Native Method)
     Caused by: java.lang.NumberFormatException: Invalid int: ""
            at java.lang.Integer.invalidInt(Integer.java:137)
            at java.lang.Integer.parseInt(Integer.java:358)
            at java.lang.Integer.parseInt(Integer.java:331)
            at com.example.dfoley.scorecard1.MyActivity.Calculate(MyActivity.java:53)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at android.view.View$1.onClick(View.java:3818)
            at android.view.View.performClick(View.java:4438)
            at android.view.View$PerformClick.run(View.java:18422)
            at android.os.Handler.handleCallback(Handler.java:733)
            at android.os.Handler.dispatchMessage(Handler.java:95)
            at android.os.Looper.loop(Looper.java:136)
            at android.app.ActivityThread.main(ActivityThread.java:5017)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
            at dalvik.system.NativeStart.main(Native Method)

from this Code

package com.example.dfoley.scorecard1;

import android.app.Activity;
import android.os.Bundle;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.widget.Button;
import android.widget.EditText;
import android.widget.TextView;

import java.util.ArrayList;


public class MyActivity extends Activity
{
    int sum=0;
    ArrayList<String> score = new ArrayList<String>(8);
    @Override
    protected void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_my);

        EditText T1 = (EditText) findViewById(R.id.editText2);
        EditText T2 = (EditText) findViewById(R.id.editText3);
        EditText T3 = (EditText) findViewById(R.id.editText4);
        EditText T4 = (EditText) findViewById(R.id.editText5);
        EditText T5 = (EditText) findViewById(R.id.editText6);
        EditText T6 = (EditText) findViewById(R.id.editText7);
        EditText T7 = (EditText) findViewById(R.id.editText8);
        EditText T8 = (EditText) findViewById(R.id.editText9);
        EditText T9 = (EditText) findViewById(R.id.editText10);
        Button cal = (Button)findViewById(R.id.buttonScore);


        score.add(T1.getText().toString());
        score.add(T2.getText().toString());
        score.add(T3.getText().toString());
        score.add(T4.getText().toString());
        score.add(T5.getText().toString());
        score.add(T6.getText().toString());
        score.add(T7.getText().toString());
        score.add(T8.getText().toString());
        score.add(T9.getText().toString());

    }
    public void Calculate(View v)
    {

        TextView total = (TextView) findViewById(R.id.textView28);
        for (int i = 0; i < score.size(); i++)
        {
        sum += Integer.parseInt(((String.valueOf(score.get(i)))));
        }
        total.setText(sum);
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.my, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();
        if (id == R.id.action_settings) {
            return true;
        }
        return super.onOptionsItemSelected(item);
    }
}

[Jesper de Jong]

As the error message says, you are trying to parse an empty string into an integer. That won't work, because an empty string cannot meaningfully be parsed into an integer. (What number would you expect that "" means?).
It probably happens in this line:

sum += Integer.parseInt(((String.valueOf(score.get(i)))));  

score.get(i) returns an empty string.

Why: Because you are setting the content of the score list in the onCreate method. At that point, the text boxes are all still empty.

By the way, the String.valueOf(...) is not necessary, since score.get(...) already returns a String. No need to convert a String to a String! You could just as well do this:

sum += Integer.parseInt(score.get(i));  

(And why do you have so many unnecessary extra parentheses in your code?).

[david foley]

I had the

   sum += Integer.parseInt(score.get(i));

in there the last time but still gave me the Same Issue,
Java.lang.NumberFormatExcetion : Invalid int: " "

would i be better off Doing

   ArrayList<Integer> score = new ArrayList<Integer>(8);
 score.add(T1.getText().length());
        score.add(T2.getText().length());
        score.add(T3.getText().length());
        score.add(T4.getText().length());
        score.add(T5.getText().length());
        score.add(T6.getText().length());
        score.add(T7.getText().length());
        score.add(T8.getText().length());
        score.add(T9.getText().length());

 public void Calculate(View v)
    {

        TextView total = (TextView) findViewById(R.id.textView28);
        //sum += Integer.parseInt(((String.valueOf(score.get(i)))));
        for (int i = 0; i < score.size(); i++)
        {
            sum = sum + score.get(i);
        }
  total.setText(Integer.toString(sum));

It stops it from Crashing but nothing is Happening when i click on Calculate Total is still set to zero

[david foley]

if Score.get(i) is not getting anything

what do i need to do in order for it to get the elements of the Array ?

[Jesper de Jong]

You need to get the content of the edit text fields in the calculate method, instead of in the onCreate method.

onCreate is called when the GUI is initialized (when someone is starting your app). At that moment the user has not yet entered anything into the app. So it doesn't make much sense to get the content of the edit boxes at that moment. You want to do that when the user wants the calculation to be performed.

score.add(T2.getText().length());  
score.add(T3.getText().length());
score.add(T4.getText().length()); 
// ...

Are you sure that this is what you want to do? Do you understand what that code means? You want to get the length of each text field in the array? (It's something completely different than what the intent of your original code seems to be).

[david foley]

I am trying to enter Numbers into a Edit Text Field,

Once they are Entered they should be added to the ArrayList Automaically, as Integers
since score.add(T1.getText().toString()); only works on ArrayList that are String
I thought if i got Text to Lenght that might help i also tried

score.add(Integer.parseInt(T1.getText().toString()));

from what you are saying that do not place score.add into Oncreate so my best bet is to place score.add into a TextWatcher ?

if so what is the best way to place an Array into a Text Watcher,

I tired something different which seems to point me at a NullPointer Excption at
EditText T1 = (EditText) findViewById(R.id.editText2); inside editTextArray Class
and also in editArray = new editTextArray(); inside MyActivity Class

package com.example.dfoley.scorecard1;

import android.app.Activity;
import android.widget.EditText;

import java.util.ArrayList;

/**
 * Created by DFOLEY on 09/10/2014.
 */

public class editTextArray extends Activity
{
    EditText T1 = (EditText) findViewById(R.id.editText2);
    EditText T2 = (EditText) findViewById(R.id.editText3);
    EditText T3 = (EditText) findViewById(R.id.editText4);
    EditText T4 = (EditText) findViewById(R.id.editText5);
    EditText T5 = (EditText) findViewById(R.id.editText6);
    EditText T6 = (EditText) findViewById(R.id.editText7);
    EditText T7 = (EditText) findViewById(R.id.editText8);
    EditText T8 = (EditText) findViewById(R.id.editText9);
    EditText T9 = (EditText) findViewById(R.id.editText10);

    private ArrayList<Integer> list;

    public editTextArray(){
        list = new ArrayList<Integer>();
        list.add(Integer.parseInt(T1.getText().toString()));
        list.add(Integer.parseInt(T2.getText().toString()));
        list.add(Integer.parseInt(T3.getText().toString()));
        list.add(Integer.parseInt(T4.getText().toString()));
        list.add(Integer.parseInt(T5.getText().toString()));
        list.add(Integer.parseInt(T6.getText().toString()));
        list.add(Integer.parseInt(T7.getText().toString()));
        list.add(Integer.parseInt(T8.getText().toString()));
        list.add(Integer.parseInt(T9.getText().toString()));
    }

    public ArrayList<Integer>getList(){
        return list;
    }

package com.example.dfoley.scorecard1;
import android.app.Activity;
import android.os.Bundle;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.widget.Button;
import android.widget.EditText;
import android.widget.TextView;
import java.util.ArrayList;



public class MyActivity extends Activity
{

    private editTextArray editArray;

    @Override
    protected void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_my);
        EditText T1 = (EditText)super.findViewById(R.id.editText2);
        EditText T2 = (EditText)super.findViewById(R.id.editText3);
        EditText T3 = (EditText)super.findViewById(R.id.editText4);
        EditText T4 = (EditText)super.findViewById(R.id.editText5);
        EditText T5 = (EditText)super.findViewById(R.id.editText6);
        EditText T6 = (EditText)super.findViewById(R.id.editText7);
        EditText T7 = (EditText)super.findViewById(R.id.editText8);
        EditText T8 = (EditText)super.findViewById(R.id.editText9);
        EditText T9 = (EditText)super.findViewById(R.id.editText10);
        Button cal = (Button)findViewById(R.id.buttonScore);
    }


    public void Calculate(View v)
    {
        TextView total = (TextView)findViewById(R.id.textView28);
        editArray = new editTextArray();
        ArrayList<Integer> list = editArray.getList();
        int sum =0;
        for(int i =0; i< list.size(); i++) {
            sum = sum + list.get(i);
        }  total.setText(Integer.toString(sum));
        //sum += Integer.parseInt(((String.valueOf(score.get(i)))));

       // int n = number.size();

        //for (int i = 0; i < n; i++)
        //{
         //   sum = sum + number.get(i);
      //  }
      //  total.setText(Integer.toString(sum));
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.my, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();
        if (id == R.id.action_settings) {
            return true;
        }
        return super.onOptionsItemSelected(item);
    }
}