spring mvc controller Test with Enumeration value

[Alex Giovi]

i'm trying to test this Method :

@RequestMapping(value="/PersonalState/{EmployeeId}", method = RequestMethod.PUT)
public @ResponseBody Object Update(@PathVariable Integer EmployeeId, @RequestParam EmployeeState empstate) throws Exception { 
    EmployeeService.updateEmployeeState(entityManager.find(Employee.class, EmployeeId), empstate);
    return null;
}

EmplyeeState is an enumeration , the values are saved in db as integer,this is my test Code:

@Test
public void EmployeeTest() throws Exception {   
        mockMvc.perform(MockMvcRequestBuilders.put("/PersonalState/{empstate}",EmplyeeState.PERMANENT)
           .param("EmployeeId", "550"))
          .andDo(print())
          .andExpect(MockMvcResultMatchers.status().isOk());
} 

I got this Errror:

            Resolved Exception:
             Type = org.springframework.beans.TypeMismatchException
             MockHttpServletResponse:
             Status = 400  

I tried to pass the two variables as parameters ,passing only the EmployeeId as parameter but i still have the same error besides the param parameters must be both of type String. Any Idea?

[Jayesh A Lalwani]

Well, shouldn;t you put employeeId in the URL and state in the parameter

[Jesper de Jong]

Jayesh is right. In your first code snippet, the employee id is a path variable, and the employee state is a request parameter. But in your second snippet (the test code), you have the reverse: the employee state is a path variable, and the employee id is a request parameter.

[Alex Giovi]

Hi,
Did you mean like this:

@Test  
public void EmployeeTest() throws Exception {     
        mockMvc.perform(MockMvcRequestBuilders.put("/PersonalState/{EmployeeId}",63)  
           .param("empstate", "Enumeration.EmplyeeState.PERMANENT"))  
          .andDo(print())  
          .andExpect(MockMvcResultMatchers.status().isOk());  
} 

public class Enumeration{
public enum EmplyeeState{
PERMANENT,
TEMPORARY
}
}

I already do this , but the problem is that Mockmvc.param attribute accept string so when i pass this as parameter(param("empstate", "Enums.EmplyeeState.PERMANENT"))
or without Apostrophe i have the same error(org.springframework.beans.TypeMismatchException)

[Jayesh A Lalwani]

Look at this section in the Spring docs

String-based values extracted from the request including request parameters, path variables, request headers, and cookie values may need to be converted to the target type of the method parameter or field (e.g., binding a request parameter to a field in an @ModelAttribute parameter) they’re bound to. If the target type is not String, Spring automatically converts to the appropriate type. All simple types such as int, long, Date, etc. are supported. You can further customize the conversion process through a WebDataBinder (see the section called “Customizing WebDataBinder initialization”) or by registering Formatters with the FormattingConversionService (see Section 7.6, “Spring Field Formatting”).

I'm not sure but it could be that you need to write a custom formatter to convert String to ENum. I don;t know if Spring comes up with it's own default Formatter. But if it doesn;t you can write your own Formatter and register it with Spring MVC

[H Paul]

It's not so obvious for Status 400 until I debugged. The issue on the client side.

All you need is 1 change:

 .param("empstate", Enumeration.EmplyeeState.PERMANENT.toString()))  

@Test    
public void EmployeeTest() throws Exception {       
        mockMvc.perform(MockMvcRequestBuilders.put("/PersonalState/{EmployeeId}",63)    
           .param("empstate", Enumeration.EmplyeeState.PERMANENT.toString()))  
          .andDo(print())    
          .andExpect(MockMvcResultMatchers.status().isOk());    
} 

[Alex Giovi]

great! it works
Many Thanks