Modifying a xml with DOCTYPE

[jordan ryan]

Hey Guys I completed an application and thought it was working fine, But I realised I didnt have a DOCTYPE in my xml, Now once I've added the DOCTYPE the application will now no longer run it gets a time out error I believe Below is my code. If anyone could point me in the right direction that would be great. I'm pretty sure its because I cant use a dom parser for this kind of xml but I'm struggling to find a correct way to do it, when I remover the doctype from the code it works fine so I know its that line int he xml in which my application is not running for.

// Import required java libraries
import java.io.*;
import javax.servlet.ServletException;
import javax.servlet.http.*;
import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.transform.Transformer;
import javax.xml.transform.TransformerFactory;
import javax.xml.transform.dom.DOMSource;
import javax.xml.transform.stream.StreamResult;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
import org.w3c.dom.NamedNodeMap;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;

// Extend HttpServlet class
public class log4jUpdate extends HttpServlet {
 

  protected void doPost(HttpServletRequest request,
                    HttpServletResponse response)
            
  {
	  try {
		  	
			String fXmlFile = "C:\\myfile.xml";
			DocumentBuilderFactory docFactory = DocumentBuilderFactory.newInstance();
			DocumentBuilder docBuilder = docFactory.newDocumentBuilder();
			Document doc = docBuilder.parse(fXmlFile);
			doc.getDocumentElement().normalize();

			String maxLogs = request.getParameter("maxLogs");
			String maxFileSize = request.getParameter("maxFileSize");
			String fileLocation = request.getParameter("fileLocation");
		
			PrintWriter print = response.getWriter();
			NodeList nodeList=doc.getElementsByTagName("appender");
		    for (int i=0; i<nodeList.getLength(); i++) 
		    {
		        Node staff =  nodeList.item(i);
		    	NamedNodeMap attr = staff.getAttributes();
		    	Node nodeAttr = attr.getNamedItem("name");
		    	if (nodeAttr.getTextContent().equals("file"))
		    	{
			NodeList nList = (NodeList) staff;
				for (int temp = 0; temp < nList.getLength(); temp++) {
					 
					Node nNode = nList.item(temp);
					if (nNode.getNodeName().equals("param"))
					{
			 			 
						Element eElement = (Element) nNode;
						NamedNodeMap attrib = eElement.getAttributes();
						Node nodeAttrib = attrib.getNamedItem("name");
						if (nodeAttrib.getTextContent().equals("File"))
						{ 
							if (!fileLocation.trim().isEmpty()){
							Node nodeAttrib2 = attrib.getNamedItem("value");
							nodeAttrib2.setTextContent(fileLocation.trim());
							}
						}
						else if (nodeAttrib.getTextContent().equals("maxBackupIndex") ){
							if (!maxLogs.trim().isEmpty()){
							Node nodeAttrib2 = attrib.getNamedItem("value");
							nodeAttrib2.setTextContent(maxLogs.trim());
							}
						}
						else if (nodeAttrib.getTextContent().equals("maxFileSize")){
							if (!maxFileSize.trim().isEmpty()){
							Node nodeAttrib2 = attrib.getNamedItem("value");
							nodeAttrib2.setTextContent(maxFileSize.trim() + "MB");
							}
						}
				}
				}
		    	}
		    }
		
			
			 
			TransformerFactory transformerFactory = TransformerFactory.newInstance();
			Transformer transformer = transformerFactory.newTransformer();
			DOMSource source = new DOMSource(doc);
			StreamResult result = new StreamResult(new File(fXmlFile));
			transformer.transform(source, result);
			print.println("This has been completed!");
	
	  }
		catch (Exception e) {
			e.printStackTrace();
		    }
  }

}

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE log4j:configuration PUBLIC
  "-//APACHE//DTD LOG4J 1.2//EN" "http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/xml/doc-files/log4j.dtd">
<log4j:configuration debug="true"
  xmlns:log4j='http://jakarta.apache.org/log4j/'>
 
   <appender class="org.apache.log4j.ConsoleAppender" name="A1">
      <!-- <param name="Threshold" value="INFO" /> -->
      <layout class="org.apache.log4j.PatternLayout">
         <param name="ConversionPattern" value="%d [%t] %-5p %c - %m%n"/>
      </layout>
   </appender>

   <appender class="org.apache.log4j.RollingFileAppender" name="file">
      <param name="Threshold" value="DEBUG"/>
      <param name="File" value="C:\filelocation.log"/>
      <param name="maxBackupIndex" value="5"/>
      <param name="maxFileSize" value="100MB"/>
      <layout class="org.apache.log4j.PatternLayout">
         <param name="ConversionPattern" value="%d %-5p  [%c{1}] %m %n"/>
      </layout>
   </appender>
 
	<root>
		<level value="DEBUG" />
		<appender-ref ref="A1" />
		<appender-ref ref="file" />
	</root>
 
</log4j:configuration>

Error

java.net.ConnectException: Connection timed out: connect
	at java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:351)
	at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:213)
	at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:200)
	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
	at java.net.Socket.connect(Socket.java:529)
	at java.net.Socket.connect(Socket.java:478)
	at sun.net.NetworkClient.doConnect(NetworkClient.java:163)
	at sun.net.www.http.HttpClient.openServer(HttpClient.java:394)
	at sun.net.www.http.HttpClient.openServer(HttpClient.java:529)
	at sun.net.www.http.HttpClient.<init>(HttpClient.java:233)
	at sun.net.www.http.HttpClient.New(HttpClient.java:306)
	at sun.net.www.http.HttpClient.New(HttpClient.java:323)
	at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:970)
	at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:911)
	at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:836)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1172)
	at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:677)
	at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.startEntity(XMLEntityManager.java:1315)
	at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.startDTDEntity(XMLEntityManager.java:1282)
	at com.sun.org.apache.xerces.internal.impl.XMLDTDScannerImpl.setInputSource(XMLDTDScannerImpl.java:283)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$DTDDriver.dispatch(XMLDocumentScannerImpl.java:1194)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$DTDDriver.next(XMLDocumentScannerImpl.java:1090)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:1003)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648)
	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511)
	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808)
	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737)
	at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119)
	at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:235)
	at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:284)
	at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:180)
	at log4jUI.doGet(log4jUI.java:22)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
	at java.lang.Thread.run(Thread.java:662)

[jordan ryan]

Solved the Issue, moved the DTD locally and worked fine, my bad silly mistake.

[Campbell Ritchie]

Well done telling us what you moved .
I shall move something, too. XML is too scary for us Java beginners so I shall move you to our XML forum.