Forum:

Data table displaying same item multiple times-not supposed to

Greenhorn

Posts: 12

posted 5 years ago

Hi I currently have a datatable on the bookingList.xhtml which is supposed to list all bookings made, if first booking petName is spot it displays the booking details perfect but if another booking is made (for example one with petName fluffy) then it displays 2 lines with fluffys details and spots details are not displayed, it carries on that if a third booking is made then the 3rd bookings details are displayed 3 times and neither spot or fluffys booking details are displayed, can anybody help on this I would really appreciate it thanks I have attached some code below if you need anymore just let me know thanks

bookingList.xhtml code

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" 
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<h:head>
	<title>Welcome</title>
</h:head>

<ui:composition template="/WEB-INF/templates/BasicTemplate.xhtml">

<ui:define name="content">
	
	<div id="bookingList">
	<br/>
		<h:form id="form">
   			<p:growl id="msgs" showDetail="true"/>
 				<h:outputLabel value="Restricted Access" rendered="#{!loginBean.loggedIn}" />
	   			<p:dataTable id="bookingTable" var="booking" value="#{booking.bookingList}" editable="true" style="margin-bottom:20px" rendered="#{loginBean.userType=='Manager'}">
			       <f:facet name="header">
			           Booking Details

			       </f:facet>
	 
			       	<p:ajax event="rowEdit" listener="#{booking.onRowEdit}" update=":form:msgs" />
			       	<p:ajax event="rowEditCancel" listener="#{booking.onRowCancel}" update=":form:msgs" />
			       
			 
			       <p:column headerText="Pet Name" style ="width:50px">
			           <p:cellEditor>
			               <f:facet name="output"><h:outputText value="#{booking.petName}" /></f:facet>
			               <f:facet name="input"><p:inputText value="#{booking.petName}" style="width:100%"/></f:facet>
			           </p:cellEditor>
			       </p:column>
	 
			       <p:column headerText="Pet Type" style ="width:30px">
			           <p:cellEditor>
			               <f:facet name="output"><h:outputText value="#{booking.petType}" /></f:facet>
			               <f:facet name="input"><p:inputText value="#{booking.petType}" style="width:100%" /></f:facet>
			           </p:cellEditor>
			       </p:column>
	 
			       <p:column headerText="Start Date" style ="width:40px">
			           <p:cellEditor>
			               <f:facet name="output"><h:outputText value="#{booking.displayStartDate}" /></f:facet>
			               <f:facet name="input"><p:inputText value="#{booking.displayStartDate}" style="width:100%" /></f:facet>
			           </p:cellEditor>
			       </p:column>
			       
			      	<p:column headerText="Delete" style ="width:10px;" rendered="#{loginBean.userType=='Manager'}">
						<p:commandButton id="delete" 
                 		icon="ui-icon ui-icon-trash" 
                 		title="Delete Booking"
                 		onclick="PF('deleteConfirm').show()" 
                 		style ="width:30px;height:30px;margin:0px 0px 0px 25px;">
                 		<f:setPropertyActionListener value="#{booking}" target="#{booking.booking}"/>
						</p:commandButton>
					</p:column>
					
	 
			       <p:column headerText="Edit" style="width:10px" rendered="#{loginBean.userType=='Manager'}">
			           <p:rowEditor />
			       </p:column>
	   			</p:dataTable>
				<p:commandButton style="width:150px" styleClass="signup" action="booking?faces-redirect=true" value="Add Booking" rendered="#{loginBean.userType=='Manager'}"/>
	   					<p:confirmDialog message="Are you sure?" 
						                 showEffect="fade"
						                 hideEffect="explode" 
						                 widgetVar="deleteConfirm">
						    <p:commandButton title="YesButton" 
						                     value="Yes" 
						                     action="#{booking.deleteBooking}" 
						                     oncomplete="PF('deleteConfirm').hide()" 
						                     update="bookingTable" 
						                     process="@this" ajax="false"/>
						    <p:commandButton title="NoButton" 
						                     value="No" 
						                     oncomplete="PF('deleteConfirm').hide()"/>
						</p:confirmDialog>
   		</h:form>
	</div>
		<div id="mgrSidebar">
			      <h3>Staff Tools</h3>
			      
			     		     <ul id="services">
		          <li>
		          		
		          		<h4><a href="customerList.xhtml">Customers</a></h4>
		              	<a href="customerList.xhtml"><h:graphicImage name="images/users.jpg" /></a>
		        
		          </li>
		           <li>
		         
			          <h:panelGroup id="MgrViewStaff" rendered="#{loginBean.userType=='Manager'}">
			           		<h4><a href="staffList.xhtml">Staff</a></h4>
			           		<a href="staffList.xhtml"><h:graphicImage name="images/employees.jpg" /></a>
			          </h:panelGroup>
		          
		          </li>
		           <li>
		           <h:panelGroup id="MgrViewInvoices" rendered="#{loginBean.userType=='Manager'}">
			           		<h4><a href="#">Invoices</a></h4>
			              	<a href="#"><h:graphicImage name="images/euro.jpg" /></a>
			       </h:panelGroup>
		          </li>
		          <li>
		          		<h4><a href="#">Bookings</a></h4>
		             	<a href="#"><h:graphicImage name="images/calendar.jpg" /></a>
		              
		          </li>
		      </ul>
			      
			</div>
	</ui:define>
</ui:composition>
</html>

Booking.java code

package com.paws4applause.booking;

import java.io.Serializable;
import java.text.Format;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.Date;

import javax.faces.bean.ApplicationScoped;
import javax.faces.bean.ManagedBean;
import javax.faces.bean.SessionScoped;
import javax.faces.event.ActionEvent;

import org.primefaces.event.SelectEvent;

import com.paws4applause.login.LoginBean;
import com.paws4applause.utils.ListMaker;

@ManagedBean(name = "booking")
@ApplicationScoped
public class Booking implements Serializable{
	
	private static final long serialVersionUID = 1L;
	
	
	public ArrayList<Booking> bookingList = new ArrayList<>();
	private Booking bookObj;
	private String petName;
	private String petType;
	private Date startDate;
	private String displayStartDate;
	private Date endDate;
	private String displayEndDate;
	private String today=today();
	private String maxAheadOfTimeBooking=todayPlusYear();
	private String minDateForEndDateCalender;
	private String customerBookingEmail;
	private long daysInKennels;
	private long bookingCost;
	private static int kennelCapacity=100;
	private boolean groomingService=false;
	private boolean nailClipping=false;
	private boolean vetService=false;
	private String petUpdate;
	
	
	/**
	 * CONSTRUCTORS
	 * 
	 */
	public Booking(){
		this.petName = "";
		this.petType = "";
		this.startDate = null;
		this.endDate = null;
	}
	public Booking(String petName, String petType, Date startDate, Date endDate) {
		super();
		this.petName = petName;
		this.petType = petType;
		this.startDate = startDate;
		this.endDate = endDate;
	}
	/**
	 * EVENT LISTENERS
	 * 
	 */

/**
	 * When confirmation button is pressed in booking form the customer object email is
	 * copied as a booking object attribute giving a primary key to link bookings to customers.
	 * Also the amount of days the booking lasts and the cost of the booking are calculated.
	 * Convert start and end dates to strings for display in the confirmation page.
	 * 
	 * @param event .Event generated upon clicking confirm button in booking.xhtml
	 */
	public void attributeListener(ActionEvent event){
		//Confirmation button
		customerBookingEmail = (String)event.getComponent().getAttributes().get("email");
		//setCustomerBookingEmail((String)event.getComponent().getAttributes().get("email"));
		//Amount of days and cost
		long dailyCost=20; 
		long dateDiff = endDate.getTime() - startDate.getTime();
		daysInKennels=(dateDiff / (1000 * 60 * 60 * 24));
		bookingCost=dailyCost*daysInKennels;
		
		//Additional Services costs added.
		int additionalCosts=0;
		if(nailClipping==true){
			additionalCosts+=10;
		}
		if(groomingService==true){
			additionalCosts+=15;
		}
		if(vetService==true){
			additionalCosts+=50;
		}
		bookingCost+=additionalCosts;
		
		//Dates to string for display in confirmation page.
		SimpleDateFormat sdf = new SimpleDateFormat("dd/MM/yyyy");
		displayStartDate=(sdf.format(startDate));
		displayEndDate=(sdf.format(endDate));
		
	   } 
	/**
	 * This method is used to change the minimum date of the second calendar.
	 * This stops users from selecting an end date which is before the start date.
	 *
	 * @param event .Event generated when user selects a start date in booking.xhtml
	 */
	public void dateChange(SelectEvent event) {
		Calendar cal = Calendar.getInstance();
	    Date date = (Date) event.getObject();
	    Format f = new SimpleDateFormat("dd/MM/yyyy");
	    cal.setTime(date);
	    cal.add(Calendar.DAY_OF_MONTH,1);
	    minDateForEndDateCalender=(f.format(cal.getTime()));
	}
	
	/**
	 * DATES AND FORMATERS
	 * @return
	 */
	//Calculate todays date so booking start date cannot happen before today's date.
	public String today(){
		Date date = new Date();
		SimpleDateFormat sdf = new SimpleDateFormat("dd/MM/yyyy");
		return sdf.format(date);
	}
	//Set a max end date for the calendars. Users may only book up to 1 year in advance of
	//todays date.
	public String todayPlusYear(){
		Calendar date = Calendar.getInstance();  
	    date.setTime(new Date());  
	    Format f = new SimpleDateFormat("dd/MM/yyyy");    
	    date.add(Calendar.YEAR,1);  
	    return (f.format(date.getTime())); 
	}
	/**
	 * MISCELLANANIOUS 
	 */
	public void confirmBooking(){ 
		Booking b1 =new Booking(petName,petType,startDate,endDate);
		bookingList.add(b1);
		System.out.println(bookingList.size());
		System.out.println(bookingList);
	}
	
	public void deleteBooking() {
		
	}

/**
	 * Capacity of Kennels check
	 */
	public void checkCapacity(){
		int DailyCapacity=kennelCapacity;
	}
	/**
	 * GETTERS AND SETTERS
	 * 
	 */
	public String getDisplayStartDate() {
		return displayStartDate;
	}
	public void setDisplayStartDate(String displayStartDate) {
		this.displayStartDate = displayStartDate;
	}
	public String getDisplayEndDate() {
		return displayEndDate;
	}
	public void setDisplayEndDate(String displayEndDate) {
		this.displayEndDate = displayEndDate;
	}
	public Booking getBookObj() {
		return bookObj;
	}
	public void setBookObj(Booking bookObj) {
		this.bookObj = bookObj;
	}
	public long getDaysInKennels() {
		return daysInKennels;
	}
	public void setDaysInKennels(long daysInKennels) {
		this.daysInKennels = daysInKennels;
	}
	public long getBookingCost() {
		return bookingCost;
	}
	public void setBookingCost(long bookingCost) {
		this.bookingCost = bookingCost;
	}
	public String getMinDateForEndDateCalender() {
		return minDateForEndDateCalender;
	}
	public void setMinDateForEndDateCalender(String minDateForEndDateCalender) {
		this.minDateForEndDateCalender = minDateForEndDateCalender;
	}
	public String getMaxAheadOfTimeBooking() {
		return maxAheadOfTimeBooking;
	}
	public void setMaxAheadOfTimeBooking(String maxAheadOfTimeBooking) {
		this.maxAheadOfTimeBooking = maxAheadOfTimeBooking;
	}
	public String getCustomerBookingEmail() {
		return customerBookingEmail;
	}
	public void setCustomerBookingEmail(String customerBookingEmail) {
		this.customerBookingEmail = customerBookingEmail;
	}
	public String getToday() {
		return today;
	}
	public void setToday(String today) {
		this.today = today;
	}
	public String getPetName() {
		return petName;
	}
	public void setPetName(String petName) {
		this.petName = petName;
	}
	public String getPetType() {
		return petType;
	}
	public void setPetType(String petType) {
		this.petType = petType;
	}
	public Date getStartDate() {
		return startDate;
	}
	public void setStartDate(Date startDate) {
		this.startDate = startDate;
	}
	public Date getEndDate() {
		return endDate;
	}
	public void setEndDate(Date endDate) {
		this.endDate = endDate;
	}
	public boolean isGroomingService() {
		return groomingService;
	}
	public void setGroomingService(boolean groomingService) {
		this.groomingService = groomingService;
	}
	public boolean isNailClipping() {
		return nailClipping;
	}
	public void setNailClipping(boolean nailClipping) {
		this.nailClipping = nailClipping;
	}
	public boolean isVetService() {
		return vetService;
	}
	public void setVetService(boolean vetService) {
		this.vetService = vetService;
	}
	public String getPetUpdate() {
		return petUpdate;
	}
	public void setPetUpdate(String petUpdate) {
		this.petUpdate = petUpdate;
	}
	public ArrayList<Booking> getBookingList() {
		return bookingList;
	}
	public void setBookingList(ArrayList<Booking> bookingList) {
		this.bookingList = bookingList;
	}
	@Override
	public String toString() {
		return "Booking [petName=" + petName + ", petType=" + petType
				+ ", startDate=" + startDate + ", endDate=" + endDate + "]";
	}

}

And this is the booking.xhtml page where you make the booking

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" 
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<h:head><title>Booking</title></h:head>

<ui:composition template="/WEB-INF/templates/BasicTemplate.xhtml">

<ui:define name="content">
		<h:form id="bookingForm">
			<p:panel id="bookingPanel" style="margin-bottom:10px;">
	        <p:messages />
	        
	        	<h:outputText value="Welcome #{loginBean.loggedInCustomer.firstName} #{loginBean.loggedInCustomer.lastName}"  />
		        <h:panelGrid columns="2" cellpadding="5">
		        
			        <h:outputLabel for="petName" value="Pet Name: #{booking.petName}" />
			        <p:inputText id="petName" required="true" value="#{booking.petName}" autocomplete="off"/>
			        
			        <h:outputLabel for="petType" value="Pet Type:" />
			        <h:selectOneMenu id="dropDownPetType" value="#{booking.petType}">
        				<f:selectItem id="select1" itemLabel="Dog" itemValue='Dog'  />
        				<f:selectItem id="select2" itemLabel="Cat" itemValue='Cat'  />
   					</h:selectOneMenu>
					
					<h:outputLabel for="startDate" value="Booking Start Date:" />
			        <p:calendar mindate="#{booking.today}" maxdate="#{booking.maxAheadOfTimeBooking}" value="#{booking.startDate}" pattern="dd/MM/yyyy"
			        ><p:ajax event="dateSelect" listener="#{booking.dateChange}" update="calenderTwo"/></p:calendar>
			        
			        
			        
			        <h:outputLabel for="startDate" value="Booking End Date:" />
			        <p:calendar id="calenderTwo" mindate="#{booking.minDateForEndDateCalender}" maxdate="#{booking.maxAheadOfTimeBooking}" 
			        value="#{booking.endDate}" pattern="dd/MM/yyyy" />
			        
		        
		        </h:panelGrid>
		        
	    	</p:panel>
	    	
	    	<p:commandButton id="confirmBooking" value="Confirm"  
	    	 action="additionalServices" ><f:attribute name="email" value="#{loginBean.loggedInCustomer.email}" /></p:commandButton>
	    	
	    </h:form>
	</ui:define>
	
</ui:composition>
	
</html>

Tim Holloway

Saloon Keeper

Posts: 22511

151

I like...

posted 5 years ago

And a very fine welcome to yourself Raymond Self! Welcome to the JavaRanch!

We always recommend paring down your examples as small as you can before posting them. One of the problems with getting free assistance is that if the examples are too long and complicated, no one will volunteer to wade through them!

You're using an application-scope backing bean. Usually you wouldn't want to do that, because the same object is shared between all users and unless you take steps to make access thread-safe, multiple users can really scramble things.

However, what seems to be the real problem is that your datatable is attempting to use the same object ("booking") as both the backing bean that holds the table datamodel AND as the cursor/row model object (var) within that table.

So I imagine that JSF is probably getting pretty confused.

"privilege" comes from the Latin words for "private" and "law" (legal) and dates to feudal times. To "claim privilege" meant that you were above the laws that applied to the common people.

Raymond Self

Greenhorn

Posts: 12

posted 5 years ago

Hi thanks for the welcome sorry for the long code what do you mean by paring down? And have been thinking there should be a bookingData bean also as I have a customer and customerBean and the customerList displays perfectly but the booking one was setup in one file so am not sure what to copy into a new bookingData bean out of the booking bean, thanks for your help

Tim Holloway

Saloon Keeper

Posts: 22511

151

I like...

posted 5 years ago

We have a Wiki entry on keeping your examples simple, but basically, all we're asking is that you try and reduce the actual amount of stuff you post to just the minimum required to present the problem. In practical terms, once an example gets too big to fit on the screen, eyeballs glaze over. So, for example, your webapp may contain a set of 132 check boxes, but for our sakes, if it still mis-behaves when you have only 2, give us an example with just 2 check boxes. That way the forest doesn't obscure the trees.

What beans you have and how you partition stuff is mostly just what works for you. There's no requirement for a 1-1 correspondence between Model and View objects.

But, as I said, it looks like you were using the same name ("booking") to refer to 2 very different objects.

I usually just name my table cursor (var=) something imaginative like "row" or "item".

"privilege" comes from the Latin words for "private" and "law" (legal) and dates to feudal times. To "claim privilege" meant that you were above the laws that applied to the common people.

Yes, of course, and I accept that blame. In fact, i covet that blame. As does this tiny ad:

Thread Boost feature

https://coderanch.com/t/674455/Thread-Boost-feature