<s:select > populate data from database

[Pradeesh Pakkat]

Hi all,
I want to populate list of values from db to s:select tag and have to return id of the selected item from the list.
my jsp page

							<s:select name="stateId" id="stateId" label="State  *"
								list="states"
								headerKey="1" headerValue="--Select--" emptyOption="false"
								value="" />

my action class

private ArrayList<String> states;
		
	public ArrayList<String> getStates() {
		return states;
	}

	public void setStates(ArrayList<String> states) {
		states.add("Kerala");
		states.add("Tamil nadu");
		states.add("Karnataka");
		states.add("Andhra pradesh");
		this.states = states;
	}

error I obtained.

org.apache.jasper.JasperException: tag 'select', field 'list', name 'stateId': The requested list key 'states' could not be resolved as a collection/array/map/enumeration/iterator type. Example: people or people.{name} - [unknown location]
	org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:413)

please help me to solve this problem.

[Pradeesh Pakkat]

hey all,

I got my list in action class but I cann't connect it with the select tag in jsp. please help me.. what is the procedure...

[Pradeesh Pakkat]

please help me its really urgent... I don't know how to populate list to select tag.

[Joe Ess]

Pradeesh Pakkat wrote:please help me its really urgent...

Everyone's question on JavaRanch is urgent.
That said, does your action do anything? I don't see an execute method or anything that resembles one.

[Pradeesh Pakkat]

hi,

Everyone's question on JavaRanch is urgent.

Sorry for my emergency.

I have methods to populate the form values to database. It works properly(I hard core the value for select tag). Now the problem is that how can I populate bean list to jsp page.

action.java //I am just mentioning about the list. all other execute(), getters and setters are working fine

	public String displayStates() {
		String beanNamestate = StateManagementBeanRemote.REMOTE_JNDI_NAME;
		String interfaceNamestate = StateManagementBeanRemote.REMOTE_JNDI_INTERFACE_NAME;
		try {
			Object beanInstanceState = EJBServerClient.getBeanInstance(
					beanNamestate, interfaceNamestate,
					GlobalConstants.MODULE_DBSERVER);
			if (null != beanInstanceState) {
				System.out.println("NOT NULL BEAN INSTANCE OF STATE");
				StateManagementBeanRemote beanSTATE = (StateManagementBeanRemote) beanInstanceState;
				List<IndiaStates> states = beanSTATE.queryAllStates();
				Iterator<IndiaStates> statesIterator = states.iterator();
				while (statesIterator.hasNext()) {
					IndiaStates element = statesIterator.next();
					System.out.println(element.toString());
				}
			}
		} catch (Exception e) { // TODO: handle exception
			e.printStackTrace();
		}
		return "none";
	}

struts.xml

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE struts PUBLIC
"-//Apache Software Foundation//DTD Struts Configuration 2.0//EN"
"http://struts.apache.org/dtds/struts-2.0.dtd">

<struts>
	<constant name="struts.multipart.saveDir" value="D:\uploads" />
	<constant name="struts.devMode" value="true" />
	<constant name="struts.mapper.action.prefix.enabled" value="true" />

	<package name="default" extends="struts-default">
		<action name="registration" class="in.epss.cdac.web.action.RegisterAction">
			<interceptor-ref name="fileUpload">
				<param name="maximumSize">100000</param>

				<param name="allowedTypes">
					image/jpeg,image/jpg
				</param>
			</interceptor-ref>
			<interceptor-ref name="defaultStack"></interceptor-ref>
			<result name="input">/page/test1.jsp</result>
			<result name="success">/page/index.jsp</result>
			<result name="error">/page/errorpage.jsp</result>
		</action>
	</package>
</struts>

reg.jsp

<s:form action="registration" namespace="/page" method="post"
						enctype="multipart/form-data">
						<%-- <s:label>Personal information</s:label> --%>
						<s:div>


							<s:textfield id="firstName" name="firstName"
								placeholder="Enter first name" label="First Name    *" />

							<s:textfield id="lastName" name="lastName"
								placeholder="Enter last name" label="Last Name    *" />

							<s:textarea style="min-width:144px;" name="address" id="address"
								title="Enter your address" placeholder="address"
								label="Address  *" />

							<s:radio id="gender" name="gender" list="{'Male','Female'}"
								label="Gender  *" />

							<s:textfield label="Date of Birth  *" id="datepicker"
								name="dateOfBirth" format="dd/MM/yyyy" />

							<s:textfield name="city" id="city" label="City  *" />

							<s:textfield name="pincode" id="pincode" label="PIN code  *" />

							<s:textfield name="userSimNo" id="userSimNo" label="Device No  *" />

							<s:textfield name="mobileNo" id="mobileNo" label="Phone No  *" />

							<s:select name="stateId" id="stateId" label="State  *"
								list="{1,2,3}" listKey="" listValue=""
								headerKey="none" headerValue="-- select --" emptyOption="false"
								value="" />

							<s:file id="photo" name="image"
								label="Upload photo  * (Max size 100KB)" />

						</s:div>
<s:submit value="SUBMIT" id="form_submit_button"
								cssClass="refresh_button" />

[Joe Ess]

Why does displayStates() return a String?
Where does it get called? Have you checked the value of the states list after that invocation?

[Pradeesh Pakkat]

hi,

I just saw similar example somewhere else. But it couldn't help me to achieve the goal... Simply I just don't nothing about how to populate from list to jsp page in struts2. I go through some docs but i couldn't trace out the linking between jsp page and the list in the action class. Please help me to sort it out.

[Pradeesh Pakkat]

hi ,
any help please

[Joe Ess]

Have you considered the questions I asked?

[Pradeesh Pakkat]

hi,
I got some more information about the problem. As of my knowledge through Google is that we can't call jsp page directly after populating the list from the bean/action class. If we want to do so we have to call the action class ( Display.action instead of Display.jsp).

Why does displayStates() return a String?
Where does it get called? Have you checked the value of the states list after that invocation?

struts.xml

<action name="states" class="in.epss.cdac.web.action.StateBean"
			method="display">
			<result name="none">/page/test1.jsp</result>
		</action>

When framework starts the display function will automatically populate the list, 'I think so'.

Now my question changed to 'HOW CAN WE CALL AN ACTION PAGE DIRECTLY'

[Joe Ess]

Pradeesh Pakkat wrote: As of my knowledge through Google is that we can't call jsp page directly after populating the list from the bean/action class.

I'm not sure you understand how Struts works. The browser sends a request to a URL mapped to an action, the action performs whatever tasks necessary (usually obtaining or updating data) and forwards to a JSP. The JSP then renders whatever data the action set up and returns something (usually HTML) to the browser. There is no direct call to the JSP. If one were to invoke a JSP directly, there'd be no data to display.

When framework starts the display function will automatically populate the list, 'I think so'.

No it will not. You have made a really, really basic Java error in your action class. Please consider the questions I asked again. I have no idea why you posted a piece of your struts.xml file that refers to a class you haven't shown us.

Now my question changed to 'HOW CAN WE CALL AN ACTION PAGE DIRECTLY'

Answer 1. "you don't want to" because it would break the MVC pattern.
Answer 2: "you can't" - see the top of this post. If the action sets up the data, calling the JSP directly will not work.
Answer 3: "you can't" because Struts tags throw an error if the Struts framework doesn't run first.

[Pradeesh Pakkat]

hi Joe,

There is no direct call to the JSP. If one were to invoke a JSP directly, there'd be no data to display.

by direct call to the jsp I mean the URL to be display in the address bar.(like http://10.xxx.16.xx:8080/EpssService/page/test1.jsp when it comes through the action class it will become http://10.xxx.16.xx:8080/EpssService/page/registration.action).

this is my struts.xml

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE struts PUBLIC
"-//Apache Software Foundation//DTD Struts Configuration 2.0//EN"
"http://struts.apache.org/dtds/struts-2.0.dtd">
<struts>
	<constant name="struts.multipart.saveDir" value="D:\uploads" />
	<constant name="struts.devMode" value="true" />
	<constant name="struts.mapper.action.prefix.enabled" value="true" />

	<package name="default" extends="struts-default">
		<action name="registration" class="in.epss.cdac.web.action.RegisterAction" method="execute">
			<interceptor-ref name="fileUpload">
				<param name="maximumSize">100000</param>

				<param name="allowedTypes">
					image/jpeg,image/jpg
				</param>
			</interceptor-ref>
			<interceptor-ref name="defaultStack"></interceptor-ref>
			<result name="input">/page/test1.jsp</result>
			<result name="success">/page/index.jsp</result>
			<result name="error">/page/errorpage.jsp</result>
		</action>
	</package>
</struts>

this is my action class

package in.epss.cdac.web.action;

import in.cdac.client.EpssUserMgtBeanRemote;
import in.cdac.comm.UserInfo;
import in.cdac.comm.constants.GlobalConstants;
import in.cdac.comm.exception.DBServerException;
import in.cdac.ejbserver.client.EJBServerClient;

import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.sql.Date;

import javax.servlet.http.HttpServletRequest;

import org.apache.struts2.ServletActionContext;

import com.opensymphony.xwork2.ActionSupport;

@SuppressWarnings("serial")
public class RegisterAction extends ActionSupport {

	private Long userSimNo;

	private String firstName;

	private String lastName;

	private String address;

	private String city;

	private String pincode;

	private Integer stateId;

	private String stname;

	private Long mobileNo;

	private Date dateOfBirth;

	private String gender;

	private byte[] photo;

	private String contact1Name;

	private String contact1Relation;

	private Long contact1PhoneNo;

	private Long contact1AltPhoneNo;

	private String contact1Gender;

	private String contact1Address;

	private String contact2Name;

	private String contact2Relation;

	private Long contact2PhoneNo;

	private Long contact2AltPhoneNo;

	private String contact2Gender;

	private String contact2Address;

	private String contact3Name;

	private String contact3Relation;

	private Long contact3PhoneNo;

	private Long contact3AltPhoneNo;

	private String contact3Gender;

	private String contact3Address;

	private String contact4Name;

	private String contact4Relation;

	private Long contact4PhoneNo;

	private Long contact4AltPhoneNo;

	private String contact4Gender;

	private String contact4Address;

	private String captcha;

	private boolean agree;

	private File image;

	private HttpServletRequest httpServletRequest;

	private String imageContentType;

	private String imageFileName;
<!--
Setters and getters of the variables.	
-->

	/* execute method where the actual logic is going to takes place */

	@SuppressWarnings({ "resource" })
	public String execute() throws ClassNotFoundException,
			FileNotFoundException {

		String beanNamestate = StateManagementBeanRemote.REMOTE_JNDI_NAME;
		String interfaceNamestate = StateManagementBeanRemote.REMOTE_JNDI_INTERFACE_NAME;
		try {
			Object beanInstanceState = EJBServerClient.getBeanInstance(
					beanNamestate, interfaceNamestate,
					GlobalConstants.MODULE_DBSERVER);
			if (null != beanInstanceState) {
				System.out.println("NOT NULL BEAN INSTANCE OF STATE");
				StateManagementBeanRemote beanSTATE = (StateManagementBeanRemote) beanInstanceState;
				System.out.println("Bean instance created");
				List<IndiaStates> states = beanSTATE.queryAllStates();
				System.out.println("Querry executed");
				Iterator<IndiaStates> statesIterator = states.iterator();
				System.out
						.println("converted into iterator Going to while loop");
				while (statesIterator.hasNext()) {
					String statename = statesIterator.next().getStateName()
							.toString();
					System.out.println(statename);
				}
			}
		} catch (Exception e) {
			e.printStackTrace();
		}
		
		System.out.println("hai its from execute method");
		httpServletRequest = ServletActionContext.getRequest();
		String filePath = httpServletRequest.getSession().getServletContext()
				.getRealPath("/").concat("image");
		System.out.println("***********" + filePath);
		FileInputStream fis = new FileInputStream(image);

		ByteArrayOutputStream bos = new ByteArrayOutputStream();
		byte[] buf = new byte[2048];
		try {
			for (int readNum; (readNum = fis.read(buf)) != -1;) {
				// Writes to this byte array output stream
				bos.write(buf, 0, readNum);
				System.out.println("read " + readNum + " bytes,");
			}

		} catch (IOException ex) {
			ex.printStackTrace();
		}

		photo = bos.toByteArray();

		System.out.println("success");

		// Setting the information to the UserInfo object

		UserInfo userInfo = new UserInfo();
		userInfo.setFirstName(firstName);
		userInfo.setLastName(lastName);
		userInfo.setAddress(address);
		userInfo.setGender(gender);
		userInfo.setDateOfBirth(dateOfBirth);
		userInfo.setCity(city);
		userInfo.setPincode(pincode);
		userInfo.setUserSimNo(Long.valueOf(userSimNo));
		userInfo.setMobileNo(Long.valueOf(mobileNo));
		userInfo.setState(2);
		userInfo.setPhoto((byte[]) photo);
		userInfo.setContact1Name(contact1Name);
		userInfo.setContact1Relation(contact1Relation);
		userInfo.setContact1Gender(contact1Gender);
		userInfo.setContact1Address(contact1Address);
		userInfo.setContact1PhoneNo(Long.valueOf(contact1PhoneNo));
		userInfo.setContact1AltPhoneNo(contact1AltPhoneNo);

		System.out.println(userInfo.toString());

		// EJB Invocation to check whether someone has already logged in
		String beanName = EpssUserMgtBeanRemote.REMOTE_JNDI_NAME;
		String interfaceName = EpssUserMgtBeanRemote.REMOTE_JNDI_INTERFACE_NAME;
		Object beanInstance = EJBServerClient.getBeanInstance(beanName,
				interfaceName, GlobalConstants.MODULE_DBSERVER);

		if (null != beanInstance) {
			System.out.println("NOT NULL Bean Instance Obtained");
			EpssUserMgtBeanRemote bean = (EpssUserMgtBeanRemote) beanInstance;
			try {
				Long userId = bean.addNewUser(userInfo);
				System.out.println(userId);
			} catch (DBServerException e) {
				e.printStackTrace();
			}
		}
		return SUCCESS;
	}
}

Answer 1. "you don't want to" because it would break the MVC pattern.
Answer 2: "you can't" - see the top of this post. If the action sets up the data, calling the JSP directly will not work.
Answer 3: "you can't" because Struts tags throw an error if the Struts framework doesn't run first.

Now I simply asking you that how can I populate a list containing items from database.
my jsp page

<!doctype html>

<%@page import="com.opensymphony.xwork2.ActionContext"%>
<%@page import="java.util.Map"%>
<%@page import="in.cdac.client.StateManagementBeanRemote"%>
<%@page import="in.cdac.comm.constants.GlobalConstants"%>
<%@page import="in.cdac.ejbserver.client.EJBServerClient"%>
<%@page import="java.util.ArrayList"%>
<%@page import="java.util.List"%>
<%@ page import="java.util.Iterator"%>
<%@page import="in.cdac.comm.IndiaStates"%>
<html>
<head profile="http://www.w3.org/2005/10/profile">
<link rel="icon" type="image/png" href="../resources/images/logo1.png">
<meta charset="utf-8">
<title>EpssServices</title>
<%@include file="header.jsp"%>

<!-- import files -->

<%@taglib uri="/struts-tags" prefix="s"%>
<%@ taglib uri="/struts-dojo-tags" prefix="sx"%>

<link rel="stylesheet"
    href="../resources/css/ui-lightness/jquery-ui-1.10.3.custom.css" />
<script src="../resources/js/jquery-1.9.1.js" type="text/javascript"></script>
<script src="../resources/js/test.js" type="text/javascript"></script>
<script src="../resources/js/jquery.tools.min.js" type="text/javascript"></script>
<script src="../resources/js/jquery-ui-1.10.3.custom.js"
    type="text/javascript"></script>
<script src="../resources/js/validate.js" type="text/javascript"></script>
<link rel="stylesheet" href="../resources/css/style.css" type="text/css" />
<link rel="stylesheet" href="../resources/css/Regform.css"
    type="text/css" />

<!-- import files close -->
<!--JAVA Script-->
<script type="text/javascript">
    /* $(function() {
        $("#accordion").accordion();
    }); */
    $(function() {
        $("#datepicker").datepicker({
            changeMonth : true,
            changeYear : true
        });
        $("#datepicker").datepicker("option", "dateFormat", "dd/mm/yy");
        $("#datepicker").datepicker("option", "changeYear", "true");
        $("#datepicker")
                .datepicker("option", "minDate", new Date('01/01/1901'));
        $("#datepicker").datepicker("option", "maxDate", "d");
        $("#datepicker").datepicker("option", "yearRange", "-100:d");
    });
</script>

<script type="text/javascript">
    function checkuser(tryThisName) {
        alert("hi ajax function");
        var xmlhttp;
        if (window.XMLHttpRequest)
            xmlhttp = new XMLHttpRequest();
        else
            xmlhttp = new ActiveXObject('Microsoft.XMLHTTP');

        xmlhttp.open("GET", "checkuserAvailability.jsp?userSimNo="
                + tryThisName, true);
        xmlhttp.send();
        xmlhttp.onreadystatechange = function() {
            if (xmlhttp.readyState == 4 && xmlhttp.status == 200) {
                document.getElementById("statusOfName").innerHTML = xmlhttp.responseText;
            }
            //alert(xmlhttp.responseText);
        }
    }
</script>
<!--JAVA Script close-->


</head>

<body>
        <!--main_wraper-->
    <div id="main_wraper">

        <div class="main_conent">
            <!-- <div id="accordion"> -->

            <div align="center">

                <!-- Starting registration form including personal information, gaurdian information and confirmations.
                     Data are transfered to the RegistrationAction.java .
                     Further process on the input will carried out from the java class-->
                <s:div id="accordion">
                    <s:form action="registration" namespace="/page" method="post"
                        enctype="multipart/form-data">
                        <%-- <s:label>Personal information</s:label> --%>
                        <sx:tabbedpanel id="tabContent">

                            <sx:div id="personalInformation" label="Personal Information">
                                <s:textfield id="firstName" name="firstName"
                                    placeholder="Enter first name" label="First Name    *"
                                    onkeypress="javascript:return letterFilter(event);" />

                                <s:textfield id="lastName" name="lastName"
                                    placeholder="Enter last name" label="Last Name    *"
                                    onkeypress="javascript:return letterFilter(event);" />

                                <s:textarea style="min-width:144px;" name="address" id="address"
                                    title="Enter your address" placeholder="address"
                                    label="Address  *"
                                    onkeypress="javascript:return letterFilterwithEnter(event);" />

                                <s:radio id="gender" name="gender" list="{'Male','Female'}"
                                    label="Gender  *" />

                                <s:textfield label="Date of Birth  *" id="datepicker"
                                    name="dateOfBirth" format="dd/MM/yyyy" />

                                <s:textfield name="city" id="city" label="City  *"
                                    onkeypress="javascript:return letterFilter(event);" />

                                <s:textfield name="pincode" id="pincode" label="PIN code  *"
                                    onkeypress="javascript:return integerFilter(event);" />

                                <s:textfield name="userSimNo" id="userSimNo"
                                    label="Device No  *"
                                    onkeypress="javascript:return integerFilter(event);" />

                                <s:textfield name="mobileNo" id="mobileNo" label="Phone No  *"
                                    onkeypress="javascript:return integerFilter(event);" />

                                <s:select list="{1,2,3,4}" headerKey="1" id="states"
                                    name="stateId" emptyOption="false" label="State  *" />

                                <s:file id="photo" name="image"
                                    label="Upload photo  * (Max size 100KB)" />

                            </sx:div>
                            <%-- <s:label>Gaurdian Information</s:label> --%>
                            <sx:div label="Gaurdian Information">
                                <s:textfield id="contact1Name" label="Name  *"
                                    name="contact1Name" placeholder="Name" autocomplete="on"
                                    onkeypress="javascript:return letterFilter(event);" />



                                <s:textfield label="Relation  *" id="contact1Relation"
                                    name="contact1Relation" placeholder="Relation"
                                    onkeypress="javascript:return letterFilter(event);" />

                                <s:radio label="Gender  *" id="contact1Gender"
                                    name="contact1Gender" list="{'Male','Female'}" />


                                <s:textfield placeholder="Enter phone number1"
                                    id="contact1PhoneNo" name="contact1PhoneNo"
                                    label="Phone No1  *"
                                    onkeypress="javascript:return integerFilter(event);" />

                                <s:textfield placeholder="Enter phone number2"
                                    id="contact1AltPhoneNo" name="contact1AltPhoneNo"
                                    label="Phone No 2"
                                    onkeypress="javascript:return integerFilter(event);" />

                                <s:textarea label="Address  *" id="contact1Address"
                                    name="contact1Address" placeholder="address  *" />
                            </sx:div>
                            <%-- <s:label>Agreement</s:label> --%>
                            <sx:div label="Agreement">
                                <p>Captcha case Sensitive*</p>
                                <img id="captchaImg" src="/CaptchaServlet" />

                                <s:textfield id="captcha" name="captcha"
                                    placeholder="Enter the text here" />
                                <s:reset name="refresh" id="refresh_button" value="Refresh"
                                    cssClass="refresh_button" />
                                <s:checkbox
                                    label="I here by declare
                        that the above details are true to the best of my knowledge and
                        belief and I understand that this information is used to extend
                        emergency help to me when I am in distress by the use of the
                        Electronic Personal Safety System(ePSS)."
                                    name="agree" id="agree" />

                                <s:reset name="reset" id="reset_buttton" value="Reset"
                                    cssClass="refresh_button" />
                                <s:submit value="SUBMIT" id="form_submit_button"
                                    cssClass="refresh_button" />
                            </sx:div>

                        </sx:tabbedpanel>
                    </s:form>
                </s:div>

                <s:a action="function" label="hi test">test</s:a>
            </div>
        </div>
        <!--Accordion div close-->
        <!--    </div> -->
        <!--Main COntent div close-->
    </div>
    <!--Main wraper div close-->
    <!---main_wraper_close-->
</body>
<%@ include file="footer.jsp"%>
</html>

[Joe Ess]

I'll say this again:

Joe Ess wrote:
You have made a really, really basic Java error in your action class. Please consider the questions I asked again.

Pradeesh Pakkat wrote:
by direct call to the jsp I mean the URL to be display in the address bar.

It is possible to do database access from a JSP (a JSP is compiled into Java Servlet so whatever you can do in a plain old Servlet you can do in a JSP). This is generally considered a Bad Thing because JSP's are display components and data access should be in a controller component (See MVC Pattern). It will cause a problem with your page in particular because Struts tags will throw an error if the Struts framework doesn't run before they are processed.
You are attempting to route around a logic error in your action class. It's always a good idea to isolate the problem as the code samples you posted are fairly large. Think about how you are obtaining the list of states and how that list is accessed on the JSP.

[Pradeesh Pakkat]

Joe Ess wrote
Why does displayStates() return a String?
Where does it get called? Have you checked the value of the states list after that invocation?

I removed the function display() from the action class so there is no call to this function too. After invoking the list through RMI I printed it. It worked well @ the action class.

Joe Ess wrote
Think about how that list is accessed on the JSP.

I don't know and that's my problem.... I just saw populating the list through JSONto the JSP and I am working on it. I am using struts with maven. Hope your kindness and help....

[Pradeesh Pakkat]

Joe Ess wrote
You have made a really, really basic Java error in your action class.

I couldn't figure it out ...:-(

[Joe Ess]

Pradeesh Pakkat wrote:

Joe Ess wrote
You have made a really, really basic Java error in your action class.

I couldn't figure it out ...:-(

Let me rephrase my question:
How does the JSP obtain the list named "states"?