What is wrong with this nested loop array code?

[Jeremy Schuler]

public class ChristmasProjectNestedLoops
{
String[] d = {"first","second","third","fourth","fifth","sixth","seventh","eighth","ninth","tenth","eleventh","twelth"};

String[] items = { "A partridge in a pear tree", "two turtle doves, and" , "three french hens," , "four calling birds," ,
"five golden rings,", "six geese a laying,", "seven swans a swimming," ,"eight maids a milking,", "nine ladies dancing,"
,"ten lords a leaping," ,"eleven pipers piping,", "twelve drummers drumming," ,};
{

for (int day = 0; day < d.length; d++)
{
System.out.println("On the %s day of Christmas, my true love gave to me, " + d[day]);
for (int item = day; item >= 0; item --)
{
System.out.print(items[item]);
}
}

}
}

[Harish Shivaraj]

Look at the look again. Are you incrementing/decrementing the index right?

		for( int day = 0; day < d.length; day++ )
		{
			System.out.println( "On the %s day of Christmas, my true love gave to me, " + d[ day ] );
			
			for( int item = day; item >= 0; item-- )
			{
				System.out.print( items[ item ] );
			}
		}

And remember to use the code tags. *important* ;)

[Jeremy Schuler]

public class ChristmasProjectNestedLoops 
{
	String[] d = {"first","second","third","fourth","fifth","sixth","seventh","eighth","ninth","tenth","eleventh","twelth"};
	
	String[] items = { "A partridge in a pear tree", "two turtle doves, and" , "three french hens," , "four calling birds," ,
			"five golden rings,", "six geese a laying,", "seven swans a swimming," ,"eight maids a milking,", "nine ladies dancing,"
			,"ten lords a leaping," ,"eleven pipers piping,", "twelve drummers drumming," ,}; 
	{

			for (int day = 0; day < d.length; day++) 
	{
				 for( int day1 = 0; day1 < d.length; day1++ )  
			        {  
			            System.out.printf( "On the %s day of Christmas, my true love gave to me, " , d[ day1 ] );  
			              
			            for( int item = day1; item >= 0; item-- )  
			            {  
			                System.out.print( items[ item ] );  
			            }  
			        }  
	}
	
}
}

So this?

[Carey Brown]

You don't need the day1 loop at all.

[Stefan Evans]

Not quite.
Your first effort was closer. You only need two loops. The very first example you had a "d++" rather than a "day++" which possibly explained why it wasn't printing .

At some point you will probably want to issue a "System.out.println()"
Otherwise everything just gets written on the one line.

When a line gets really long, strange stuff can happen.
When running your above code in Eclipse, it worked, but the output was waaaaaaaay off to the right before I actually saw anything printed.
Putting in a System.out.println made it 'work'

[Jeremy Schuler]

public class ChristmasProjectNestedLoops 
{ 
String[] d = {"first","second","third","fourth","fifth","sixth","seventh","eighth","ninth","tenth","eleventh","twelth"}; 

String[] items = { "A partridge in a pear tree", "two turtle doves, and" , "three french hens," , "four calling birds," , 
"five golden rings,", "six geese a laying,", "seven swans a swimming," ,"eight maids a milking,", "nine ladies dancing," 
,"ten lords a leaping," ,"eleven pipers piping,", "twelve drummers drumming," ,}; 
{ 

	 for( int day = 0; day < d.length; day++ )  
     {  
         System.out.println( "On the %s day of Christmas, my true love gave to me, " + d[ day ] );  
           
         for( int item = day; item >= 0; item-- )  
         {  
             System.out.print( items[ item ] );  
         }  
     }  

} 
} 

So this is what I think you mean is correct, but it still won't compile? Btw thank you so much for the help

[Tony Docherty]

Welcome to the Ranch.

Saying it won't compile or it doesn't work doesn't help us to help you, . Please TellTheDetails (← click)

[Jeremy Schuler]

Ok, I apologize, still sort of new here.

Anyways, after a bit of searching for a better compiler, I found this error:



This string: System.out.println( "On the %s day of Christmas, my true love gave to me, " + d[day] ); is a string, when it must be a localized string.

[Stefan Evans]

Thats not an error I recognise.

What compiler are you using? the standard javac?
How are you compiling/running your code?

[Jeremy Schuler]

I'm using the compiler framework and compiling the code through eclipse. Eclipse didn't catch a single error in the code, but I knew there was one there, so I used the compiler framework. I don't recognize the error either, which is why I asked

[Carey Brown]

Where is your 'main()' method? I had to add one to get Eclipse to compile it.

[Arun Peter]

Is all this written in the class directly or in a method inside the class? I see an opening brace after the items declaration, no methods.

[Tony Docherty]

I think there is a big confusion going on here.

1. You do not need a main method to get this to compile, it compiles fine as is. What you do need a main method for is to get it to run.
2. The code is written as an initialiser block so it is fine (albeit it is a strange way to write the code) and will run once whenever a new object is created.

To get the code to run add a main method which creates an instance of the class and you also need to add a System.out.println(); at the end of the outer loop to prevent it all printing on one line. You also need to change the line

System.out.println( "On the %s day of Christmas, my true love gave to me, " + d[ day ] );  

to a System.out.printf.

Once you've done that I suggest you move the code from an initializer block to a default constructor - it's fairly unusual to need to use initializer blocks and you certainly don't need to use them as a beginner.

[Jeremy Schuler]

Holy crap LOL I was so focused on finding an error that I just completely forgot to add the main... biggest idiot moment in weeks