Groovy If else statement ignoring the if condition in block of code

[Ann Doyle]

Hello. I have a piece of code that I've been working on using JDBC and Groovy, to retrieve id's from a specified filter for report results.
I have my filter wrapped in an if else statement, which checks for All book types in the if and everything else in the else.

However, when I select 'All' as my filter choice, the if appears to be ignored and the else code is run, which cannot return a correct id for this choice, causing it to fail.
I am at a loss as to why this block of code is being ignored.

The code is as follows:

def bookTypeQueryResults = [] if(bookType.equals("ALL")){ String allbooksQuery = "SELECT distinct type from book_manager.book_type;" def allbookTypeQueryResults = [] bookDb.eachRow(allbooksQuery) { allbookTypeQueryResults << it.type } String bookTypeQuery = "SELECT id from book_manager.book_type where type IN (('${allbookTypeQueryResults.join(",")}'));" bookDb.eachRow(bookTypeQuery) { bookTypeQueryResults << it.id } } else { String bookTypeQuery = "SELECT id from book_manager.book_type where type = '${bookType}';" bookDb.eachRow(bookTypeQuery) { bookTypeQueryResults << it.id } }

This code is then passed into another query which gets back the book type by the specified id:
book.book_type_id IN ('${bookTypeQueryResults.join(",")}')

[Knute Snortum]

I can't see anything wrong with the if statement. I would put an assert in the else part of the if to see if all of your assumptions are correct.

[Mark Spritzler]

Um, what is the actual value of bookType? You can either put a break point in there to see the value when it gets there, or a log message, or even a println "${bookType}"

Maybe there isn't an "ALL" value, maybe it is "All" or "all" where it is a different case. The only time an else will run is if the "if" is truly false. I like that truly false. Or just false.

Mark