javax.mail.SendFailedException: Invalid Addresses; nested exception is:

[Farakh khan]

Hello,

package sti.common.src;

import java.io.*;
import java.util.*;
import javax.mail.*;
import javax.mail.internet.*;   
import javax.mail.event.*;      
import java.net.*;
import javax.activation.*;

public class SendEmail extends ConfigProperties{

        public static void send(String from, String to, String subject, String content) throws AddressException, MessagingException{

		ErrorCheck ec	= new ErrorCheck();
		String error = "";
		
		try{
			error 	= ec.error();
		
			String smtp = getPropVal("SMTP");
			String host = getPropVal("HOST");
		
			Properties props=new Properties();
	        	props.put(smtp,host);
			Session   session1  =  Session.getDefaultInstance(props,null);
			Message msg =new MimeMessage(session1);

		   	msg.setHeader("Content-Type", "text/plain; charset=UTF-8");
		   	msg.setHeader("Content-Transfer-Encoding", "quoted-printable");           
	
			   msg.setFrom(new InternetAddress(from));
		      	   msg.setRecipients(Message.RecipientType.TO,InternetAddress.parse(to,false));
			   msg.setSubject(subject);
			   msg.setContent(content,"text/html; charset=UTF-8");      
	   
        		Transport.send(msg); 
        		
        	}catch(Exception e){
			ec.errorMsg(error+"SendEmail.send()", e);
        	}
        }
}

Calling this method like this:

if(emails==null || emails.equals("")){
		emails="";
		}else{		
		SendEmail.send("[e-mail]", emails, subject, mailmsg);
		}         
			if (count > 0 && count % 450 == 0){
    			Thread.sleep(5000);
			}
		}

My this working fine but when there is a invalid address then its throwing the following error and quit the loop that results all rest of the emails unsent.

javax.mail.SendFailedException: Invalid Addresses; nested exception is:
com.sun.mail.smtp.SMTPAddressFailedException: 550 sorry, no mailbox here by that name. (#5.7.17)

Is there any way to get all:
1) successfully sent mail addresses
2) invalid address
3) valid but unsent address
4) That is most important to log the aforementioned emails in a file
5) Must not quit the loop until & unless my program is not sending all listed emails

Please advise

Thanks in anticipation

[Ashley Bye]

Farakh khan wrote:Is there any way to get all:
1) successfully sent mail addresses
2) invalid address
3) valid but unsent address

Why not catch the exception and store its details in a collection for processing later? You can do the same for sent emails, etc.

Farakh khan wrote:Must not quit the loop until & unless my program is not sending all listed emails

Can you post the conditions for the loop that is unexpectedly terminating?

[Farakh khan]

Hello,

I was googling and found very useful link that is related to my question http://stackoverflow.com/questions/15131868/how-resolve-address-invalid-exception

Now what I written this code in the catch block:

}catch (SendFailedException e){   
			try{				
				String validSentAddresses = "";
				String validUnsentAddresses = "";
                		String invalidAddresses = "";

				validSentAddresses 	+= e.getValidSentAddresses()+",";
				validUnsentAddresses	+= e.getValidUnsentAddresses()+",";
				invalidAddresses	+= e.getInvalidAddresses()+",";
								
					printReport("validSentAddresses.txt", validSentAddresses);
					printReport("validUnsentAddresses.txt", validUnsentAddresses);
					printReport("invalidAddresses.txt", invalidAddresses);				
				
            		}catch(Exception e2){ 
				ec.errorMsg("ERROR: SendEmail.send()", e2);
			}
		ec.errorMsg("ERROR: GSW.SendEmail.send()", e);
        	}//main catch block
        }

	public static void printReport(String fileName, String str)throws Exception{
		PrintStream out = new PrintStream(new FileOutputStream(fileName));
		System.setOut(out);
		System.out.println(str);
	}

Can you post the conditions for the loop that is unexpectedly terminating?

I am making call to SendEmail class from other classes like:

//reading emails from database into variable emails and the following code is running in while(rs.next()) loop
if(emails==null || emails.equals("")){
        emails="";
        }else{      
        SendEmail.send("[e-mail]", emails, subject, mailmsg);
        }         
            if (count > 0 && count % 450 == 0){
                Thread.sleep(5000);
            }
        }

Thanks for your reply

[Farakh khan]

can anybody please help while my following code writing garbage to a file

validSentAddresses  += e.getValidSentAddresses()+",";
                validUnsentAddresses    += e.getValidUnsentAddresses()+",";
                invalidAddresses    += e.getInvalidAddresses()+",";

[Farakh khan]

I am trying to write to a file the record of emails that are validSentAddresses + validUnsentAddresses + invalidAddresses to refine our record in database as well as to know check invalidAddresses

Please advise.

Thanks in anticipation

[Paul Clapham]

Your second-to-last post doesn't write to any files, so saying that code is "writing garbage to a file" and saying nothing else is something which can't be answered in any way. Perhaps you could produce some actual code and show us what it actually does? Just saying something is "garbage" is unhelpful, we need to see what's happening.

[Farakh khan]

I am sorry to not post my full code. I made some changes and here is my code:

        public static void send(String from, String to, String subject, String content) throws AddressException, MessagingException{

		ErrorCheck ec	= new ErrorCheck();
		
		try{
			
			String smtp = "smtp.domainName.com";
			String host = "localhost";
		
			Properties props=new Properties();
	        	props.put(smtp,host);
			Session   session1  =  Session.getDefaultInstance(props,null);
			Message msg =new MimeMessage(session1);

		   	msg.setHeader("Content-Type", "text/plain; charset=UTF-8");
		   	msg.setHeader("Content-Transfer-Encoding", "quoted-printable");           
	
			   msg.setFrom(new InternetAddress(from));
		      	   msg.setRecipients(Message.RecipientType.TO,InternetAddress.parse(to,false));
			   msg.setSubject(subject);
			   msg.setContent(content,"text/html; charset=UTF-8");      
	   
        		Transport.send(msg); 
			
			try{
    				printReport("GSWvalidSentAddresses.txt", to);//validSentAddresses
	        	}catch (Exception ex){
				ec.errorMsg("ERROR: SendEmail.Exception =>>",ex);
			}	    	
        	}catch (SendFailedException e){   
			try{				
				SendFailedException sfe=(SendFailedException)e.getCause();
    				Address[] validUnsentAddresses1	= sfe.getValidUnsentAddresses();
    				Address[] invalidAddresses1	= sfe.getInvalidAddresses();

				String validUnsentAddresses	= validUnsentAddresses1[0].toString();
				String invalidAddresses		= invalidAddresses1[0].toString();

					printReport("GSWvalidUnsentAddresses.txt", validUnsentAddresses);
					printReport("GSWinvalidAddresses.txt", invalidAddresses);				
				
            		}catch(Exception e2){ 
				ec.errorMsg("ERROR: SendEmail.send()", e2);
			}
		ec.errorMsg("ERROR: SendEmail.send()", e);
        	}//main catch block
        }

	private static void printReport(String fileName, String str)throws Exception{

		ErrorCheck ec = new ErrorCheck();
		try {
			File fileDir = new File(fileName); 
			Writer out = new BufferedWriter(new OutputStreamWriter(new FileOutputStream(fileDir), "UTF8")); 
			out.append(str).append("\r\n");		
			out.flush();
			out.close();

	    	}catch (UnsupportedEncodingException e){
			ec.errorMsg("ERROR: SendEmail.UnsupportedEncodingException =>",e);
	   	}catch (IOException e){
			ec.errorMsg("ERROR: SendEmail.IOException =>",e);
	    	}catch (Exception e){
			ec.errorMsg("ERROR: SendEmail.Exception =>",e);
	   	} 			
	}

Best regrads

[Paul Clapham]

Okay. And does that code do something which you don't like? If so, what?

By the way I see you're only using the first of the valid unsent addresses and only the first of the invalid addresses, but perhaps that's just something quick to test the code? But what happens if one of those arrays has no elements?

[Farakh khan]

Thanks for your reply.

I read in javax.mail API and found that if we set property of reportSuccess to true then it must read sendFailedException. I set tis property but still no success. All 3 files that am writing are still blank.

What condition I use if record is null?

Thanks again

[Paul Clapham]

Farakh khan wrote:I read in javax.mail API and found that if we set property of reportSuccess to true then it must read sendFailedException. I set tis property but still no success. All 3 files that am writing are still blank.

I find that very hard to believe. You've passed a non-blank "to" address into that method and when you use your code to write it to a file, the file is blank? That suggests to me that either your code is wrong or you're looking at the wrong file. Clearly it can't be anything to do with JavaMail because none of the code involved in writing that "to" address is JavaMail code.

What condition I use if record is null?

I don't understand what "record" means there or where you might be using some condition based on its nullity.

[Farakh khan]

Paul Clapham wrote: I find that very hard to believe. You've passed a non-blank "to" address into that method and when you use your code to write it to a file, the file is blank? That suggests to me that either your code is wrong or you're looking at the wrong file. Clearly it can't be anything to do with JavaMail because none of the code involved in writing that "to" address is JavaMail code.

I was checking JavaMailAPI that stats :
SMTPAddressSucceededException:This exception is chained off a SendFailedException when the mail.smtp.reportsuccess property is true.

This will cause Transport.send to always throw SendFailedException.

So what I change in my code is as below:
I added:

props.put("mail.smtp.reportsuccess","true");

and removed this part:

try{
                printReport("GSWvalidSentAddresses.txt", to);//validSentAddresses
            }catch (Exception ex){
            ec.errorMsg("ERROR: SendEmail.Exception =>>",ex);
        }           
        }catch (SendFailedException e){   

Finally, Now the catch block is like:

}catch (SendFailedException e){   
			try{				
				SendFailedException sfe=(SendFailedException)e.getCause();
    				Address[] validSentAddresses1	= sfe.getValidSentAddresses();
    				Address[] validUnsentAddresses1	= sfe.getValidUnsentAddresses();
    				Address[] invalidAddresses1	= sfe.getInvalidAddresses();

				String validSentAddresses 	= validSentAddresses1[0].toString();
				String validUnsentAddresses	= validUnsentAddresses1[0].toString();
				String invalidAddresses		= invalidAddresses1[0].toString();

					printReport("GSWvalidSentAddresses.txt", validSentAddresses);
					printReport("GSWvalidUnsentAddresses.txt", validUnsentAddresses);
					printReport("GSWinvalidAddresses.txt", invalidAddresses);				
				
            		}catch(Exception e2){ 
				ec.errorMsg("ERROR: GSW.SendEmail.send()", e2);
			}
		ec.errorMsg("ERROR: GSW.SendEmail.send()", e);
        	}//main catch block

I again tried and run this code but still nothing written in files

I don't understand what "record" means there or where you might be using some condition based on its nullity.

This was in response to your message with timestamp Yesterday 9:47:17 PM i.e. listed below

By the way I see you're only using the first of the valid unsent addresses and only the first of the invalid addresses, but perhaps that's just something quick to test the code? But what happens if one of those arrays has no elements?

Thanks for giving me your precious time

[Paul Clapham]

Farakh khan wrote:Thanks for giving me your precious time

Did you know that when you write this in a post, it sounds like you're being sarcastic? I'm going to assume you aren't, for now...

Anyway what we have so far is that you've changed some code to something else, but you haven't explained what problems remain. One problem that I can see is that your code still assumes there's exactly one valid sent address, exactly one valid unsent address, and exactly one invalid address.

[Farakh khan]

Hello,

Now this is the final code that I was able to write:

public static void send(String from, String to, String subject, String content) throws AddressException, MessagingException{

		ErrorCheck ec	= new ErrorCheck();		

		try{			

			String smtp = "smtp.domainName.com";
			String host = "localhost";		

			Properties props=new Properties();
	        	props.put(smtp,host);
			//props.put("mail.smtp.reportsuccess","true");
			Session   session1  =  Session.getDefaultInstance(props,null);			
			Message msg =new MimeMessage(session1);

		   	msg.setHeader("Content-Type", "text/plain; charset=UTF-8");
		   	msg.setHeader("Content-Transfer-Encoding", "quoted-printable");           

			   msg.setFrom(new InternetAddress(from));
		      	   msg.setRecipients(Message.RecipientType.TO,InternetAddress.parse(to,false));
			   msg.setSubject(subject);
			   msg.setContent(content,"text/html; charset=UTF-8");	   

        		Transport.send(msg);

        		try{
				if(!to.equals("")){

                			printReport("validSentAddresses.txt", to);//validSentAddresses
				}

            		}catch (Exception ex){
            			ec.errorMsg("ERROR: SendEmail.Exception =>>",ex);
        		}           
        		        
        	}catch (SendFailedException e){   

			try{
				SendFailedException sfe=(SendFailedException)e.getCause();				

    				Address[] validUnsentAddresses1	= sfe.getValidUnsentAddresses();
    				Address[] invalidAddresses1	= sfe.getInvalidAddresses();

				String validUnsentAddresses	= validUnsentAddresses1[0].toString();
				String invalidAddresses		= invalidAddresses1[0].toString();


				if(!validUnsentAddresses.equals("")){
					printReport("validUnsentAddresses.txt", validUnsentAddresses);
				}

				else if(!invalidAddresses.equals("")){				
					printReport("invalidAddresses.txt", invalidAddresses);
				}
				else{
				ec.errorMsg("ERROR: SendEmail.send.unHandledAddress()", e);
				}				

            		}catch(Exception e2){ 
				ec.errorMsg("ERROR: SendEmail.send()", e2);
			}

		ec.errorMsg("ERROR: SendEmail.send()", e);
        	}//main catch block
        }



	private static void printReport(String fileName, String str)throws Exception{

		ErrorCheck ec = new ErrorCheck();
		try {
			File fileDir = new File(fileName); 
			Writer out = new BufferedWriter(new OutputStreamWriter(new FileOutputStream(fileDir), "UTF8")); 
			out.append(str).append("\r\n");		
			out.flush();
			out.close();

	    	}catch (UnsupportedEncodingException e){
			ec.errorMsg("ERROR: SendEmail.UnsupportedEncodingException =>",e);
	   	}catch (IOException e){
			ec.errorMsg("ERROR: SendEmail.IOException =>",e);
	    	}catch (Exception e){
			ec.errorMsg("ERROR: SendEmail.Exception =>",e);
	   	} 			
	}

I tested this code and found its overwriting to the file instead of adding new records

[Paul Clapham]

Farakh khan wrote:I tested this code and found its overwriting to the file instead of adding new records

Yes, that's what your printReport() method does. If you want it to append to the file instead of creating a new file every time, you should change it to do that. One of those classes you used (BufferedWriter, OutputStreamWriter, FileOutputStream) has a constructor which allows you to append, but I don't remember which one. Check the API documentation.

[Farakh khan]

I changed the method as following. Its working fine and appending records instead of overwriting

private static void printReport(String fileName, String str)throws Exception{

		ErrorCheck ec 			= new ErrorCheck();
		Path filePath 			= Paths.get("/var/Emails_log/"+fileName);
		File file 			= new File("/var/Emails_log/"+fileName);		
		final BufferedWriter out 	= Files.newBufferedWriter(filePath, StandardCharsets.UTF_8, StandardOpenOption.APPEND);
     
		try{ 
			if(!file.exists()){
        			file.createNewFile();
    			}

			out.write(str);
        		out.write('\n');   			

	    	}catch (Exception e){
			ec.errorMsg("ERROR: GSW.SendEmail.Exception =>",e);
	   	} 

		finally {

    			if (out != null) {
        			out.close();
				out.flush();
    			}
		}			
	}

but throws the following exception:

java.io.IOException: Stream closed
at java.io.BufferedWriter.ensureOpen(BufferedWriter.java:116)
at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:126)
at java.io.BufferedWriter.flush(BufferedWriter.java:253)
at SendEmail.printReport(SendEmail.java:134)
at SendEmail.send(SendEmail.java:79)
at promoClass.promoLoop(promoClass.java:67)
at pNews.doGet(pNews.java:219)<br>	at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:200)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:603)
at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)

[Paul Clapham]

Yeah. Why are you trying to flush the stream AFTER you close it?

[Farakh khan]

Thanks from the bottom of my heart. I am really learning everyday. Coderanch is my best and favorite forum

[Paul Clapham]

Glad you got all your issues sorted out. By the way I found it interesting that you found the Files.newBufferedWriter method... that's obviously superior to the old version which you originally used, in at least three ways. And not only that, I didn't know it existed. That's one of the things about Java, the language designers keep including useful features which greatly simplify the old ways of doing things, and it's hard to keep up with them.

[Farakh khan]

I am working in java since 1996 and still assuming I am learning. Its really a jest of computer science. In my era there was structure programming and OOP was looking very news and modern but now am seeing AOP (Aspect Oriented Programming). I love that java producers not only working to update their existing modules but always providing cutting edge new ideas as well.

[Farakh khan]

Today I ran this code on our production server and seen its writing only validSentAddresses.txt because either its sent or not then my code is writing "to" variable in the file that is email address that we don't know this will be sent or not.

Please advise how I modify my code to must throw sendFailException to write validSent, validUnsent and validNotSent emails