Combing Multiple String With No StringBuilder?

[John Sing]

Hi I am working on a variation of the "FizzBuzz" code where I have to replace all the multiples of 3 with the word "coza" all the multiples of 5 with the word "loza" and so on. I also have to output it to a message box. I was able to get my project to work through the normal output window but I am having trouble getting it through the message box. The only way I can think to do this is if I combine multiple strings into one string. I am not aloud to use StringBuilder so the only other method I know is using "+" symbols to combine separate strings in the output window. But when I try to do that I get some errors in my code. They say that all my variables can't be resolved to variables. How can I fix this? Here is my code

import javax.swing.JOptionPane;
public class CozaLozanewmethod
{
  public static void main(String[] args)
  {
    int a = 0;
    int b = 0;
    int c = 0;
    int d = 0;
    int e = 0;
    int f = 0;
    int g = 0;
 
   
    
    
    
   int result2=0;
    String n = JOptionPane.showInputDialog("Please input an interger");
     int result = Integer.parseInt(n);
     
    for (a=0; a <= result; a++){
     for ( b=0; b<result; b++){
        for ( c=0; c<result; c++){
           for ( d=0; d<result; d++){
        for ( e=0; e<result; e++){
        for ( f=0; f<result; f++){
        for ( g=0; g<result; g++){
       
 System.out.print(" ");
            ++result2;
        if (result2 % 11 == 0)
          System.out.println();
        
         if (a % 3 == 0 && a % 5 == 0 && a % 7 == 0) {    
           String A = ("CozaLozaWoza");
        
         }else if (b % 3 == 0 && b % 5 == 0) {
      String B =("CozaLoza");
        
      } else if (c % 5 == 0 && c % 7 == 0) {
          String C =("LozaWoza");
        
      } else if (d % 5 == 0) {
          String D =("Loza");
          
      } else if (e % 3 == 0) {
        String E =("Coza");
        
        } else if (f % 7 == 0) {
       String F =("Woza");
        
        
       
      
       
       
  }
}
       
    }
}
           }
        }
     }

    }
JOptionPane.showMessageDialog(null, A + B + C + D + E + F);
  }
 
}

[Jeanne Boyarsky]

What is the exact compiler error? It compiles on my machine.

Also, why do you have five nested loops? That feels wrong.

[Paweł Baczyński]

Also, you should indent your code better.
This fragment doesn't look well: } } } } } } } }

[Knute Snortum]

The answer is in here, but basically, put new line characters ("\n") between the strings.

[Carey Brown]

Why 7 nested loops? For a 'result' of 10, that would mean the inner logic would be executed 10 million times.

Your variables: A, B, C, ... are all defined with a block level scope and would therefore not be accessible outside of the block. Also, don't use leading upper-case letters for variable names.

Fix indentation.

[John Sing]

Carey Brown wrote:Why 7 nested loops? For a 'result' of 10, that would mean the inner logic would be executed 10 million times.

Your variables: A, B, C, ... are all defined with a block level scope and would therefore not be accessible outside of the block. Also, don't use leading upper-case letters for variable names.

Fix indentation.

Forgive me for asking so many questions but lets say I define the strings before the nested loops, then how do I make the message box display the string each time its supposed to? For example here is my code. where I define the strings before the loops.

import javax.swing.JOptionPane;
public class CozaLozanewmethod
{
  public static void main(String[] args)
  {
    int a = 0;
    int b = 0;
    int c = 0;
    int d = 0;
    int e = 0;
    int f = 0;
    int g = 0;
  String A = ("CozaLozaWoza");
  String B =("CozaLoza");
  String C =("LozaWoza");
  String D =("Loza");  
  String E =("Coza");
  String F =("Woza");
    
   int result2=0;
    String n = JOptionPane.showInputDialog("Please input an interger");
     int result = Integer.parseInt(n);
     
    for (a=0; a <= result; a++){
     for ( b=0; b<result; b++){
        for ( c=0; c><result; c++){
           for ( d=0; d><result; d++){
        for ( e=0; e><result; e++){
        for ( f=0; f><result; f++){
        for ( g=0; g><result; g++){
       
 System.out.print(" ");
            ++result2;
        if (result2 % 11 == 0)
          System.out.println();
        
         if (a % 3 == 0 && a % 5 == 0 && a % 7 == 0) {    
          
        
         }else if (b % 3 == 0 && b % 5 == 0) {
    
        
      } else if (c % 5 == 0 && c % 7 == 0) {
          
        
      } else if (d % 5 == 0) {
          
          
      } else if (e % 3 == 0) {
      
        
        } else if (f % 7 == 0) {
     
        
        
       
      
       
       
                     }
                  }
       
               } 
            }
         }
      }
    }

 }

  }
 JOptionPane.showMessageDialog(null, A + B + C + D + E + F);
}

I am not sure what I need to put after the "if then" statements so it knows to display the string at that time. Also the code I currently have wont even compile. I get the following errors on line 72

"Error: Syntax error on tokens, ConstructorHeaderName expected instead

Error: Syntax error on token "showMessageDialog", invalid AnnotationName

Error: Syntax error on token ",", ? expected"

So again please forgive me for asking so many questions but I am very confused right now.

]

[Carey Brown]

for ( d=0; d><result; d++){

Has a syntax error. No operator '><'.

[Carey Brown]

It's imperitive that you clean up your indentation. If you had you would have probably seen the error at the end.

import javax.swing.JOptionPane;

public class CozaLozanewmethod
{
	public static void main( String[] args )
	{
		int a = 0;
		int b = 0;
		int c = 0;
		int d = 0;
		int e = 0;
		int f = 0;
		int g = 0;
		String A = ( "CozaLozaWoza" );
		String B = ( "CozaLoza" );
		String C = ( "LozaWoza" );
		String D = ( "Loza" );
		String E = ( "Coza" );
		String F = ( "Woza" );

		int result2 = 0;
		String n = JOptionPane.showInputDialog( "Please input an interger" );
		int result = Integer.parseInt( n );

		for( a = 0 ; a <= result ; a++ )
		{
			for( b = 0 ; b < result ; b++ )
			{
				for( c = 0 ; c < result ; c++ )
				{
					for( d = 0 ; d < result ; d++ )
					{
						for( e = 0 ; e < result ; e++ )
						{
							for( f = 0 ; f < result ; f++ )
							{
								for( g = 0 ; g < result ; g++ )
								{

									System.out.print( " " );
									++result2;
									if( result2 % 11 == 0 )
										System.out.println();

									if( a % 3 == 0 && a % 5 == 0 && a % 7 == 0 )
									{

									}
									else if( b % 3 == 0 && b % 5 == 0 )
									{

									}
									else if( c % 5 == 0 && c % 7 == 0 )
									{

									}
									else if( d % 5 == 0 )
									{

									}
									else if( e % 3 == 0 )
									{

									}
									else if( f % 7 == 0 )
									{

									}
								}

							}
						}
					}
				}
			}
		}
	} // end of main() method
	
	// error - not contained in any method
	JOptionPane.showMessageDialog(null, A + B + C + D + E + F);
}

[Carey Brown]

else if( c % 3 == 0 && c % 7 == 0 )

Are you missing this case?

[Carey Brown]

Without StringBuilder you might try something like this (I left out a whole bunch of code but I hope you get the idea).

String s = "";
for( ... )
{
    // ...
    if( ... )
    {
         s += "Loza";
    }
    // ...
}

[Carey Brown]

I suggest temporarily outputting the strings using System.out.println() first, rather than working on concatenating your strings. You will find that you have some logic kinks to work out that would either cause your program to appear to hang or to blow up JOptionPane.

[Campbell Ritchie]

Carey Brown wrote: . . . Has a syntax error. No operator '><'.

Not necessarily. I have seen that before; I think there is a bug in the forum software which alters < to >< or alters > to ><. I think your correction to < throughout is correct.

[Winston Gutkowski]

John Sing wrote:Forgive me for asking so many questions

No problem. That's what we're here for.

but lets say I define the strings before the nested loops, then how do I make the message box display the string each time its supposed to?

I think the others have covered that, but what makes you think you need nested loops at all? I thought FizzBuzz was just a counting game.

But here's a tip: Instead of all those separate fields, what if you just had three? viz:

String[] strings = new String[]
   {"", "", "", "Coza", "", "Loza", "", "Woza"};

int result;

String resultString;  // To hold your "CozaLoza..." string
...

How do you think that might help you? And how would you write your program then?

[Edit] I should add that it's usually better to declare loop variables inside the loop, unless you have a very good reason not to (and you don't), viz:

  for(int a = 0 ; a <= result ; a++) { ...

and you certainly don't need 7 of them.

HIH

Winston

[Campbell Ritchie]

This is what you want. It tells you how to turn several Strings into a pretty‑print String. It also shows you how to do it with a Stream. All you need to do now is to work out which classes to import

[Winston Gutkowski]

Campbell Ritchie wrote:This is what you want. It tells you how to turn several Strings into a pretty‑print String...

Oddly enough I already wrote pretty much that exact same class. A Repeater one too, along the same lines. Trust Java to incorporate it two releases too late.

Winston

[Campbell Ritchie]

Winston Gutkowski wrote:. . . Trust Java to incorporate it two releases too late. . . .

Bad spelling there. The number should be spelt s‑e‑v‑e‑n

They are quite good at adding things which many people wrote for themselves years and years ago.