No Suitable Constructor Found

[Fred Schaefer]

I'm new to programming in Java and I'm trying to learn from online sources. I've come up with a error code that I'm not sure how to fix.

import java.io.BufferedReader;
import java.io.FileReader;
import java.util.*;
import javax.swing.*;

public class firstinitiallastnameReadPeople3 {
    public static void main(String [] args) throws Exception{

/*  This part of the program will bring up a window that will allow the user to select the file that
*   will be used to import the data.
*/
        JButton openFile = new JButton();
        JFileChooser chooseFile = new JFileChooser();
//  The next line provides the default location that the window will start from
        chooseFile.setCurrentDirectory(new java.io.File("C:\\users\\freddie\\documents"));
        chooseFile.setDialogTitle("Open File Location");
        chooseFile.setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES);
        if (chooseFile.showOpenDialog(openFile) == JFileChooser.APPROVE_OPTION);
        
        FileReader file = new FileReader(chooseFile.getSelectedFile().getAbsolutePath());
        BufferedReader reader = new BufferedReader(file);
        Scanner scan = new Scanner(reader);
        
        ArrayList<ListOfPeople> peopleArray = new ArrayList<ListOfPeople>();
        String inputs = null;
        
        while(scan.hasNextLine()){
            String line = scan.nextLine();
            String[] tempArray = line.split(",");
            peopleArray.add(new ListOfPeople(tempArray[0], tempArray[1], tempArray[2])); //this is the line of code that gives me the error
                    }
    }
public static class ListOfPeople {
    	private String fname, lname, fcolor, DOB;
            public ListOfPeople(String fname, String lname, String fcolor, String DOB) {
                super();
                this.fname = fname;
                this.lname = lname;
                this.fcolor = fcolor;
                this.DOB = DOB;
            }

        private ListOfPeople(String string) {
            throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
        }
            public String getFname() {
		return fname;
            }

            public void setFname(String fname) {
		this.fname = fname;
            }
            public String getLname(){
                return lname;
            }
            public void setLname(String lname){
                this.lname = lname;
            }
            public String getFcolor(){
                return fcolor;
            }
            public void setFcolor(String fcolor){
                this.fcolor = fcolor;
            }
            public String getDOB(){
                return DOB;
            }
            public void setDOB(String DOB){
                this.DOB = DOB;
            }
    }
}

I would appreciate any help on fixing this problem.

[Matthew Brown]

Hi Fred. Welcome to the Ranch!

So you're getting an error about a constructor. This is the only use of a constructor on that line:

new ListOfPeople(tempArray[0], tempArray[1], tempArray[2])

tempArray is a String[], so tempArray[0] (etc) is a String. That means that this is trying to use a constructor ListOfPeople(String, String, String).

So what constructors does ListOfPeople have? You've got a ListOfPeople(String) and ListOfPeople(String, String, String, String). Does either of those match the one you are trying to use?

[Fred Schaefer]

Thanks for the welcome Matthew.

I'm not sure where to put the constructor. I thought I had put the constructor in line 35. If I were to make everything public, would it change the need for a constructor?

[Matthew Brown]

Fred Sc wrote: I thought I had put the constructor in line 35.

Yes, you've added a constructor. It takes 4 arguments. You then tried to create use it using only three arguments.

Constructors aren't special in this respect - it would be the same with an ordinary method. If it expects 4 arguments then you need to call it with 4 arguments.

[Fred Schaefer]

Wow! I had only put in 3 constructors to make sure I was getting my syntax correct. What a simple fix to add one more!

I would assume the reverse would be true also? In line 35, if I had only put 2 constructors in, say String fname, String lname and no others; then I would still get an error in line 30 because it's looking for 3 constructors correct?

Thanks for helping me fix my little problem.

[Jesper de Jong]

Note the terminology: you don't have 3 constructors, you have one constructor, that takes 4 parameters: fname, lname, fcolor and DOB.

What was wrong is that you tried to use that constructor by passing 3 arguments. That won't work, because it needs 4, not 3 arguments. You need to specify values for all 4: fname, lname, fcolor and DOB.