ComboBox GUI

[Dale Herring]

I am having trouble with this GUI. I am trying to use a gridbaglayout for all the components in the center panel, although, I am not sure my understanding of gridbaglayout is the best. I can get this code to show a panel but nothing shows up on the panel. If anything is out of place or commented out it's all a part of me trying to debug and play with the code.

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.border.*;
import javax.swing.BorderFactory.*;

public class BaseballLine extends JFrame implements ActionListener
{
    JComboBox<String> one, two, three, four, five, six, seven, eight, nine;
    String[]pos = {"Pitcher", "Catcher", "First Base", "Second Base", "Third Base", "Short stop", "Left field", "Center Field", "Right Field"};
    JLabel tName;
    JTextField tNameBox, pNameOne, pNameTwo, pNameThree, pNameFour, pNameFive, pNameSix, pNameSeven, pNameEight, pNameNine;
    JRadioButton HB, VB;
    ButtonGroup bg;
    JButton ok, exit;
    Border teamInfo,loweredbevel;

    String teamName, pOne, pTwo, pThree, pFour, pFive, pSix, pSeven, pEight, pNine;//data for textfields
    String lOne, lTwo, lThree, lFour, lFive, lSix, lSeven, lEight, lNine;//data for combobox

    BaseballLine()
    {
		//new frame
		JFrame jfrm = new JFrame("Lineup");
        setLayout(new BorderLayout());

		setSize(1000, 1000);
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

        //center frame
		Toolkit tk = Toolkit.getDefaultToolkit();
		Dimension d = tk.getScreenSize();
		int width = 1000;
		int height = 1000;
		jfrm.setLocation((d.width - width)/2, (d.height - height)/2);

		//textboxes, labels, buttons
		one = new JComboBox<String>(pos);
		two = new JComboBox<String>(pos);
		three = new JComboBox<String>(pos);
		four = new JComboBox<String>(pos);
		five = new JComboBox<String>(pos);
		six = new JComboBox<String>(pos);
		seven = new JComboBox<String>(pos);
		eight = new JComboBox<String>(pos);
		nine = new JComboBox<String>(pos);

		tName = new JLabel("Team name: ");
		tNameBox = new JTextField(10);
		pNameOne = new JTextField(10);
		pNameTwo = new JTextField(10);
		pNameThree = new JTextField(10);
		pNameFour = new JTextField(10);
		pNameFive = new JTextField(10);
		pNameSix = new JTextField(10);
		pNameSeven = new JTextField(10);
		pNameEight = new JTextField(10);
		pNameNine = new JTextField(10);

		HB = new JRadioButton("Home");
		VB = new JRadioButton("Visitor");

		ok = new JButton("OK");
		exit = new JButton("Exit");

		//add listeners
		one.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent ae)
			{
				lOne = (String) one.getSelectedItem();
				System.out.println(" " + lOne);
				}
				});

		two.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent be)
			{
				lTwo = (String) two.getSelectedItem();
				System.out.println(" " + lTwo);
				}
			});

		three.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent ce)
			{
				lThree = (String) three.getSelectedItem();
				System.out.println(" " + lThree);
					}
			});

		four.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent de)
			{
				lFour = (String) four.getSelectedItem();
				System.out.println(" " + lFour);
				}
			});

		five.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent ee)
			{

				lFive = (String) five.getSelectedItem();
				System.out.println(" " + lFive);
				}
			});

		six.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent fe)
			{

				lSix = (String) six.getSelectedItem();
				System.out.println(" " + lSix);
				}//end if
			});

		seven.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent ge)
			{

				lSeven = (String) seven.getSelectedItem();
				System.out.println(" " + lSeven);
				}
			});

		eight.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent he)
			{
				lEight = (String) eight.getSelectedItem();
				System.out.println(" " + lEight);
				}
			});
		nine.addActionListener(new ActionListener()
		{
			public void actionPerformed(ActionEvent ie)
			{
				lNine = (String) nine.getSelectedItem();
				System.out.println(" " + lNine);
				}
			});

		HB.addActionListener(this);
		VB.addActionListener(this);
		ok.addActionListener(this);
		exit.addActionListener(this);

		//create north panel
		JPanel pNorth = new JPanel();
		pNorth.setLayout(new FlowLayout());
		loweredbevel = BorderFactory.createLoweredBevelBorder();
		teamInfo = BorderFactory.createTitledBorder(loweredbevel, "Team Information");
		pNorth.setBorder(teamInfo);

        //add components to north panel
		pNorth.add(tName);
		pNorth.add(tNameBox);
		pNorth.add(HB);
		pNorth.add(VB);
		bg = new ButtonGroup();
		bg.add(HB);
		bg.add(VB);

		//create main panel
		JPanel pCenter = new JPanel();
		pCenter.setLayout(new GridBagLayout());
		GridBagConstraints c = new GridBagConstraints();

		//add components to center panel

		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = 0;
		pCenter.add(pNameOne, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = 0;
		pCenter.add(one, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -1;
		pCenter.add(pNameTwo, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -1;
		pCenter.add(two, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -2;
		pCenter.add(pNameThree, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -2;
		pCenter.add(three, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -3;
		pCenter.add(pNameFour, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -3;
		pCenter.add(four, c);
		//c.fill = GridBagConstraints.RELATIVE;
	    c.gridx = 0;
		c.gridy = -4;
		pCenter.add(pNameFive, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -4;
		pCenter.add(five, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -5;
		pCenter.add(pNameSix, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -5;
		pCenter.add(six, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -6;
		pCenter.add(pNameSeven, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -6;
		pCenter.add(seven, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -7;
		pCenter.add(pNameEight, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -7;
		pCenter.add(eight, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -8;
		pCenter.add(pNameNine, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -8;
		pCenter.add(nine, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 0;
		c.gridy = -9;
		pCenter.add(ok, c);
		//c.fill = GridBagConstraints.RELATIVE;
		c.gridx = 1;
		c.gridy = -9;
		pCenter.add(exit, c);

		jfrm.add("North", pNorth);
		jfrm.add(pCenter);

	}//end construct

		//action performed
		public void actionPerformed(ActionEvent je)
		{
			Object source = je.getSource(); //source object

			if(source == exit)
			{
				System.exit(0);
			}

			if(source == ok)
			{
				teamName = tNameBox.getText();
				if(teamName != null)
				{
					System.out.print(teamName);
				}

			if(je.getActionCommand() == "Home")
			{
				System.out.println("(home team)");
			}
			if(je.getActionCommand() == "Visitor")
			{
				System.out.println("(visiting team)");
			}

			pOne = pNameOne.getText();
			if(pOne != null)
			{
				System.out.print(pOne + ",");
			}

			pTwo = pNameTwo.getText();
			if(pTwo != null)
			{
				System.out.print(pTwo + ",");
			}

			pThree = pNameThree.getText();
			if(pThree != null)
			{
				System.out.print(pThree + ",");
			}

			pFour = pNameFour.getText();
			if(pFour != null)
			{
				System.out.print(pFour + ",");
			}

			pFive = pNameFive.getText();
			if(pFive != null)
			{
				System.out.print(pFive + ",");
			}

			pSix = pNameSix.getText();
			if(pSix != null)
			{
				System.out.print(pSix + ",");
			}

			pSeven = pNameSeven.getText();
			if(pSeven != null)
			{
				System.out.print(pSeven + ",");
			}

			pEight = pNameEight.getText();
			if(pEight != null)
			{
				System.out.print(pEight + ",");
			}

			pNine = pNameNine.getText();
			if(pNine != null)
			{
				System.out.print(pNine + ",");
			}

		}// end if
	}//end actionperformed


public static void main(String[]args)
{
	BaseballLine bl = new BaseballLine();
	bl.setVisible(true);
}//end main
}//end class

[Peter Muster]

Your class BaseballLine extends JFrame yet you create a separate JFrame "jfrm" inside your class and add every GUI component to it. In the end though you invoke setVisible() on your BaseballLine instance and not on jfrm which has all the components added to it. For a start you could remove your declaration of "jfrm" and replace all occurrences of it with "this". That should solve your problem. I would also consider refactoring your code. You have a lot of copy paste elements which makes it hard to read and hard to enhance later on.

[Dave Tolls]

I would go the other way and not have your BaseballLine class extend JFrame. There's normally no need to extend JFrame as you are not actually extending the functionality of the class, just adding things to it. Extending it is a bit like extending ArrayList simply to populate it with entries.

Just use the jfrm instance, and display that. You might want to make it an instance variable of the BaseballLine class rather than a local variable, though that may not be necessary.

[Dale Herring]

Yea thanks, I didn't realize I was instantiating the JFrame again and that's what was screwing me. I've got a few other issues to clean up with my actionlisteners and layouts but you really helped me out.