JFreeChart Not Plotting Lines

[Dennis Putnam]

Since there seems to be no debugging tools for JFreeChart (1.0.19), I've managed to produce an SSCCE that exhibits the problem. Everything looks right to me but no lines are being drawn and the legend is missing, which I suspect is related. I'm hoping some new eyes can spot what I am missing. Here is the Chart class:

package stokerMonitor;

import java.awt.BasicStroke;
import java.awt.BorderLayout;
import java.awt.Color;
import java.awt.Container;
import java.awt.Dimension;
import java.awt.Toolkit;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.LinkedHashMap;

import javax.swing.JPanel;

import org.jfree.chart.ChartFactory;
import org.jfree.chart.ChartPanel;
import org.jfree.chart.JFreeChart;
import org.jfree.chart.annotations.XYTextAnnotation;
import org.jfree.chart.axis.DateAxis;
import org.jfree.chart.axis.NumberAxis;
import org.jfree.chart.axis.NumberTickUnit;
import org.jfree.chart.plot.ValueMarker;
import org.jfree.chart.plot.XYPlot;
import org.jfree.chart.renderer.xy.XYLineAndShapeRenderer;
import org.jfree.data.general.SeriesException;
import org.jfree.data.time.Minute;
import org.jfree.data.time.RegularTimePeriod;
import org.jfree.data.time.TimeSeries;
import org.jfree.data.time.TimeSeriesCollection;
import org.jfree.data.time.TimeSeriesDataItem;
import org.jfree.ui.TextAnchor;

public class TestChart extends JPanel {
	
	private static final long serialVersionUID = 1L;
	
	private TimeSeriesCollection pitTemps=new TimeSeriesCollection();
	private TimeSeriesCollection probeTemps=new TimeSeriesCollection();
	private LinkedHashMap<String,TimeSeries> pitTimeSeries=new LinkedHashMap<String,TimeSeries>();
	private LinkedHashMap<String,TimeSeries> probeTimeSeries=new LinkedHashMap<String,TimeSeries>();
	public DateFormat formatter=null;
	private XYPlot chart=null;
	private static TestChart instance=null;
	
	private TestChart(Container pane_) {
		// Prevent instantiation
		chart(pane_);
	}
	
	public static TestChart getInstance(Container pane_) {
		if (instance==null) {
			instance=new TestChart(pane_);
		}
		return(instance);
	}
	
	public static TestChart getInstance() {
		return(instance);
	}

	private void chart(Container pane) {

		Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
		int width = (int) screenSize.getWidth();
		int height=(int) screenSize.getHeight();
		height*=.75;
		formatter=new SimpleDateFormat("HH:mm");
		String scale="F";
		if (Configuration.getInstance().celsius) {
			scale="C";
		}
		XYLineAndShapeRenderer r1 = new XYLineAndShapeRenderer();
		r1.setSeriesPaint(0, Color.RED); 
		r1.setSeriesPaint(1, Color.ORANGE); 
		r1.setSeriesShapesVisible(0,  false);
		r1.setSeriesShapesVisible(1,  false);

		XYLineAndShapeRenderer r2 = new XYLineAndShapeRenderer();
		r2.setSeriesPaint(0,Color.BLUE); 
		r2.setSeriesPaint(1,Color.GREEN);
		r2.setSeriesPaint(2,Color.BLACK);
		r2.setSeriesPaint(3,Color.GRAY);
		r2.setSeriesShapesVisible(0,  false);
		r2.setSeriesShapesVisible(1,  false);
		JFreeChart freeChart = ChartFactory.createTimeSeriesChart("Pit & Probe Temperatures","Time of Day",  "Pit Temperature (\u00B0 "+scale+")",getPitDataset(), true, false, false);
		chart=(XYPlot) freeChart.getPlot();
		chart.setRenderer(0,r1);
		chart.setRenderer(1,r2);
		NumberAxis pitRange=(NumberAxis) chart.getRangeAxis();
		NumberAxis probeRange=(NumberAxis) new NumberAxis("Probe Temperature (\u00B0 "+scale+")");
		if (Configuration.getInstance().celsius) {
			pitRange.setRange(35,205);
			probeRange.setRange(10,125);
		}
		else {
			pitRange.setRange(100,400);
			probeRange.setRange(50,250);
		}
		pitRange.setTickUnit(new NumberTickUnit(10));
		probeRange.setTickUnit(new NumberTickUnit(10));
		DateAxis dateAxis=(DateAxis) chart.getDomainAxis();
		dateAxis.setDateFormatOverride(formatter);
		chart.setDomainAxis(dateAxis);
		chart.setRangeAxis(1,probeRange);
		chart.setDataset(1,getProbeDataset());
		chart.mapDatasetToRangeAxis(1,1);
		ChartPanel chartPanel = new ChartPanel(freeChart);
		chartPanel.setPreferredSize(new Dimension((int)width,height));
		pane.add(chartPanel,BorderLayout.PAGE_END);
	}
	
	public void initializeProbe(String name_,String id_,boolean blower) {
		TimeSeries ts=new TimeSeries(name_);
		if (blower) {
			pitTimeSeries.put(id_,ts);
		}
		else {
			probeTimeSeries.put(id_,ts);
		}
	}
	
	private TimeSeriesCollection getPitDataset() {
		for (String entry : pitTimeSeries.keySet()) {
			pitTemps.addSeries(pitTimeSeries.get(entry));
		}
		return(pitTemps);
	}
	
	private TimeSeriesCollection getProbeDataset() {
		for (String entry : probeTimeSeries.keySet()) {
			probeTemps.addSeries(probeTimeSeries.get(entry));
		}
		return(probeTemps);
	}
	
	public void addPitTemps(String id_,double temp_,boolean blower_) {
		RegularTimePeriod tm=new Minute(new Date());
		TimeSeriesDataItem t=new TimeSeriesDataItem(tm,temp_);
		try {
			if (blower_) {
				TimeSeries timeLine=pitTimeSeries.get(id_);
				timeLine.add(t);
				chart.setDataset(0,pitTemps);
			}
			else {
				TimeSeries timeLine=probeTimeSeries.get(id_);
				timeLine.add(t);
				chart.setDataset(1,probeTemps);
			}
		}
		catch (NullPointerException | SeriesException e) {
			e.printStackTrace();
		}
		
	}
	
	public void addMarker(String id_,String name_) {
		Long tod=new Date().getTime();
		ValueMarker marker=new ValueMarker(tod);
		XYTextAnnotation label=new XYTextAnnotation("Door Open: "+name_,tod-10,10);
		label.setRotationAnchor(TextAnchor.BASELINE_CENTER);
		label.setTextAnchor(TextAnchor.BASELINE_CENTER);
		label.setRotationAngle(-Math.PI/2);
		label.setPaint(Color.BLACK);
		marker.setStroke(new BasicStroke(2));
		marker.setPaint(Color.BLACK);
		chart.addDomainMarker(marker);
		chart.addAnnotation(label);
	}
}

Here is main:

package stokerMonitor;

import java.awt.Dimension;
import java.awt.Toolkit;

import javax.swing.JFrame;

public class Test {

	public static void main(String[] args) throws InterruptedException {
		
		JFrame frame=new JFrame();
		frame.setTitle("Test");
		Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
		int width = (int) screenSize.getWidth();
		int height = (int) screenSize.getHeight();
		frame.setBounds(0, 0,width, height);
		TestChart.getInstance(frame);
		frame.setVisible(true);
		TestChart.getInstance().initializeProbe("Blower Probe","blower",true);
		TestChart.getInstance().initializeProbe("Monitor Probe","monitor",false);
		TestChart.getInstance().addPitTemps("blower",200.,true);
		TestChart.getInstance().addPitTemps("monitor",100.,false);
		Thread.sleep(60000);
		TestChart.getInstance().addPitTemps("blower",250.,true);
		TestChart.getInstance().addPitTemps("monitor",150.,false);
		Thread.sleep(60000);
		TestChart.getInstance().addPitTemps("blower",300.,true);
		TestChart.getInstance().addPitTemps("monitor",200.,false);
		Thread.sleep(60000);
		frame.dispose();
	}

}

As an aside, note the time of 19:00 in the lower left. I have no idea where that comes from either. Again that might be a clue. TIA.

[Dennis Putnam]

Apologies. I did not comment out some irrelevant external references in the chart class. This should work better.

package stokerMonitor;

import java.awt.BasicStroke;
import java.awt.BorderLayout;
import java.awt.Color;
import java.awt.Container;
import java.awt.Dimension;
import java.awt.Toolkit;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.LinkedHashMap;

import javax.swing.JPanel;

import org.jfree.chart.ChartFactory;
import org.jfree.chart.ChartPanel;
import org.jfree.chart.JFreeChart;
import org.jfree.chart.annotations.XYTextAnnotation;
import org.jfree.chart.axis.DateAxis;
import org.jfree.chart.axis.NumberAxis;
import org.jfree.chart.axis.NumberTickUnit;
import org.jfree.chart.plot.ValueMarker;
import org.jfree.chart.plot.XYPlot;
import org.jfree.chart.renderer.xy.XYLineAndShapeRenderer;
import org.jfree.data.general.SeriesException;
import org.jfree.data.time.Minute;
import org.jfree.data.time.RegularTimePeriod;
import org.jfree.data.time.TimeSeries;
import org.jfree.data.time.TimeSeriesCollection;
import org.jfree.data.time.TimeSeriesDataItem;
import org.jfree.ui.TextAnchor;

public class TestChart extends JPanel {
	
	private static final long serialVersionUID = 1L;
	
	private TimeSeriesCollection pitTemps=new TimeSeriesCollection();
	private TimeSeriesCollection probeTemps=new TimeSeriesCollection();
	private LinkedHashMap<String,TimeSeries> pitTimeSeries=new LinkedHashMap<String,TimeSeries>();
	private LinkedHashMap<String,TimeSeries> probeTimeSeries=new LinkedHashMap<String,TimeSeries>();
	public DateFormat formatter=null;
	private XYPlot chart=null;
	private static TestChart instance=null;
	
	private TestChart(Container pane_) {
		// Prevent instantiation
		chart(pane_);
	}
	
	public static TestChart getInstance(Container pane_) {
		if (instance==null) {
			instance=new TestChart(pane_);
		}
		return(instance);
	}
	
	public static TestChart getInstance() {
		return(instance);
	}

	private void chart(Container pane) {

		Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
		int width = (int) screenSize.getWidth();
		int height=(int) screenSize.getHeight();
		height*=.75;
		formatter=new SimpleDateFormat("HH:mm");
		String scale="F";
//		if (Configuration.getInstance().celsius) {
//			scale="C";
//		}
		XYLineAndShapeRenderer r1 = new XYLineAndShapeRenderer();
		r1.setSeriesPaint(0, Color.RED); 
		r1.setSeriesPaint(1, Color.ORANGE); 
		r1.setSeriesShapesVisible(0,  false);
		r1.setSeriesShapesVisible(1,  false);

		XYLineAndShapeRenderer r2 = new XYLineAndShapeRenderer();
		r2.setSeriesPaint(0,Color.BLUE); 
		r2.setSeriesPaint(1,Color.GREEN);
		r2.setSeriesPaint(2,Color.BLACK);
		r2.setSeriesPaint(3,Color.GRAY);
		r2.setSeriesShapesVisible(0,  false);
		r2.setSeriesShapesVisible(1,  false);
		JFreeChart freeChart = ChartFactory.createTimeSeriesChart("Pit & Probe Temperatures","Time of Day",  "Pit Temperature (\u00B0 "+scale+")",getPitDataset(), false, false, false);
		chart=(XYPlot) freeChart.getPlot();
		chart.setRenderer(0,r1);
		chart.setRenderer(1,r2);
		NumberAxis pitRange=(NumberAxis) chart.getRangeAxis();
		NumberAxis probeRange=(NumberAxis) new NumberAxis("Probe Temperature (\u00B0 "+scale+")");
		pitRange.setRange(100,400);
		probeRange.setRange(50,250);
//		if (Configuration.getInstance().celsius) {
//			pitRange.setRange(35,205);
//			probeRange.setRange(10,125);
//		}
		pitRange.setTickUnit(new NumberTickUnit(10));
		probeRange.setTickUnit(new NumberTickUnit(10));
		DateAxis dateAxis=(DateAxis) chart.getDomainAxis();
		dateAxis.setDateFormatOverride(formatter);
		chart.setDomainAxis(dateAxis);
		chart.setRangeAxis(1,probeRange);
		chart.setDataset(1,getProbeDataset());
		chart.mapDatasetToRangeAxis(1,1);
		ChartPanel chartPanel = new ChartPanel(freeChart);
		chartPanel.setPreferredSize(new Dimension((int)width,height));
		pane.add(chartPanel,BorderLayout.PAGE_END);
	}
	
	public void initializeProbe(String name_,String id_,boolean blower) {
		TimeSeries ts=new TimeSeries(name_);
		if (blower) {
			pitTimeSeries.put(id_,ts);
		}
		else {
			probeTimeSeries.put(id_,ts);
		}
	}
	
	private TimeSeriesCollection getPitDataset() {
		for (String entry : pitTimeSeries.keySet()) {
			pitTemps.addSeries(pitTimeSeries.get(entry));
		}
		return(pitTemps);
	}
	
	private TimeSeriesCollection getProbeDataset() {
		for (String entry : probeTimeSeries.keySet()) {
			probeTemps.addSeries(probeTimeSeries.get(entry));
		}
		return(probeTemps);
	}
	
	public void addPitTemps(String id_,double temp_,boolean blower_) {
		RegularTimePeriod tm=new Minute(new Date());
		TimeSeriesDataItem t=new TimeSeriesDataItem(tm,temp_);
		try {
			if (blower_) {
				TimeSeries timeLine=pitTimeSeries.get(id_);
				timeLine.add(t);
				chart.setDataset(0,pitTemps);
			}
			else {
				TimeSeries timeLine=probeTimeSeries.get(id_);
				timeLine.add(t);
				chart.setDataset(1,probeTemps);
			}
		}
		catch (NullPointerException | SeriesException e) {
			e.printStackTrace();
		}
		
	}
	
	public void addMarker(String id_,String name_) {
		Long tod=new Date().getTime();
		ValueMarker marker=new ValueMarker(tod);
		XYTextAnnotation label=new XYTextAnnotation("Door Open: "+name_,tod-10,10);
		label.setRotationAnchor(TextAnchor.BASELINE_CENTER);
		label.setTextAnchor(TextAnchor.BASELINE_CENTER);
		label.setRotationAngle(-Math.PI/2);
		label.setPaint(Color.BLACK);
		marker.setStroke(new BasicStroke(2));
		marker.setPaint(Color.BLACK);
		chart.addDomainMarker(marker);
		chart.addAnnotation(label);
	}
}

[Darryl Burke]

Dennis Putnam wrote:As an aside, note the time of 19:00 in the lower left. I have no idea where that comes from either.

You're in UTC-5 time zone, are you?

[Dennis Putnam]

Correct. I am guessing that you see a different time there because you are in a different time zone. Do you know where that comes from and if is it another symptom of my problem?

[Darryl Burke]

Looks to me like a time defaulting to 00:00 UTC.

As earlier said, I don't use JFreeChart but I ran your code with some modifications (Threda#sleep raises a red flag in a GUI program, changd that part to use a Swing Timer, and also created the JFrame etc. on the EDT).

You see, that's not really an SSCCE.  For one, you have a method addMarker(String id_,String name_) that's not used.  To create a SSCCE, it's always better to start afresh and add only as much code as is necessary to show the problem.  That makes it (much) easier for someone to be able to help you.

It could be that data points are being added to the LinkedHashMap after the series has been created with zero entries, but I haven't looked to see what the JFreeChart javadocs say about that.

[Dennis Putnam]

Thanks. The addMarker method is irrlevent and can be removed since it is not used in this context. I didn't have a problem with the sleep and I didn't know any other way of spacing the datapoints out so they are at least 1 minute apart (produces a duplicate entry error). From what I read adding datapoints automatically triggers a repaint and is valid. Indeed, I have seen examples of real time plots.

package stokerMonitor;

import java.awt.BasicStroke;
import java.awt.BorderLayout;
import java.awt.Color;
import java.awt.Container;
import java.awt.Dimension;
import java.awt.Toolkit;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.LinkedHashMap;

import javax.swing.JPanel;

import org.jfree.chart.ChartFactory;
import org.jfree.chart.ChartPanel;
import org.jfree.chart.JFreeChart;
import org.jfree.chart.axis.DateAxis;
import org.jfree.chart.axis.NumberAxis;
import org.jfree.chart.axis.NumberTickUnit;
import org.jfree.chart.plot.XYPlot;
import org.jfree.chart.renderer.xy.XYLineAndShapeRenderer;
import org.jfree.data.general.SeriesException;
import org.jfree.data.time.Minute;
import org.jfree.data.time.RegularTimePeriod;
import org.jfree.data.time.TimeSeries;
import org.jfree.data.time.TimeSeriesCollection;
import org.jfree.data.time.TimeSeriesDataItem;

public class TestChart extends JPanel {
	
	private static final long serialVersionUID = 1L;
	
	private TimeSeriesCollection pitTemps=new TimeSeriesCollection();
	private TimeSeriesCollection probeTemps=new TimeSeriesCollection();
	private LinkedHashMap<String,TimeSeries> pitTimeSeries=new LinkedHashMap<String,TimeSeries>();
	private LinkedHashMap<String,TimeSeries> probeTimeSeries=new LinkedHashMap<String,TimeSeries>();
	public DateFormat formatter=null;
	private XYPlot chart=null;
	private static TestChart instance=null;
	
	private TestChart(Container pane_) {
		// Prevent instantiation
		chart(pane_);
	}
	
	public static TestChart getInstance(Container pane_) {
		if (instance==null) {
			instance=new TestChart(pane_);
		}
		return(instance);
	}
	
	public static TestChart getInstance() {
		return(instance);
	}

	private void chart(Container pane) {

		Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
		int width = (int) screenSize.getWidth();
		int height=(int) screenSize.getHeight();
		height*=.75;
		formatter=new SimpleDateFormat("HH:mm");
		String scale="F";
//		if (Configuration.getInstance().celsius) {
//			scale="C";
//		}
		XYLineAndShapeRenderer r1 = new XYLineAndShapeRenderer();
		r1.setSeriesPaint(0, Color.RED); 
		r1.setSeriesPaint(1, Color.ORANGE); 
		r1.setSeriesShapesVisible(0,  false);
		r1.setSeriesShapesVisible(1,  false);

		XYLineAndShapeRenderer r2 = new XYLineAndShapeRenderer();
		r2.setSeriesPaint(0,Color.BLUE); 
		r2.setSeriesPaint(1,Color.GREEN);
		r2.setSeriesPaint(2,Color.BLACK);
		r2.setSeriesPaint(3,Color.GRAY);
		r2.setSeriesShapesVisible(0,  false);
		r2.setSeriesShapesVisible(1,  false);
		JFreeChart freeChart = ChartFactory.createTimeSeriesChart("Pit & Probe Temperatures","Time of Day",  "Pit Temperature (\u00B0 "+scale+")",getPitDataset(), false, false, false);
		chart=(XYPlot) freeChart.getPlot();
		chart.setRenderer(0,r1);
		chart.setRenderer(1,r2);
		NumberAxis pitRange=(NumberAxis) chart.getRangeAxis();
		NumberAxis probeRange=(NumberAxis) new NumberAxis("Probe Temperature (\u00B0 "+scale+")");
		pitRange.setRange(100,400);
		probeRange.setRange(50,250);
//		if (Configuration.getInstance().celsius) {
//			pitRange.setRange(35,205);
//			probeRange.setRange(10,125);
//		}
		pitRange.setTickUnit(new NumberTickUnit(10));
		probeRange.setTickUnit(new NumberTickUnit(10));
		DateAxis dateAxis=(DateAxis) chart.getDomainAxis();
		dateAxis.setDateFormatOverride(formatter);
		chart.setDomainAxis(dateAxis);
		chart.setRangeAxis(1,probeRange);
		chart.setDataset(1,getProbeDataset());
		chart.mapDatasetToRangeAxis(1,1);
		ChartPanel chartPanel = new ChartPanel(freeChart);
		chartPanel.setPreferredSize(new Dimension((int)width,height));
		pane.add(chartPanel,BorderLayout.PAGE_END);
	}
	
	public void initializeProbe(String name_,String id_,boolean blower) {
		TimeSeries ts=new TimeSeries(name_);
		if (blower) {
			pitTimeSeries.put(id_,ts);
		}
		else {
			probeTimeSeries.put(id_,ts);
		}
	}
	
	private TimeSeriesCollection getPitDataset() {
		for (String entry : pitTimeSeries.keySet()) {
			pitTemps.addSeries(pitTimeSeries.get(entry));
		}
		return(pitTemps);
	}
	
	private TimeSeriesCollection getProbeDataset() {
		for (String entry : probeTimeSeries.keySet()) {
			probeTemps.addSeries(probeTimeSeries.get(entry));
		}
		return(probeTemps);
	}
	
	public void addPitTemps(String id_,double temp_,boolean blower_) {
		RegularTimePeriod tm=new Minute(new Date());
		TimeSeriesDataItem t=new TimeSeriesDataItem(tm,temp_);
		try {
			if (blower_) {
				TimeSeries timeLine=pitTimeSeries.get(id_);
				timeLine.add(t);
				chart.setDataset(0,pitTemps);
			}
			else {
				TimeSeries timeLine=probeTimeSeries.get(id_);
				timeLine.add(t);
				chart.setDataset(1,probeTemps);
			}
		}
		catch (NullPointerException | SeriesException e) {
			e.printStackTrace();
		}
		
	}

}

[Darryl Burke]

Lines 139 & 144 in the lates posted code: you need getPitDataset() & getProbeDataset() instead of pitTemps & probeTemps.

[Dennis Putnam]

How dumb is that? I knew new eyes would help, I never would have spotted that myself. Thanks, I owe you one.

[Dennis Putnam]

Oops. I spoke too soon. That is not right. Each call to those methods, creates a new timeseries. I need to just update the existing ones.