Java Config same annotation bean in multiple config classes

[Rj Ewing]

I am trying to switch to java config from xml.

We have a core library, and then implementations that use the core library. We also have webapp and cli in each implementation. I am trying to modularize the config. We do use component scanning for certain packages. I am running into a circular dependency issue in the config classes. I need to inject the same @Component into beans created in multiple java config classes. My configs are as follows:

@Configuration
@ComponentScan(basePackages = {"my.components"})
@ImportResource({
        "classpath:data-access-config.xml"
})
@PropertySource(value = "classpath:core.props", ignoreResourceNotFound = true)
public class CoreAppConfig {
    @Autowired
    Environment env;

    @Autowired
    ComponentBean bean;

   @Bean
  public MyBean myBean() {
     return new MyBean(bean);
  }
}

@Configuration
@Import({CoreAppConfig.class})
@PropertySource(value = "classpath:my-app.props")
public class MyAppConfig {
    @Autowired
    Environment env;

    @Autowired
    ComponentBean bean;

   @Bean
  public MyBean2 myBean2() {
     return new MyBean2(bean);
  }
}

@Configuration
@ComponentScan(basePackages = {"my.app.services"})
@Import({MyAppConfig.class, CoreAppConfig.class})
public class MyWebAppConfig {
    @Autowired
    Environment env;

    @Autowired
    MyAppConfig myAppConfig;

    @Autowired
    ComponentBean bean;

   @Bean
  public MyRestService myRestService() {
     return new MyRestService(bean);
  }
}

What would be the best way to solve this?

1 option would be to not use component scanning. Others?

[Rj Ewing]

Sorry, this is in the wrong forum. Can someone please move this to the Spring forum?

[Rj Ewing]

So after a bit more digging, this has to do with me trying to override a bean in the java config.

@Configuration
@ComponentScan(basePackages = {"my.components"})
@ImportResource({
        "classpath:data-access-config.xml"
})
@PropertySource(value = "classpath:core.props", ignoreResourceNotFound = true)
public class CoreAppConfig {
    @Autowired
    Environment env;
 
    @Autowired
    ComponentBean bean;
 
   @Bean
   public SettingsBean settingsBean() {
      return new SettingsBean("path/to/core.props");
   }

   @Bean
  public MyBean myBean() {
     return new MyBean(bean, settingsBean());  // should use MyAppConfig.settingsBean() if present, otherwise this.settingsBean()
  }
}

@Configuration
@Import({CoreAppConfig.class})
@PropertySource(value = "classpath:my-app.props")
public class MyAppConfig {
    @Autowired
    Environment env;
 
    @Autowired
    ComponentBean bean;
 

   // I want this bean to override the previous SettingsBean()
   @Bean
   public SettingsBean settingsBean() {
      return new SettingsBean("path/to/my-app.props");
   }

   @Bean
  public MyBean2 myBean2() {
     return new MyBean2(bean);
  }
}

I am trying to override the SettingsBean, however CoreAppConfig uses SettingsBean to create MyBean. I think this is why I am getting a BeanCurrentlyInCreationException error. Any ideas how to resolve this?

[Ankit Garg]

You can't override beans like that. Ideally you should make the parameter to SettingsBean dynamic like ${PROD_NAME} or something similar. You can then specify this value using environment variable...

[Rj Ewing]

okay, I ended up putting the SettingsBean in a separate config, then using @PropertySource(), i retrieve the param for SettingsBean