two rectangle objects intersecting even when they are not

[Patty Lebowski]

I'm having an issue where I always get two rectangle objects intersecting even when they are not. I'm lost in my own code.

public class Tracking extends JFrame {
	static float lastY = 0;
	static float lastX = 0;
	
	static boolean lock = false;
	static ArrayList<Float> coordsX = new ArrayList<Float>();
	static ArrayList<Float> coordsY = new ArrayList<Float>();
	static ArrayList<Float> secondClickcoordsX = new ArrayList<Float>();
	static ArrayList<Float> secondClickcoordsY = new ArrayList<Float>();
	
	static ArrayList<Float> comparecoordsX = new ArrayList<Float>();
	static ArrayList<Float> comparecoordsY = new ArrayList<Float>();
	static ArrayList<Float> comparesecondClickcoordsX = new ArrayList<Float>();
	static ArrayList<Float> comparesecondClickcoordsY = new ArrayList<Float>();

	//compare the first click in the password to the first click the user enters
	 public static boolean compareList(ArrayList<Float> coordsX,ArrayList<Float> comparecoordsX){
	        return coordsX.toString().contentEquals(comparecoordsX.toString())?true:false;
	    }
	 public static boolean compareList1(ArrayList<Float> coordsY,ArrayList<Float> comparecoordsY){
	        return coordsY.toString().contentEquals(comparecoordsY.toString())?true:false;
	    }
	 //compares the second let go click in the password to the second click the user enters
	 public static boolean compareList2(ArrayList<Float> secondClickcoordsX,ArrayList<Float> comparesecondClickcoordsX){
	        return secondClickcoordsX.toString().contentEquals(comparesecondClickcoordsY.toString())?true:false;
	    }
	 public static boolean compareList3(ArrayList<Float> secondClickcoordsY,ArrayList<Float> comparesecondClickcoordsY){
	        return secondClickcoordsY.toString().contentEquals(comparesecondClickcoordsY.toString())?true:false;
	    }
	 

	public static void main(String[] args) {

		boolean isPressed = false;
	
		SwingUtilities.invokeLater(new Runnable() {
			public void run() {
				
				JFrame frame = new JFrame("Lock");
				JButton button = new JButton();

				button.setText("Instructions for setting a lock");
				frame.add(button);
				frame.pack();
				frame.setVisible(true);    
				button.addActionListener(new java.awt.event.ActionListener() {
					@Override
					public void actionPerformed(java.awt.event.ActionEvent evt) {
						JOptionPane.showMessageDialog(frame, "Please create a lock by clicking the mouse"
								+ " \nover the picture in four different areas", null, EXIT_ON_CLOSE);
					}
				});

				frame.add(new JLabel(new ImageIcon("C://Users//pcase//Desktop//background.jpg")));
				frame.setSize(600, 600);
				frame.setVisible(true);
				frame.addMouseListener(new MouseListener() {
					
				public void mouseReleased(MouseEvent e) {}

				
				
				
				
				public void mousePressed(MouseEvent e) {
					int r = 30; 
					int x = e.getX() - r/2; 
					int y = e.getY()-r/2; 
					Rectangle2D.Double ellipse = new Rectangle2D.Double(x,y,r,r);
					lastY = e.getY();
					lastX = e.getX();

					//this checks the array count for the first clicked
					if (coordsX.size() < 4 && coordsY.size() < 4) {
						
						

						Graphics g = frame.getGraphics(); 
						Graphics2D g2d = (Graphics2D)g;
						
						g2d.setColor(Color.BLUE); 
						
						g2d.fillOval(x, y, r, r); 
						g2d.dispose();
						coordsX.add((float) e.getX()); 
						coordsY.add((float) e.getY()); 
						
						System.out.println("Mouse clicked at " + "X:" + e.getX() + " " + " Y:" + e.getY());
						//System.out.println("X coords in Array: " + Arrays.asList(coordsX));
						//System.out.println("Y coords in Array: " + Arrays.asList(coordsY));
						
						
						
						
						
						if(coordsX.size() == 4 && coordsY.size() == 4){
							JOptionPane.showMessageDialog(frame,
								    "Password Saved - Please Enter the Password",
								    "Password Saved", JOptionPane.INFORMATION_MESSAGE);
							
						}	
					}
					else if(comparecoordsX.size() < 4 && comparecoordsY.size() < 4){
						comparecoordsX.add((float) e.getX());	
						comparecoordsY.add((float) e.getY());
						
				
					
						System.out.println("Mouse released at " + "X:" + e.getX() + " " + " Y:" + e.getY());
						//System.out.println("Compare first Click X coords in Array: " + Arrays.asList(comparecoordsX));
						//System.out.println("Compare first Click Y coords in Array: " + Arrays.asList(comparecoordsY));
						
						//lock();
						
					}			

						

							if(ellipse.contains(e.getPoint())){
									
									System.out.println("Clicked a "+ellipse.getClass().getName());
								}

							
					}

					public void mouseEntered(MouseEvent e) {
					}

					public void mouseExited(MouseEvent e) {
					}

					public void mouseClicked(MouseEvent e) {
					}
				});
			}
		});
	}
}

[Paul Clapham]

I don't understand what "get two rectangle objects intersecting" means. The code you posted doesn't have any rectangle objects in it and it doesn't have a method for determining whether something is intersecting something else. So are you asking about that code? If so, which part of it?

[Patty Lebowski]

Paul Clapham wrote:I don't understand what "get two rectangle objects intersecting" means. The code you posted doesn't have any rectangle objects in it and it doesn't have a method for determining whether something is intersecting something else. So are you asking about that code? If so, which part of it?

I'm sorry, I should have explained it better. I'm trying to create a lock in the sense that a user clicks on the screen in four different places. To do this I'm having every time the user clicks create a "rectangle" (a circle shape on screen), storing it, and then have the user click a second time creating circles and seeing if all four circles line up properly and intersect the previous set password. The issue is that they always come back as the correct intersecting shape password, even when they are not intersecting.  I've been testing different things, one of them being:  if(ellipse.contains(e.getPoint())), to see what I'm clicking on. The results always return back the Rectangle2D class name when printed out, meaning that there are rectangles that I'm not seeing or something else is messed up.

I could have probably avoided this mess if I could figure out how to make a single user click radius larger, and then comparing that range in two arrays. But I couldn't figure that out either.

[Campbell Ritchie]

I had a look at your code yesterday and there is lots to say about it, I am afraid. I think you will end up having to start from scratch, but please continue by telling is what you are trying to do. What is a lock? How do you get it from four little circles? I ran your code and the little instructions window was not at all clear. I couldn't tell what I was supposed to do from it.

[Paul Clapham]

I sort of understand that, only there's a lot I don't understand. For example how clicking the screen twice can create four circles... but anyway here's what I see.

When the user clicks the screen you get a mouse pressed event. You then create a circle (named "ellipse", which is a bit distracting) whose centre is where the mouse click occurs and whose radius is 30. Later in the event processing you ask whether the user clicked in that circle. Which of course they did because you created the circle to be a circle around where the user clicked.

So that isn't what you want to do. However I don't know what you should do instead. It seems to me like there's already a password somewhere which somehow has some circles associated with it, and you want to see whether the user clicked in one of those circles. But I don't see any circles anywhere else in your program which you could use.