How to add data to tableview

[Menachem Henry]

I've tried generalizing a few examples I've found online with my own code, but I can't seem to get any data to add to the table. The columns add just fine. Some insight on how this works would be helpful. I've already picked my may through the API that relates to tables and I still can't seem to get it to work.

What I want to happen is for the user to click the add button, to select the file(s) and for the data to be added to the table. The only things that get added are the column names.

package PartsBox;

import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;

import PartsBox.Structs.LibraryGenerator;
import PartsBox.Structs.Part;
import javafx.application.Application;
import javafx.collections.FXCollections;
import javafx.event.ActionEvent;
import javafx.scene.Group;
import javafx.scene.Scene;
import javafx.scene.control.Button;
import javafx.scene.control.Label;
import javafx.scene.control.Tab;
import javafx.scene.control.TabPane;
import javafx.scene.control.TabPane.TabClosingPolicy;
import javafx.scene.control.TableColumn;
import javafx.scene.control.TableView;
import javafx.scene.control.cell.PropertyValueFactory;
import javafx.scene.layout.AnchorPane;
import javafx.scene.layout.HBox;
import javafx.scene.layout.VBox;
import javafx.scene.text.Font;
import javafx.stage.FileChooser;
import javafx.stage.FileChooser.ExtensionFilter;
import javafx.stage.Screen;
import javafx.stage.Stage;

public class Main extends Application{

    LibraryGenerator pLib = new LibraryGenerator();

    private int prefWidth = 900;
    private int prefHeight = 900;
    private int screenWidth = (int) Screen.getPrimary().getBounds().getWidth();
    private int screenHeight = (int) Screen.getPrimary().getBounds().getHeight();
    private int minWidth = 600;
    private int minHeight = 600;

	public static void main(String[] args) {
		launch(args);
	}

	@Override
	public void start(Stage stage) throws IOException {

			if(prefWidth > screenWidth){prefWidth = screenWidth;}
			if(prefHeight > screenHeight){prefHeight = screenHeight;}

		 	Scene scene = new Scene(new Group());
	        AnchorPane masterPane = new AnchorPane();
	        TabPane tabPane = new TabPane();

	        Tab libTab = new Tab("Library");
	        Tab proTab = new Tab("Projects");
	        Tab setTab = new Tab("Settings");

	        HBox masterPane_lib = new HBox();
	        VBox controlsPane_lib = new VBox();
	        VBox dataPane_lib = new VBox();

	        HBox masterPane_pro = new HBox();
	        VBox controlsPane_pro = new VBox();
	        VBox dataPane_pro = new VBox();
	        VBox tableContaier_pro = new VBox();

	        Button addImport_lib = new Button("Add/Import");
	        Button export_lib = new Button("Export Library");
	        Button manualAdd_lib = new Button("Add Parts");
	        Button clr_lib = new Button("Clear Table");

	        stage.setTitle("Parts Box");
	        stage.setWidth(prefWidth);
	        stage.setHeight(prefHeight);

	        masterPane.isResizable();

	        tabPane.setTabClosingPolicy(TabClosingPolicy.UNAVAILABLE);
	        tabPane.isResizable();
	        tabPane.getTabs().addAll(libTab,proTab,setTab);

	        stage.setMinHeight(minHeight);
	        stage.setMinWidth(minWidth);
	        stage.setMaxWidth(screenWidth);
	        stage.setMaxHeight(screenHeight);

	        controlsPane_lib.setMinWidth(120);
	        controlsPane_lib.setPrefWidth(120);
	        dataPane_lib.setPrefSize(prefWidth, prefHeight);
	        masterPane_lib.setPrefSize(prefWidth, prefHeight);

	        dataPane_pro.setPrefSize(prefWidth, prefHeight);
	        masterPane_pro.setPrefSize(prefWidth, prefHeight);
	        masterPane_pro.setPrefSize(prefWidth, prefHeight);

	        dataPane_lib.setMaxWidth(screenWidth-screenWidth*0.05);

	        // - - - - - - - - - AutoResizing

	        controlsPane_lib.prefHeightProperty().bind(masterPane_lib.heightProperty()); // fixed width and variable height
	        dataPane_lib.prefHeightProperty().bind(masterPane_lib.layoutYProperty());
	        dataPane_lib.prefHeightProperty().bind(tabPane.layoutXProperty());

	        TableView<Part> table_lib = new TableView<Part>();

	        table_lib.prefHeightProperty().bind(dataPane_lib.heightProperty());
	        table_lib.prefWidthProperty().bind(dataPane_lib.widthProperty());

	        masterPane_lib.prefHeightProperty().bind(tabPane.heightProperty());
	        masterPane_lib.prefWidthProperty().bind(tabPane.widthProperty());

	        tabPane.prefHeightProperty().bind(masterPane.heightProperty());
	        tabPane.prefWidthProperty().bind(masterPane.widthProperty());

	        masterPane.prefHeightProperty().bind(stage.heightProperty());
	        masterPane.prefWidthProperty().bind(stage.widthProperty());

	        // - - - - - - - - - - - - - - - -

	        table_lib.setEditable(true);
	        table_lib.setColumnResizePolicy(TableView.UNCONSTRAINED_RESIZE_POLICY);

	        Label libLabel_lib = new Label("Library Components");
	        libLabel_lib.setWrapText(true);
	        dataPane_lib.getChildren().addAll(libLabel_lib,table_lib);
	        libLabel_lib.setFont(new Font(24));

	        addImport_lib.setPrefHeight(70);
	        addImport_lib.setPrefWidth(112);
	        addImport_lib.setWrapText(true);

	        export_lib.setPrefHeight(70);
	        export_lib.setPrefWidth(112);
	        export_lib.setWrapText(true);

	        manualAdd_lib.setPrefHeight(70);
	        manualAdd_lib.setPrefWidth(112);
	        manualAdd_lib.setWrapText(true);

	        clr_lib.setPrefHeight(70);
	        clr_lib.setPrefWidth(112);
	        clr_lib.setWrapText(true);
// - - - - - - - - - - - - - - - - - - - - - v



	        ArrayList<TableColumn<Part,String>> cols = new ArrayList<>();
	        int i = 0;
	        for(String cat : pLib.getHeaders()){
	        	cols.add(new TableColumn<Part,String>(cat));
	        	cols.get(i).setSortable(true);
	        	cols.get(i++).setCellValueFactory(new PropertyValueFactory<>(cat.toLowerCase()));
	        }

	        table_lib.getColumns().addAll(cols);



// - - - - - - - - - - - - - - - - - - - - - ^
	        controlsPane_lib.getChildren().addAll(addImport_lib,export_lib,manualAdd_lib,clr_lib);

	        masterPane_lib.getChildren().addAll(controlsPane_lib,dataPane_lib);
	        libTab.setContent(masterPane_lib);

	        masterPane.getChildren().addAll(tabPane); // add all to pane

	        ((Group) scene.getRoot()).getChildren().addAll(masterPane); // master add statement

	        stage.setScene(scene);
	        stage.show();

// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - v

	        addImport_lib.setOnAction((event) -> {

	        	FileChooser fileChooser = new FileChooser();
	        	fileChooser.setTitle("Open Resource Files");
	        	fileChooser.getExtensionFilters().addAll(
	        	        new ExtensionFilter(".txt/.csv/.tsv", "*.txt","*.csv","*.tsv"));
	        	List<File> files = fileChooser.showOpenMultipleDialog(stage);
	        	if(files == null){
	        		return;
	        	}

	        	pLib.addFiles(files);


	            final TableView<Part> table = new TableView<>(FXCollections.observableArrayList(pLib.getParts())
	           );


	        	ArrayList<TableColumn<Part,String>> newCols = new ArrayList<>();
	            int j = 0;
	            for(String cat : pLib.getHeaders()){
	            	newCols.set(j,new TableColumn<Part,String>(cat));
	            	newCols.get(j).setSortable(true);
	            	newCols.get(j++).setCellValueFactory(new PropertyValueFactory<>(cat.toLowerCase()));
	            }


	        });

// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ^

	        export_lib.setOnAction((event) -> {
	            // Button was clicked, do something...
	        });
	        manualAdd_lib.setOnAction((event) -> {
	            // Button was clicked, do something...
	        });
	        clr_lib.setOnAction((event) -> {
	            // Button was clicked, do something...
	        });

	}

	public void handle(ActionEvent arg0) {

	}

}

Part definition

package PartsBox.Structs
;

import java.util.ArrayList;
import java.util.List;

import javafx.beans.property.SimpleStringProperty;
import javafx.beans.value.ObservableValue;

public class Part {

	private List<String> partDetails;

    String pn ;
    String mpn ;
    String description ;
    String quantity ;
    String unitPrice ;
    String mfg ;
	public Part(int headerSize){
		partDetails = new ArrayList<String>();
    	for(int j = 0 ; j < headerSize; j++){
    		partDetails.add("");
    	}

        pn = new String("Part Number");
        mpn = new String("Manufacturer Part Number");
        description = new String("Description");
        quantity = new String("Quantity");
        unitPrice = new String("Unit Price");
        mfg = new String("Manufacturer");

	}

	public List<String> getPartListArray(){
		return partDetails;
	}
	public String getAttribute(int n){

		if(n < partDetails.size() && n > 0){
			return partDetails.get(n);
		}
		return "Out Of Bounds Request in Part.java getAttribute";
	}
	public void appendHeaderSpace(){
		partDetails.add("");
	}

	public void insertPartDetail(String s, String header){

		if(header.equalsIgnoreCase(pn)){
			pn = s;
		}
		else if(header.equalsIgnoreCase(mpn)){
			mpn = s;
		}
		else if(header.equalsIgnoreCase(description)){
			description = s;
		}
		else if(header.equalsIgnoreCase(quantity)){
			quantity = s;
		}
		else if(header.equalsIgnoreCase(unitPrice)){
			unitPrice = s;
		}
	}

	public void insertPartDetail(String s, int n){
		partDetails.set(n, s);

		switch(n){
		case 0:{pn = s;break;}
		case 1:{mpn = s;break;}
		case 2:{description = s;break;}
		case 3:{quantity = s;break;}
		case 4:{unitPrice = s;break;}
		case 5:{mfg = s;break;}
		default: break;
		}

	}
	public ObservableValue<String> getImmutable(int n){

		if(n < partDetails.size() && n > 0){
			return new SimpleStringProperty(partDetails.get(n));
		}
		return null;

	}

	public String getPn(){
		return pn;
	}
	public String getMpn(){
		return mpn;
	}
	public String getDescription(){
		return description;
	}
	public String getQuantity(){
		return quantity;
	}
	public String getUnitPrice(){
		return unitPrice;
	}
	public String getMfg(){
		return mfg;
	}


}

Library Generator

package PartsBox.Structs;

import java.io.BufferedReader;
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.ArrayList;
import java.util.List;

public class LibraryGenerator {

    List<String> headers;
    List<Part> parts;
    int numHeaders;
    int numParts;

    public LibraryGenerator(List<File> files){

        parts = new ArrayList<Part>();

        headers = new ArrayList<String>();

        headers.add("Part Number");
        headers.add("Manufacturer Part Number");
        headers.add("Description");
        headers.add("Quantity");
        headers.add("Unit Price");
        headers.add("Manufacturer");

        numHeaders = 6;
        numParts = 0;

    	parseFileHeaders(files);
    	parseItems(files);

    }
    public LibraryGenerator(){

        parts = new ArrayList<Part>();

        headers = new ArrayList<String>();

        headers.add("Part Number");
        headers.add("Manufacturer Part Number");
        headers.add("Description");
        headers.add("Quantity");
        headers.add("Unit Price");
        headers.add("Manufacturer");

        numHeaders = 6;
        numParts = 0;

    }

	private void parseFileHeaders(List<File> files){

		for(File f : files){
			if(f == null)
				return;

			try {
	            FileInputStream fStream = new FileInputStream(f);
	            BufferedReader in = new BufferedReader(new InputStreamReader(fStream));

	            //check for empty header header
	            String tempString = in.readLine();
	            if(tempString.isEmpty()){
	            	System.out.println("File has no contents or a blank first line, skipping file");
	            	break;
	            }

	            //get extra header catagories
	            String[] tempHeaderCatagories = tempString.split("\\t|,"); // tab and comma delimited files

	            for(String headerCatagory : tempHeaderCatagories){
	            	if(!headers.contains(headerCatagory)){ // if the header isn't in the list
	            		headers.add(headerCatagory);	//add a new header to the list
	            		numHeaders++;
	            	}
	            }

	            in.close();
	        } catch (IOException e) {
	            System.out.println("File input error");
	        }
		}
	}

	private void parseItems(List<File> files){
		for(File file : files){
	    	try {
	            FileInputStream fStream = new FileInputStream(file);
	            BufferedReader in = new BufferedReader(new InputStreamReader(fStream));

	            //check for empty header header
	            String tempString = in.readLine();
	            if(tempString.isEmpty()){
	            	System.out.println("File has no contents or a blank first line, skipping file");
	            	break;
	            }

	            //get extra header catagories
	            String[] tempHeaderCatagories = tempString.split("\\t|,"); // tab and comma delimited files

	            //add items and attributes
	            tempString = in.readLine();
	            while (!tempString.isEmpty()) {

	            	String[] itemLine = tempString.split("\\t|,");

	            	int i = 0;

	            	Part tempPart = new Part(headers.size());

	            	for(String itemProperty : itemLine){ // for each item property field in the string, add it according to the corresponding header in headerItems
	            		int index = headers.indexOf(tempHeaderCatagories[i]);
	            		tempPart.insertPartDetail(itemProperty, index);

	            		i++;
	            	}

	            	parts.add(tempPart);
	            	numParts++;
	            	tempString = in.readLine();
	            }
	            in.close();

	        } catch (IOException e) {
	            System.out.println("File input error2");
	        }

	    }
	}

	public void addFiles(List<File> files){

	}

	public void addParts(){

	}

	public void removeParts(){

	}

	public void editParts(){

	}

	public List<String> getHeaders(){
		return headers;
	}

	public String getHeader(int index){
		return headers.get(index);
	}

	public int getHeaderIndex(String s) throws IOException{
		int num = headers.indexOf(s);
		if(num == -1){

			return 0;
		}

		return num;
	}

	public int getNumHeaders(){
		return numHeaders;
	}

	public int getNumParts(){
		return numParts;
	}

	public List<Part> getParts(){
		return parts;
	}

	public Part getPart(int index){
		return parts.get(index);
	}

}

[John Damien Smith]

I didn't look through all of your code, there is a lot of it, next time it is probably best to post an mcve: https://stackoverflow.com/help/mcve

One thing you don't have in your code (unless I missed it) is any code which sets the data into the table view (which is why no data shows).

When you create the table view you can pass it an observable list of items, which is the data it will display:
 https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/TableView.html#TableView-javafx.collections.ObservableList-

ObservableList<Part> parts = FXCollections.observableArrayList(new Part(...), new Part(...));
TableView<Part> partTableView = new TableView<>(parts);

You can also set the items at a later stage rather than in the constructor if you prefer:

partTableView.setItems(parts);

Once the parts list is associated with the table as above, adding a new item to the parts list will also add it to the TableView, as the parts list is an ObservableList and the TableView knows this and observes the list for changes:

parts.add(new Part(...));

For more info, read the javadoc in TableView.

[Menachem Henry]

Alright, Thanks for your clear description, help and patience. I was having trouble understanding the flow of events for adding things to a table, but this finalizes it.