Guessing Game

[Natasha Gomez]

Hello everyone, I am new to this and I am having problem figure out how to fix my code. I am a beginner and just want to learn. I know I have a lot to learn. So if someone could tell me what I am doing wrong. I would appreciate it. I am creating a guessing game for a user to select a number from 1-10 but when entering an answer, it does not tell me if I won or lost correctly. When I set it to false I lose and when I set it to true I win. But this is not what I want. But, when I answer correctly it says correct guess but the game does not end, it just continues. Please help I am stuck.

import java.util.*;
import javax.swing.*;


public class Guessing_Game 
{

public static void main ( String [] args ) 
{
	boolean x = true;
	boolean win = false;
			
			
				
	
	//Method is used to input statement "would you like to play again?"
	Scanner userIn = new Scanner(System.in);
	
	
	//Declaring my variables
	int starguess = 0;
	Random newRand = new Random();
	String mess;
	
	do
    {
		int a = newRand.nextInt(10) +1;
		
		if (playGame(x)){
		  mess = "Congrats, You Won!";
		} else
		  mess = "You lost the number was" + a;
	    mess = mess + "\nWould you like to play again?";
		
		starguess = JOptionPane.showConfirmDialog(null, mess, "Continue?", JOptionPane.YES_NO_CANCEL_OPTION);
	}
	while (win == false);
		
}
	public static boolean playGame (boolean choice) 
	{
		//Declaring my variables
		final int tries = 4;
		int starguess = 0;
		int rand;
		Random rands = new Random();
		rand = rands.nextInt(10);
		
		String prompt = "Guess a number between 1 and 10";
		
		while (starguess < 4)
		{
			
			//User inputs their selection
			String playerInput = JOptionPane.showInputDialog(null, prompt, 4 -      starguess      + "Tries Left", 3);
			
			int playerGuess = Integer.parseInt(playerInput);
			
			
				
				compareTo(playerGuess, rand);//used to compare methods
				
				starguess++;
			
			
		}
		
		return choice;
	}
	public static int compareTo ( int userGuess, int userAnswer)
	{
		//Method used to show user's inputs and the correct answer
		String message;
		
		if ( userGuess == userAnswer)
		{
			message = JOptionPane.showInputDialog(null, "Correct Guess");
			return 0;
					
		}	
		else if ( userGuess < userAnswer)
		{	
			message = JOptionPane.showInputDialog(null, "Too Low! Try Again!");
			return -1;
		}	
		else if ( userGuess > userAnswer)
		{
			message = JOptionPane.showInputDialog(null, "Too High! Try Again!");
			return 1;
		}
		
		return userGuess - userAnswer;
		
		
	}
	
}
		

[Carey Brown]

   do    {        int a = newRand.nextInt(10) +1;                if (playGame(x)){          mess = "Congrats, You Won!";        } else          mess = "You lost the number was" + a;        mess = mess + "\nWould you like to play again?";                starguess = JOptionPane.showConfirmDialog(null, mess, "Continue?", JOptionPane.YES_NO_CANCEL_OPTION);    }    while (win == false);On line 27 you create and initialize 'a' but you never pass it to playGame(), so playGame() creates its own random number that is probably not the same as 'a' yet on lline 32 you print "...number was " + a, which is not true.

So far haven't looked beyond this.

[Natasha Gomez]

When i put a in the playGame it gives me an error when i compile it. It says int cannot be converted into boolean

[Carey Brown]

Always cut and paste the text of any error message into a post.

Which line number?

[Carey Brown]

   public static boolean playGame (boolean choice)    {        //Declaring my variables        final int tries = 4;        int starguess = 0;        int rand;        Random rands = new Random();        rand = rands.nextInt(10);                String prompt = "Guess a number between 1 and 10";                while (starguess < 4)        {                        //User inputs their selection            String playerInput = JOptionPane.showInputDialog(null, prompt, 4 -      starguess      + "Tries Left", 3);                        int playerGuess = Integer.parseInt(playerInput);                                                        compareTo(playerGuess, rand);//used to compare methods                                starguess++;                                }                return choice;    }You get "choice" as an input parameter but you don't do anything with it except return it at the end.

[Natasha Gomez]

do
    {
        int a = newRand.nextInt(10) +1;
          
        if (playGame(x)){
          mess = "Congrats, You Won!";
        } else
          mess = "You lost the number was" + a;
        mess = mess + "\nWould you like to play again?";
          
        starguess = JOptionPane.showConfirmDialog(null, mess, "Continue?", JOptionPane.YES_NO_CANCEL_OPTION);
    }
    while (win == false);

I get the error when I enter a into if (playGame(a)) {

[Natasha Gomez]

Am I also not understanding what I had to do with choice?
Sorry I am new to things and still learning the basics

public static boolean playGame (boolean choice) 
    {
        //Declaring my variables
        final int tries = 4;
        int starguess = 0;
        int rand;
        Random rands = new Random();
        rand = rands.nextInt(10);
          
        String prompt = "Guess a number between 1 and 10";
          
        while (starguess < 4)
        {
              
            //User inputs their selection
            String playerInput = JOptionPane.showInputDialog(null, prompt, 4 -      starguess      + "Tries Left", 3);
              
            int playerGuess = Integer.parseInt(playerInput);
              
              
                  
                compareTo(playerGuess, rand);//used to compare methods
                  
                starguess++;
              
              
        }
          
        return choice;
    }

[Campbell Ritchie]

Welcome to the Ranch

I can see some other things which haven't been mentioned yet; I shall only tell you about one mistake.
Never write == false or == true. Not only are they both poor style, but they are also error‑prone; every now and again we see somebody write = instead of == and they now have two errors for the price of one.
Never while (b == false) ...
Always while (!b) ...
Never while (b == true) ...
Always while (b) ...

[Knute Snortum]

Natasha Gomez wrote:

do
    {
        int a = newRand.nextInt(10) +1;
          
        if (playGame(x)){
          mess = "Congrats, You Won!";
        } else
          mess = "You lost the number was" + a;
        mess = mess + "\nWould you like to play again?";
          
        starguess = JOptionPane.showConfirmDialog(null, mess, "Continue?", JOptionPane.YES_NO_CANCEL_OPTION);
    }
    while (win == false);

I get the error when I enter a into if (playGame(a)) {

First of all, please post the entire error message you get.  But also notice that you speak of if (playGame(a)) but the code is if (playGame(x)).