Problem sending info from Servlet to DAO

[Jack Boylan]

I am trying to get that when a user enters details into the jsp form it sends it to the insertFilm in my FilmDAO.

Servlet:

protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		// TODO Auto-generated method stub
		response.getWriter().append("Served at: ").append(request.getContextPath());
			
		String insertTitleInput = request.getParameter("filmTitleInsert");
		String insertYearInput = request.getParameter("filmYearInsert");
		String insertDirectorInput = request.getParameter("filmDirectorInsert");
		String insertStarsInput = request.getParameter("filmStarsInsert");
		String insertReviewInput = request.getParameter("filmReviewInsert");
		
		int insertYearInputInt = Integer.parseInt(insertYearInput); 
		
		FilmDAO dao = new FilmDAO();
		Film newFilm = Film(insertTitleInput, insertYearInputInt, insertDirectorInput, insertStarsInput, insertReviewInput);
		dao.insertFilm(newFilm);
		

FilmDAO:

	public int insertFilm(Film f) {
		openConnection();
		try {
			String insertSQL = "INSERT INTO films (title, year, director, stars, review) VALUES(?,?,?,?,?)";
			PreparedStatement stmt = conn.prepareStatement(insertSQL);
			//info here
			System.out.println(insertSQL);
			stmt.setString(1, f.getFilmTitle());
			stmt.setInt(2, f.getFilmYear());
			stmt.setString(3, f.getFilmDirector());
			stmt.setString(4, f.getFilmStars());
			stmt.setString(3, f.getFilmReview());
			return stmt.executeUpdate(insertSQL);
		} catch (SQLException se) {
			se.printStackTrace();
			return 0;
		}
	}

I get an error on:

		Film newFilm = Film(insertTitleInput, insertYearInputInt, insertDirectorInput, insertStarsInput, insertReviewInput);

It tells me:

Multiple markers at this line
	- The method f(String, int, String, String, String) is undefined for the type 
	 InsertFilm

[Madan Lal]

You are calling a constructor right?, you need to invoke it with new keyword. Just like how you do while creating an object.

[Tim Holloway]

Welcome to the Ranch, Jack!

You haven't shown the definition for class Film. The message says that the constructor code that you're invoking doesn't match any of the constructors defined for class Film.

[Jack Boylan]

Tim Holloway wrote:Welcome to the Ranch, Jack!

You haven't shown the definition for class Film. The message says that the constructor code that you're invoking doesn't match any of the constructors defined for class Film.

I dont understand?

	public Film(int id, String title, int year, String stars, String director, String review) {
		setFilmId(id);
		setFilmTitle(title);
		setFilmYear(year);
		setFilmStars(stars);
		setFilmDirector(director);
		setFilmReview(review);
	}

[Paul Clapham]

So you have a Film constructor with 6 parameters. And the error message says you're trying to call a Film method with 5 parameters. What exactly does "I don't understand?" mean in that context?

[Dave Tolls]

Film newFilm = Film(etc etc);

What does an instantiation call normally look like, and how does this line compare?

[Tim Holloway]

Dave Tolls wrote:

Film newFilm = Film(etc etc);

What does an instantiation call normally look like, and how does this line compare?

That is an instantiation call.

It's just like any other method invocation except that the return from the method is a newly-created instance of the object. And just like any other method, you have to have a match between the calling code and one of the method signatures define in the class.

So I can't do this:

class Foo {
    Foo(int x, int, y, String z) {...}

   void doSomething() {
      Foo myFoo = new Foo(1, 2);
  }

Because I told it to make a new Foo, but only gave it 2 of the 3 values needed by the Foo() constructor method.

[Rob Spoor]

Tim Holloway wrote:

Dave Tolls wrote:

Film newFilm = Film(etc etc);

What does an instantiation call normally look like, and how does this line compare?

That is an instantiation call.

There's an important word missing in there, and Madan Lal already said which word.

[Tim Holloway]

Oops,
You're right.
Sometimes when we
we read the the words
we read what they think they say.

And not what they really say.