Delete method not deleting hard coded books

[Kevin O'Sullivan]

The delete function in my library program doesn't work properly, it won't delete the hard coded in the list but if I enter them in via user input it does, why is this?

public class Book implements ILibrary{

    private String bookName;
    private String authorName;
    private int numberOfCopiesInStock;
    private String Isbn;

    public Book(String bookName,String authorName,int numberOfCopiesInStock,String Isbn){
        this.setBookName(bookName);
        this.setAuthorName(authorName);
        this.setNumberOfCopiesInStock(numberOfCopiesInStock);
        this.setIsbn(Isbn);
    }

    public void setBookName(String bookName)throws IllegalArgumentException{
        if(bookName.isEmpty()){
            throw new IllegalArgumentException("FIELD CANNOT BE EMPTY!");
        }else{
            this.bookName = bookName;
        }
    }

    public void setAuthorName(String authorName)throws IllegalArgumentException{
        if(authorName.isEmpty()){
            throw new IllegalArgumentException("FIELD CANNOT BE EMPTY");
        }else{
            this.authorName = authorName;
        }
    }

    public void setNumberOfCopiesInStock(int numberOfCopiesInStock)throws IllegalArgumentException{
        if(numberOfCopiesInStock < MIN_NUMBER_OF_COPIES || numberOfCopiesInStock > MAX_NUMBER_OF_COPIES){
            throw new IllegalArgumentException("INVALID NUMBER OF COPIES ENTERED INTO STOCK!");
        }else{
            this.numberOfCopiesInStock = numberOfCopiesInStock;
        }
    }

    public void setIsbn(String Isbn)throws IllegalArgumentException{
        if(Isbn.length() < ISBN_MAX_NUMBER_OF_DIGITS || Isbn.length() > ISBN_MAX_NUMBER_OF_DIGITS){
            throw new IllegalArgumentException("ISBN LENGTH ENTERED IS INVALID,TRY AGAIN");
        }else{
            this.Isbn = Isbn;
        }
    }

    public String getBookName(){
        return this.bookName;
    }

    public String getAuthorName(){
        return this.authorName;
    }

    public int getNumberOfCopiesInStock(){
        return this.numberOfCopiesInStock;
    }

    public String getIsbn(){
        return this.Isbn;
    }

    public String toString(){
        return("BookName: " + getBookName()
                +"\n"
                +"AuthorName: " + getAuthorName()
                +"\n"
                +"Number of Copies: " + getNumberOfCopiesInStock()
                +"\n"
                +"ISBN: " + getIsbn());
    }

public class Main {
    public static String search;
    public static String deleteBookName;
    public static boolean keepGoing = true;
    private static Random random = new Random();
    public static Scanner scan = new Scanner(System.in);

    public static void main(String[] args) {

            welcomeMessage();
            menuHeader();
            getUserInput();
    }

    private static void welcomeMessage(){
        System.out.println("********************");
        System.out.println("*       Cork       *");
        System.out.println("*      Library     *");
        System.out.println("********************");
    }

    private static void menuHeader(){
        System.out.println("********************");
        System.out.println("*       Menu       *");
        System.out.println("*     Options      *");
        System.out.println("********************");
    }

    private static void menuOptions(){
        System.out.println("***********************");
        System.out.println("*1.) Add Book         *");
        System.out.println("*2.) Search for Book  *");
        System.out.println("*3.) Delete Book      *");
        System.out.println("*4.) Display all Books*");
        System.out.println("*0.) Exit Program     *");
        System.out.println("***********************");
    }

    private static void getUserInput(){
        int choice;
        menuOptions();
        do{
            System.out.println(">");
            while(!scan.hasNext()){
                scan.next();
                System.out.println("INTEGERS ONLY PLEASE");
            }
            choice = scan.nextInt();
            scan.nextLine();
            menuSelection(choice);
        }while(choice!= 0);
    }

    private static void menuSelection(int choice){
        switch(choice){
            case 1: enterBookInfo();
            break;

            case 2: Library library1 = new Library();
            library1.bookInStock();
            inputSearch();
            break;

            case 3: 
                 inputBookToDelete()
            break;

            case 4: Library library3 = new Library();
            library3.bookInStock();
            library3.printListOfBook();
            break;

            case 0: Library library4 = new Library();
            library4.exit();
            break;

            default:
                break;
        }
    }

    private static void enterBookInfo(){
        while(keepGoing){

            System.out.println("Please enter name of book: ");
            String bookName = scan.nextLine();

            if (bookName.equalsIgnoreCase("end"))
            {
                break;
            }

            System.out.println("Please enter author: ");
            String authorName = scan.nextLine();

            System.out.println("Please enter ISBN Number: ");
            String isbnNumber = scan.nextLine();

            System.out.println("Please enter number of books in stock: ");
            int numberOfCopiesInStock = scan.nextInt();
            scan.nextLine();

            Book book = new Book(bookName, authorName, numberOfCopiesInStock, isbnNumber);
            Library.bookList.add(book);
        }
    }

    private static void inputSearch(){
        Library lib = new Library();
        System.out.println("\n**********Search for Book**********");
        System.out.println("Please enter BookName: ");
        search = scan.nextLine();
        run();
        lib.searchForBooks();
    }

    private static void inputBookToDelete(){
        Library lib = new Library();
        System.out.println("\n**********Delete Employee**********");
        System.out.println("Please enter book name: ");
        deleteBookName = scan.nextLine();
        lib.deleteBooks();
    }

    public static void run(){
        int number = random.nextInt(10)+1;
        System.out.println("Check system......please wait....");
        try{
            Thread.sleep(number * 1000);
        }catch(InterruptedException e){
            e.printStackTrace();
        }
    }

public class Library {

    public static ArrayList<Book> bookList = new ArrayList<Book>();

    public void bookInStock(){
        Book book1 = new Book("Neverwhere","Neil Gaimen",2,"A100023454");
        Book book2 = new Book("American Gods","Neil Gaimen",1,"A100023454");
        Book book3 = new Book("I.T","Stephen King",0,"A123432454");
        bookList.add(book1);
        bookList.add(book2);
        bookList.add(book3);
    }

    public Boolean searchForBooks(){
        for(Book b : bookList){
            if(b.getBookName().equalsIgnoreCase(Main.search)){
                System.out.println(b);
                return true;
            }
        }
        System.out.println("BOOK DOESN'T EXIST! ");
        return false;
    }

    public void printListOfBook(){
        for(Book b : bookList){
            System.out.println(b.toString());
            System.out.println();
        }
    }

    public void deleteBooks(){
        for(Book b : bookList){
            if(Main.deleteBookName.equalsIgnoreCase(b.getBookName())){
                bookList.remove(b);
                break;
            }
        }
    }

    public void exit(){
        System.out.println("Exiting......");
    }

Any help appreciated.

[Paul Clapham]

Are you referring to the inputBookToDelete() method, which creates a new (presumably empty) library and then tries to delete books from it?

[Paul Clapham]

    public static ArrayList<Book> bookList = new ArrayList<Book>();

That's going to lead to confusion too. Why does the Library class have a static book list? Did you intend for all libraries to to have the same collection of books? (That isn't how libraries work where I live.)

[Carey Brown]

Your problem is that you are creating new libraries all over the place. In your entire project you should only be creating one new Library to represent the Cork Library. You have also made most of your fields public which is allowing inputs of new books a back door into a library from which delete succeeds.

[Kevin O'Sullivan]

Paul Clapham wrote:Are you referring to the inputBookToDelete() method, which creates a new (presumably empty) library and then tries to delete books from it?

Yup well that method takes the input and then the method in Library class deleteBooks() is suppose to take care of the deleting .

[Paul Clapham]

Kevin O'Sullivan wrote:

Paul Clapham wrote:Are you referring to the inputBookToDelete() method, which creates a new (presumably empty) library and then tries to delete books from it?

Yup well that method takes the input and then the method in Library class deleteBooks() is suppose to take care of the deleting .

Like Carey said. Just create one Library. And it should have only one list of books (i.e. making that a static variable is wrong).

[Kevin O'Sullivan]

Carey Brown wrote:Your problem is that you are creating new libraries all over the place. In your entire project you should only be creating one new Library to represent the Cork Library. You have also made most of your fields public which is allowing inputs of new books a back door into a library from which delete succeeds.

ok  I made one instance of library class but had to declare it

public static Library lib = new Library();

I've a feeling this isn't good practice lol.

[Kevin O'Sullivan]

Paul Clapham wrote:

Kevin O'Sullivan wrote:

Paul Clapham wrote:Are you referring to the inputBookToDelete() method, which creates a new (presumably empty) library and then tries to delete books from it?

Yup well that method takes the input and then the method in Library class deleteBooks() is suppose to take care of the deleting .

Like Carey said. Just create one Library. And it should have only one list of books (i.e. making that a static variable is wrong).

yup did this as well but still have the same problem, not deleting any hardcoded books.

[Carey Brown]

You are declaring the entire world static. And no, that's not good practice.
This is your problem:

    public static void main(String[] args) {
 
            welcomeMessage();
            menuHeader();
            getUserInput();
    }

It forces you to use static just to shutup the compiler from complaining. You need to start off by creating an instance of your class and then using that.

    public static void main(String[] args) {
        Main inst = new Main();
        inst.run();
    }

    public void run() {
            welcomeMessage();
            menuHeader();
            getUserInput();
    }

[Carey Brown]

Kevin O'Sullivan wrote:yup did this as well but still have the same problem, not deleting any hardcoded books.

Kevin, when you make a change and then say "nope, it doesn't work" we can't help you unless you show us all the code again.

[Carey Brown]

Carey Brown wrote:

    public static void main(String[] args) {
        Main inst = new Main();
        inst.run();
    }

    public void run() {
            welcomeMessage();
            menuHeader();
            getUserInput();
    }

BTW this will force you to UNDO (almost?) all of those statics.

[Kevin O'Sullivan]

Carey Brown wrote:

Kevin O'Sullivan wrote:yup did this as well but still have the same problem, not deleting any hardcoded books.

Kevin, when you make a change and then say "nope, it doesn't work" we can't help you unless you show us all the code again.

Sorry about that carey, I'll give that a go and report back.

[Campbell Ritchie]

Also, where is your Book#equals() method? You won't be able to delete correctly without it. Remember to ensure all eight requirements are fulfilled:-

1: You must override equals(); don't overload it.

2: Also override hashCode()

3: Reflexivity

4: Symmetry

5: Transitivity

6: Consistency

7: Consistency doesn't allow equals() to throw any exceptions

8: It must return false if null is passed.

I know you can only see five •s here, but they come out to eight requirements.

[Kevin O'Sullivan]

I've been reading up and watching videos on hashcode and equals method as I know nothing about them and I am having trouble understanding how to implement them, am I right in saying these methods should be in the book class ?

[Norm Radder]

Also posted here: https://www.javaprogrammingforums.com/whats-wrong-my-code/43659-delete-method-not-deleting-hard-coded-books.html

Please read:   https://coderanch.com/wiki/660346/Wiki/Forthright-Cross-Posting-Sites

[Kevin O'Sullivan]

Norm Radder wrote:Also posted here: https://www.javaprogrammingforums.com/whats-wrong-my-code/43659-delete-method-not-deleting-hard-coded-books.html

Please read:   https://coderanch.com/wiki/660346/Wiki/Forthright-Cross-Posting-Sites

Sorry norm wasn't aware of that.

[Campbell Ritchie]

Where did you read about hashCode() and equals()? What did they say? I worry about randomly‑found online tutorials; most of them are poor quality.
I recommend you find Effective Java by Joshua Bloch (old edition here),  Odersky Sppon and Venners, and search for Angelika Langer Java equals() hashCode(). Make sure to get the English edition of Langer.

Kindly don't delete your questions, neither here nor on the other forum.

[Norm Radder]

Where is the requirement for an equals method?  The specs say to delete a book with a given name.  

[Kevin O'Sullivan]

Campbell Ritchie wrote:Where did you read about hashCode() and equals()? What did they say? I worry about randomly‑found online tutorials; most of them are poor quality.
I recommend you find Effective Java by Joshua Bloch (old edition here),  Odersky Sppon and Venners, and search for Angelika Langer Java equals() hashCode(). Make sure to get the English edition of Langer.

Kindly don't delete your questions, neither here nor on the other forum.

Here

Just they are used to compare objects and return true or false but I don't have any clue how to implement it for what I need to do.

Tutorial

and this video

[Carey Brown]

I'm with Norm here. Where did we figure we needed equals() and hashCode(). Using the String methods for the name field should suffice.

[Campbell Ritchie]

The video is worthless to beginners. He shows correct implementations of both methods without explaining why you need a particular implementation of equals(). Actually, it isn't quite correct because it can't cope correctly with any of the fields being null. It doesn't show what can go wrong if you don't implement equals() correctly.
He also has some incorrect names for things. There are no “no‑op”s in that code. The lines he calls “no‑op”s actually cause something to be executed and fail to add something to the set; they also return something which we usually ignore. He calls things functions which aren't functions. He also doesn't explain why he is using a nested class, which is a very strange design, and he called the Person class immutable when it isn't strictly immutable. That is O too common a problem: you go through Google, you find something matching your requirements, and you don't have the experience to recognise its shortcomings.
The tutorial link you gave us is slightly better, but it doesn't explain the rules behind equals(). So still of no value to you.
Look in the three resources I gave you yesterday; they do explain the rules and why you need a particular implementation. It is worth reading all three because they all take a slightly different approach. You can only understand the implementation details when you understand the rules behind them. Both your links described hash codes a lot better, which is hardly surprising. Hash codes are much easier to understand.
But there are two more points:-

1: The “alphabet of variables” used to calculate the hash code must not contain anything not used to determine equality.

2: When you write an equals() method, you are determining your definition of equality and it is your definition of equality that will be used for ever. Don't change that definition as the codejava link did, otherwise you can break other code. You do have the option to define two books as equal if they have the same title, but you would be stuck with that definition of equality forever.

What codejava ought to have written, and what is similar to what I would have told you to write if I had actually read your requirements to look only at the title (sorry), is this:-{   Iterator<Student> it = studentSet.iterator();   while (it.hasNext())   {      Student s = it.next();      if (s.getSsn() == numberToRemove)      {         it.reomve();      }   } }It won't work until you corrrect my spellling misteak. There are also methods in the Collection interface to remove all elements matching a particular condition.

[Kevin O'Sullivan]

Thanks a lot for your help, I ordered the effective java book, can't wait to give it a read, seems to be a popular book.

[Kevin O'Sullivan]

Haven't had a chance to try the above yet but Thanks everyone for all yer help, I ordered the effective java book, can't wait to give it a read, seems to be a popular book.

[Kevin O'Sullivan]

I got it working

public void delete(){
        Iterator<Book> it = bookList.iterator();
        while(it.hasNext()){
            Book b = it.next();
            if(deleteBookName.equalsIgnoreCase(b.getBookName())){
                System.out.println("BOOK REMOVED");
                it.remove();
            }
        }
    }

[Campbell Ritchie]

Not bad. Can you do it with the removeIf() method?

[Kevin O'Sullivan]

Campbell Ritchie wrote:Not bad. Can you do it with the removeIf() method?

I'm using java 14 with Intellij and the removeIf() doesn't appear in the drop menu but its been included since java 8?

[Norm Radder]

With the removeIf method, how do you print out the message on line 6?

[Campbell Ritchie]

You can't. This is as near as I could get.

int oldSize = myList.size();
...removeIf...;
System.out.printf"(%d elements removed.%n", oldSize - myList.size());

[Campbell Ritchie]

Actually, maybe you can, if you use a block λ.

(Book b) -> 
   {
      boolean matchesName = ...
      if (matchesName)
      {
         System.out.println("Removing " + ...");
      }
      return matchesName;
   }

Now, that's horrible code style, isn't it!

[Rob Spoor]

That is quite bad, as predicates and functions should ideally be pure - no side effects. However, it is the only way to achieve logging of each separate removed element.