Java table row property problem

[Łukasz Kiepas]

Hello everyone, hope you are doing well

I have a problem that I can't figure out. So, I have a method setColor which sets tableRow of my Table to particular color where a certain condition is satisfied (the account has 'inactive' status).  

  public void setColor(){
        tvEmployees.setRowFactory(tv -> new TableRow<Employees>() {
            @Override
            public void updateItem(Employees item, boolean empty) {
                super.updateItem(item, empty) ;
                if (item == null) {
                } else if (item.getStatus().equals("inactive")) {
                    setStyle(" -fx-background-color:  #adadad;");
                }else {
                }
            }
        });
    }

https://imgur.com/a/OD8qoJN
Everything works perfectly, but my row margins are disappearing.  I thought, ya that's not a problem I will fix it in a sec ... nope.

 public void setColor(){
        tvEmployees.setRowFactory(tv -> new TableRow<Employees>() {
            @Override
            public void updateItem(Employees item, boolean empty) {
                super.updateItem(item, empty) ;
                if (item == null) {
                } else if (item.getStatus().equals("inactive")) {
                    setStyle(" -fx-background-color:  #adadad; -fx-border-color: red; -fx-border-width: 1px;");

                }else {
                }
            }
        });
    }

https://imgur.com/a/DernahP

As you can see alignment got out of sync.
I don't know what style should i use or what is maybe a completely different approach to solve this problem.

[Lou Hamers]

Try adding the style with a new CSS style class instead of using setStyle().

Ex:

getStyleClass().add("inactiveTableRow");

In your CSS (which hopefully you're already using) you'd have a style that looks like this:

.inactiveTableRow {
    -fx-background-color: #ADADAD;
}

[Łukasz Kiepas]

Welcome back

I tried your approach and it helped, but created another problem that I have been trying to solve for the past 4 hours.

I will try to explain it on an easier example: to-do-list
https://imgur.com/a/dvlevLw
When I lunch the app everything is working properly:
https://imgur.com/a/3ZeobUO
I have a database table and when the column (which is invisible) status is true whole row is green and when not whole row is purple - works fine !

But when I am deleting or trying to add new item everything messes up with random colored (always purple)
https://imgur.com/a/HaNx0Tk

Here is my setColor method:

   public void setColor(){
        tvTable.setRowFactory(tv -> new TableRow<ToDoListElement>() {
            @Override
            public void updateItem(ToDoListElement item, boolean empty) {
                super.updateItem(item, empty);
                if(item == null){
                    getStyleClass().add("plainWhite");
                } else if  (item.getStatus() == true) {
                    getStyleClass().add("taskDone");
                }
               else if(item.getStatus() == false) {
                    getStyleClass().add("plainPurple");
                }
            }
        });
    }

Here is my filling Table method which also works fine except setColor(); method.
fillTable method is used after deleting from database and adding to database to show new data in table.

  private void fillTable(){
        ObservableList<ToDoListElement> todoList = (ObservableList<ToDoListElement>) getObsList();
        colID.setCellValueFactory(new PropertyValueFactory<ToDoListElement, Integer>("id"));
        colAddDate.setCellValueFactory(new PropertyValueFactory<ToDoListElement, LocalDate>("add_date"));
        colDeadline.setCellValueFactory(new PropertyValueFactory<ToDoListElement, LocalDate>("deadline"));
        colTask.setCellValueFactory(new PropertyValueFactory<ToDoListElement, String>("task"));
        colAuthor.setCellValueFactory(new PropertyValueFactory<ToDoListElement, String>("author"));
        colDone.setCellValueFactory(new PropertyValueFactory<ToDoListElement, Boolean>("status"));
        tvTable.setItems(todoList);

        setColor();
    }

   public void buttonAddTask(ActionEvent event) throws SQLException {
        LocalDate deadline = datePickerTaskDate.getValue();
        if(textareaTaskAdd.getText().isEmpty() ){
            WarningsToDo.warningTextFieldTask();
        } else if (deadline==null) {
            WarningsToDo.warningDeadline();
        } else {
            addTaskQuery(textareaTaskAdd.getText(), deadline);
        }
        fillTable();
    }

And my CSS file:

.inactiveTableRow{
    -fx-background-color: #adadad;
    /*-fx-border-style: solid solid hidden hidden;
    -fx-border-width: 1;
    -fx-border-color: black;*/
}

.activeTableRow{
    -fx-background-color: rgb(76, 133, 16);
    /*-fx-border-style: solid solid hidden hidden;
    -fx-border-width: 1;
    -fx-border-color: black;*/
}

/*this class targets every single column in the table*/
.tableHeader{
    -fx-border-style: solid hidden hidden solid;
    -fx-border-width: 0.5;
    -fx-border-color: black;
}

Here is a whole class if somebody would like to take a peek:
https://pastebin.com/tiKSYHn8

[Łukasz Kiepas]

Problem solved.
It was all about resetting the table.
https://imgur.com/a/h2hcwwL

[Lou Hamers]

From a quick scan of what you're doing above, you may have been having an issue because you were always adding style classes and never removing them. If you observe the styleclass list that getStyleClass() returns, you'd see that repeated calls of add() make it longer and longer.

It sometimes doesn't cause a problem when we do repeated adds like that, because one class overrides the other, but if you do it too much I can't imagine it being good for performance. So when I add style classes like that to deal with table styles, I usually remove all the ones that may have been added before adding the new one.

The solution you found is probably okay, but I wanted to make you aware of the above.