Help

[William Zane]

import java.util.Scanner;
public class Seasonsinfo {
public static int day;
public static String month;
public static String season;
public static int month1;
public static void getMonth() {
if(month == "January") {
		month1 = 1;
	}else {
if(month == "Febuary") {
		month1 = 2;
	}else {
if(month == "March") {
		month1 = 3;
	}else {
if(month == "April") {
		month1 = 4;
	}else {
if(month == "May") {
		month1 = 5;
	}else {
if(month == "June") {
		month1 = 6;
	}else {
if(month == "July") {
		month1 = 7;
	}else {
if(month == "August") {
		month1 = 8;
	}else {
if(month == "September") {
		month1 = 9;
	}else {
if(month == "October") {
		month1 = 10;
	}else {
if(month == "November") {
		month1 = 11;
	}else {
if(month == "December") {
		month1 = 12;
	}}}}}}}}}}}}}
		

public static void getSeason() {
if(month1 == 1 || month1 == 2 || month1 == 3) {
			season = "Winter";
if(month1%3 == 0) {
if(day > 21) {
			season = "Spring";
		}
		}
	}else {
if(month1 == 4 || month1 == 5 || month1 == 6) {
			season = "Spring";
if(month1%3 == 0) {
if(day > 21) {
			season = "Summer";
}
}
	}else {
if (month1 == 7 || month1 == 8 || month1 ==9) {
			season = "Summer";
if(month1%3 == 0) {
if (day > 21) {
			season = "Fall";
}
}
	}else {
if (month1 == 10 || month1 == 11 || month1 == 12) {
			season = "Fall";
if(month1%3 == 0) {
if (day>21) {
			season = "Winter";
}
}
}
	}
	}
	}
	}
	public static void main(String[] args) {
		Scanner scan = new Scanner(System.in);
		System.out.println("Input a month: ");
		month = scan.next();
		System.out.println(month);
		getMonth();
		System.out.println("Input a day");
		day = scan.nextInt();
		getSeason(); 
		System.out.println(season);

	}

}

I want to input a month then a day then it will print the season. However it just prints null. What am I doing wrong here?

[Carey Brown]

You are attempting to compare Strings using '==' which only compares the references. You need to be using the 'equals()' method instead which compares the characters.

if( month.equals( "March" ) )

[Ron McLeod]

Look at the shape of your code when properly formatted - I'm sure this is not what you are wanting.

public static void getMonth() {
	if (month == "January") {
		month1 = 1;
	} else {
		if (month == "Febuary") {
			month1 = 2;
		} else {
			if (month == "March") {
				month1 = 3;
			} else {
				if (month == "April") {
					month1 = 4;
				} else {
					if (month == "May") {
						month1 = 5;
					} else {
						if (month == "June") {
							month1 = 6;
						} else {
							if (month == "July") {
								month1 = 7;
							} else {
								if (month == "August") {
									month1 = 8;
								} else {
									if (month == "September") {
										month1 = 9;
									} else {
										if (month == "October") {
											month1 = 10;
										} else {
											if (month == "November") {
												month1 = 11;
											} else {
												if (month == "December") {
													month1 = 12;
												}
											}
										}
									}
								}
							}
						}
					}
				}
			}
		}
	}
}

[Carey Brown]

Your code is inconsistently indented making it difficult to follow. This is how it should look:

import java.util.Scanner;

public class Season
{
	public static int day;
	public static String month;
	public static String season;
	public static int month1;

	public static void getMonth() {
		if( month.equals( "January" ) ) {
			month1 = 1;
		}
		else {
			if( month.equals( "Febuary" ) ) {
				month1 = 2;
			}
			else {
				if( month.equals( "March" ) ) {
					month1 = 3;
				}
				else {
					if( month.equals( "April" ) ) {
						month1 = 4;
					}
					else {
						if( month.equals( "May" ) ) {
							month1 = 5;
						}
						else {
							if( month.equals( "June" ) ) {
								month1 = 6;
							}
							else {
								if( month.equals( "July" ) ) {
									month1 = 7;
								}
								else {
									if( month.equals( "August" ) ) {
										month1 = 8;
									}
									else {
										if( month.equals( "September" ) ) {
											month1 = 9;
										}
										else {
											if( month.equals( "October" ) ) {
												month1 = 10;
											}
											else {
												if( month.equals(
														"November" ) ) {
													month1 = 11;
												}
												else {
													if( month.equals(
															"December" ) ) {
														month1 = 12;
													}
												}
											}
										}
									}
								}
							}
						}
					}
				}
			}
		}
		System.out.println( month1 );
	}

	public static void getSeason() {
		if( month1 == 1 || month1 == 2 || month1 == 3 ) {
			season = "Winter";
			if( month1 % 3 == 0 ) {
				if( day > 21 ) {
					season = "Spring";
				}
			}
		}
		else {
			if( month1 == 4 || month1 == 5 || month1 == 6 ) {
				season = "Spring";
				if( month1 % 3 == 0 ) {
					if( day > 21 ) {
						season = "Summer";
					}
				}
			}
			else {
				if( month1 == 7 || month1 == 8 || month1 == 9 ) {
					season = "Summer";
					if( month1 % 3 == 0 ) {
						if( day > 21 ) {
							season = "Fall";
						}
					}
				}
				else {
					if( month1 == 10 || month1 == 11 || month1 == 12 ) {
						season = "Fall";
						if( month1 % 3 == 0 ) {
							if( day > 21 ) {
								season = "Winter";
							}
						}
					}
				}
			}
		}
	}

	public static void main( String[] args ) {
		Scanner scan = new Scanner( System.in );
		System.out.println( "Input a month: " );
		month = scan.next();
		System.out.println( month );
		getMonth();
		System.out.println( "Input a day" );
		day = scan.nextInt();
		getSeason();
		System.out.println( season );
	}
}

[Carey Brown]

If you join your else-if's together you reduce some of your indentation.

	public static void getSeason() {
		if( month1 == 1 || month1 == 2 || month1 == 3 ) {
			season = "Winter";
			if( month1 % 3 == 0 ) {
				if( day > 21 ) {
					season = "Spring";
				}
			}
		} else if( month1 == 4 || month1 == 5 || month1 == 6 ) {
			season = "Spring";
			if( month1 % 3 == 0 ) {
				if( day > 21 ) {
					season = "Summer";
				}
			}
		} else if( month1 == 7 || month1 == 8 || month1 == 9 ) {
			season = "Summer";
			if( month1 % 3 == 0 ) {
				if( day > 21 ) {
					season = "Fall";
				}
			}
		} else if( month1 == 10 || month1 == 11 || month1 == 12 ) {
			season = "Fall";
			if( month1 % 3 == 0 ) {
				if( day > 21 ) {
					season = "Winter";
				}
			}
		}
	}

[Norm Radder]

it just prints null. What am I doing wrong here?

When you have a chain of if/else statements you need one extra else at the end to catch any uncaught value and print out an error message showing the invalid value and saying what is wrong.  That way there will always be some notice taken of invalid input to assist in problem solving.

A suggestion for methods named get.... they should return a value that the calling method can save and use.

[Campbell Ritchie]

Welcome to the Ranch

What have you been taught about else‑ifs? Nobody indents them like that in real life. What people do is miss out the { before if, and its partner. There are also orders you can put the ifs in, but that doesn't matter in your case. You end up with code like this:-

if (something)
{
   something();
}
else if (somethingDifferent)
{
   somethingDifferent();
}
else if (somethingElse)
{
   somethingElse();
}
else /* none of the previous options applies */
{
  nowForSomethingCompletelyDifferent();
}

Try that, which should make your code easier to read.
Carey has told you the real problem, using the same object operator ==
I suggest you try a switch‑case, which can take Strings for the cases.

[Tim Holloway]

Some programming languages have an actual "elseif" or "elif" statement. Java, alas, does not. But I do like Carey does and it's close enough.

[Francisco Heredia]

Adding to the previous responses from the colleagues, I agree with what Campbell Ritchie said and I encourage you to use switch-case for the getMonth() method, which will improve the readability and performance of your code.

public static void getMonth() {
    switch (month) {
        case "January":
            month1 = 1;
            break;
        case "February":
            month1 = 2;
            break;
        case "March":
            month1 = 3;
            break;
        case "April":
            month1 = 4;
            break;
        case "May":
            month1 = 5;
            break;
        case "June":
            month1 = 6;
            break;
        case "July":
            month1 = 7;
            break;
        case "August":
            month1 = 8;
            break;
        case "September":
            month1 = 9;
            break;
        case "October":
            month1 = 10;
            break;
        case "November":
            month1 = 11;
            break;
        case "December":
            month1 = 12;
            break;
        default:
            System.out.println("Invalid month");
            break;
    }
    System.out.println(month1);
}

[Norm Radder]

I would add the month info to the print:

            System.out.println("Invalid month " + month);

[Campbell Ritchie]

I would prefer to see objects introduced early in your training. I know some people are quite happy with late objects, but you have shown us some non‑object‑oriented code.
I would also prefer to see all those fields and the getSeason() method given private access. There is no need for them to be accessed outwith the current class. I think you can delete month1 because it isn't used at all.
I also tried a switch‑case. Look in Cay Horstmann's website, where you find there are four kinds of switch. The Java™ Tutorials are out of date and only show one kind of switch. A switch expression with -> allowed me to reduce your sixty lines to twelve. Simpler than what FH showed us.
You don't need a month number; you can go directly from month to season. I shortened the output a little:-

java Seasoninfo.java
Input a month and day:
March 25
25 March is in Spring

Note that a Scanner allows you to write the month and day on the same line and still have them read correctly.
More information available if needed.

[Piet Souris]

I never like workibg with a lot of ifs. A switch with -> wouold be much better. To practise the use of enums, I tried to rewrite the above with just enums. Here goes:

package javaranch05;

import java.util.Comparator;
import java.util.HashMap;
import java.util.Map;
import java.util.TreeMap;
import static javaranch05.Month.December;
import static javaranch05.Month.June;
import static javaranch05.Month.March;
import static javaranch05.Month.September;
import static javaranch05.Season.Autumn;
import static javaranch05.Season.Spring;
import static javaranch05.Season.Summer;
import static javaranch05.Season.Winter;

/**
 *
 * @author Piet
 */
public class WilliamZane {
    
    public static void main(String... args) {
        System.out.println(MonthDay.getSeason(12, 31));
    }
}

enum Month {
    January (1), February (2), March (3), April (4), May (5), June (6),
    July (7), August (8), September (9), October (10), November (11), December (12);
    
    private static Map<Integer, Month> map = new HashMap<>();
    static {
        for (var month: Month.values()) map.put(month.monthnr, month);
    }
    private int monthnr;
    
    Month (int nr) {this.monthnr = nr;}
    
    public static Month getMonth(int nr) {
        return map.get(nr);
    }
    
    public static int getMonthnr(Month month) {
        return month.monthnr;
    }
}

enum Season {
    Spring, Summer, Autumn, Winter;
}

record MonthDay(Month month, int day) {
    
    private static Comparator<MonthDay> comp;
    static {
        Comparator<MonthDay> c1 = (md1, md2) -> md1.month.compareTo(md2.month);
        Comparator<MonthDay> c2 = Comparator.comparingInt(MonthDay -> MonthDay.day);
        comp = c1.thenComparing(c2);
    }
    
    private static TreeMap<javaranch05.MonthDay, javaranch05.Season> map = new TreeMap<>(comp);
    static {
        map.put(new MonthDay(March, 20), Winter);
        map.put(new MonthDay(June, 20), Spring);
        map.put(new MonthDay(September, 20), Summer);
        map.put(new MonthDay(December, 20), Autumn);
        map.put(new MonthDay(December, 31), Winter);
    }
    
    public static Season getSeason(int month, int day) {
        return map.ceilingEntry(new MonthDay(Month.getMonth(month), day)).getValue();
    }
}

[Campbell Ritchie]

I suspect there are features in your code that OP is unfamiliar with. This is what I tried earlier and edited a little just now:-

import java.util.Scanner;

class Seasonsinfo
{
    private final int day;
    private final String month;
    private final String season;
    
    private Seasonsinfo(String month, int day)
    {
        this.month = month;
        this.day   = day;
        season     = getSeason(month, day);
    }

    @Override
    public String toString()
    {
        return String.format("%d %s is in %s", day, month, season);
    }
    
    private static String getSeason(String month, int day)
    {
        return switch (month)
        {
            case "January", "February"  -> "Winter";
            case "April", "May"         -> "Spring";
            case "July", "August"       -> "Summer";
            case "October", "November"  -> "Autumn";
            case "March"                -> day < 21 ? "Winter" : "Spring";
            case "June"                 -> day < 21 ? "Spring" : "Summer";
            case "September"            -> day < 21 ? "Summer" : "Autumn";
            case "December"             -> day < 21 ? "Autumn" : "Winter";
            default                     -> {throw new IllegalArgumentException(
                     "Month name unknown.");}
        };
    }
            
    public static void main(String... args)
    {
          Scanner scan = new Scanner(System.in);
          System.out.println("Input a month and day: ");
          String month = scan.next();
          int day = scan.nextInt();
          Seasonsinfo si = new Seasonsinfo(month, day);
          System.out.println(si);
    }
}

The class name should have a capital I in.
Note I have got a class with three fields, all final, and with a private constructor, it should be immutable as written.
The static method finds the season name from the other two fields, and is called from the constructor. Remember that methods called from a constructor should always be marked private or final, but usually not both.
Pairs of months names map to a season name, and the other four months map depending on whether you are before or after the 21st. Not quite scientifically accurate, but we are learning programming not astronomy. Note the ?: operator makes the cases much more concise.
In the case of default, the program throws an exception, which has to be wrapped in an extra pair of {...}.
It would be far better not to use Strings,←link but OP probably hasn't heard of enums yet.