James Brooks

Jan Cumps wrote:Nothing I can see directly in your code.
But I can see that you call some unknown to us methods (e.g.: populateReadArray ) in your while loop. Have you checked what is happening there?

Yeah, nothing funny that I see:

public void populateReadArray(String SCADARTTag, Double SCADARTValueTag){ if(SCADARTTags.contains(SCADARTTag)){ int loc = SCADARTTags.indexOf(SCADARTTag); meterReadings.set(loc, SCADARTValueTag); } else{ printError(new Exception("There was a mismatch in the quantity of SCADA runtime tags/CMMS codes.")); } //write to log file }

Jan Cumps wrote:
Do you use recursion in your program?

No, everything is iterative. (while and for with counters)

Jan Cumps wrote:In your code, you don't close connections if exceptions occur.
You should not close a connection - and other jdbc resources - in the try{} block, but in the finally{} block.

This is true; I really didn't think about that. Thank you. I'm going to change it, but any idea why I'm holding these open, even though no exceptions are thrown?

Bump

Hi all,

I'm connecting to a SQL Server 2008 DB, and my code is apparently holding connections open in the DB, as evidenced by the Activity Monitor (sleeping - waiting for command), and in reports - Activity All Sessions (Show as a connection, 'no active requests on the session'). I'm closing my ResultSet, my Statement, and my Connection. Is this not enough? I'm using, for example, the following code for DB access, if interested:

int arrayIt = 0; Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver"); Connection con = DriverManager.getConnection("jdbc:sqlserver://" + SCADASrv + ":" + SCADASQLPort + ";user=" + SCADASQLAcct + ";password=" + SCADASQLPassword); Statement queryExec = con.createStatement(); String getSCADAValuesCmd = new String("USE " + SCADADB + " SELECT " + SCADARTTag + ", " + SCADARTValueTag + " FROM " + SCADATable); ResultSet result = queryExec.executeQuery(getSCADAValuesCmd); while(result.next()){ String name = result.getString(SCADARTTag); Double meterReading = result.getDouble(SCADARTValueTag); populateReadArray(name, meterReading); arrayIt++; } result.close(); queryExec.close(); con.close();//is this not enough to close the ResultSet, the Statement, and the Connection? }
also:
try{ int resultIt = 0; Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver"); con = DriverManager.getConnection("jdbc:sqlserver://" + CMMSSrv + ":" + CMMSSQLPort + ";user=" + CMMSSQLAcct + ";password=" + CMMSSQLPassword); Statement query = con.createStatement(); String getSCADANamesCmd = new String("USE " + CMMSDB + " SELECT " + CMMSRTField + " FROM " + CMMSRTTable); ResultSet result = query.executeQuery(getSCADANamesCmd); meterNames = new ArrayList(); int i = 0; while(result.next()){ meterNames.add(resultIt, result.getString(CMMSRTField)); resultIt++; } SCADARTTags = populateSCADATags(meterNames); result.close(); query.close(); con.close(); //not enough? }
also:
try{ Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver"); con = DriverManager.getConnection("jdbc:sqlserver://" + CMMSSCADAServer + ":1433;user=" + CMMSSCADASQLAcct + ";password=" + CMMSSCADASQLPassword); Statement update = con.createStatement(); StringBuffer updateString = new StringBuffer(); StringBuffer updateString1 = new StringBuffer(); GregorianCalendar now = new GregorianCalendar(); int day = now.DAY_OF_MONTH; int month = now.MONTH; int year = + now.YEAR; String ds = Integer.toString(day); StringBuffer dayString = new StringBuffer(ds); if(dayString.length()==1){ dayString.insert(0, "0"); } String ms = Integer.toString(month); StringBuffer monthString = new StringBuffer(ms); if(monthString.length() == 1){ monthString.insert(0, "0"); } String yearString = Integer.toString(year); String date = dayString.toString() + '/' + monthString.toString() + '/' + yearString; Double readingsDouble = new Double(0.0); for(int j = 0; j < meterReadings.size(); j++){ if(meterReadings.get(j) != null){ if(updateString.length() > 0) updateString.delete(0, updateString.length()); readingsDouble = (Double)(meterReadings.get(j)); java.math.BigDecimal converted = new java.math.BigDecimal(Double.toString(readingsDouble)); updateString.append("USE " + CMMSSCADADatabase + " UPDATE " + CMMSSCADATable + " SET RTVALUE = " + converted + " WHERE UPPER(" + CMMSSCADACMMSField + ") LIKE '%" + meterNames.get(j).toString().toUpperCase() + "%';"); String uString = updateString.toString(); update.execute(uString); if(updateString1.length() > 0) updateString1.delete(0, updateString.length()); updateString.append("USE " + CMMSSCADADatabase + " UPDATE " + CMMSSCADATable + " SET REA_DATE = " + date + " WHERE UPPER(" + CMMSSCADACMMSField + ") LIKE '%" + meterNames.get(j).toString().toUpperCase() + "%';"); update.execute(uString); } } int resultIt = 0; Statement query = con.createStatement(); String s1 = "USE " + CMMSSCADADatabase + " SELECT " + CMMSSCADACMMSField + ", WWDESCRIPTION FROM " + CMMSSCADATable; ResultSet result1 = query.executeQuery(s1); ArrayList convMeterNames = new ArrayList(); ArrayList description = new ArrayList(); while(result1.next()){ convMeterNames.add(resultIt, result1.getString(CMMSSCADACMMSField)); description.add(resultIt, result1.getString("WWDESCRIPTION")); resultIt++; } resultIt = 0; String s2 = "USE " + CMMSDB + " SELECT OUD_OBJECT FROM R5OBJUSAGEDEFS"; ResultSet result2 = query.executeQuery(s2); ArrayList prodMeterName = new ArrayList(); ArrayList prodDescription = new ArrayList(); while(result2.next()){ MET_CODE.add(resultIt, result2.getString("OUD_OBJECT")); prodMeterName.add(resultIt, result2.getString("OUD_OBJECT")); resultIt++; } result1.close(); result2.close(); update.close(); query.close(); con.close(); //not enough? populateInforTable(); }

also:
try{ Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver"); con = DriverManager.getConnection("jdbc:sqlserver://" + CMMSSCADAServer + ":1433;user=" + CMMSSCADASQLAcct + ";password=" + CMMSSCADASQLPassword); Statement update = con.createStatement(); String updateS = "USE " + CMMSSCADADatabase + " SELECT * FROM " + CMMSSCADATable + ";"; inforNames.clear(); newRuntimes.clear(); ResultSet rs = update.executeQuery(updateS); while(rs.next()){ inforNames.add(rs.getString("CMMSNAme")); newRuntimes.add(rs.getBigDecimal("RTValue")); } String updateString = "USE " + CMMSSCADADatabase + " DELETE FROM R5METERS;"; update.execute(updateString); updateString = "SELECT GETDATE() AS CURR_TIME;"; rs = update.executeQuery(updateString); rs.close(); update.close(); con.close(); //not enough? }
also:
try{ Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver"); con = DriverManager.getConnection("jdbc:sqlserver://" + CMMSSCADAServer + ":1433;user=" + CMMSSCADASQLAcct + ";password=" + CMMSSCADASQLPassword); Statement update = con.createStatement(); String updateString = "USE " + CMMSSCADADB + " SELECT " + CMMSSCADACMMSNameField + ", " + CMMSSCADASCADARTTagField + " FROM " + CMMSSCADATable; ResultSet result = update.executeQuery(updateString); SCADARTTags = new ArrayList(meterNames.size()); meterTemp = new ArrayList(meterNames.size()); SCADATemp = new ArrayList(meterNames.size()); int resultIt = 0; int d = 0; if(!meterNames.isEmpty()){ while(result.next()){ String cmmsnm = result.getString(CMMSSCADACMMSNameField); String rttag = result.getString(CMMSSCADASCADARTTagField); meterTemp.add(resultIt, cmmsnm); SCADATemp.add(resultIt, rttag); resultIt++; } int j = 0; SCADARTTags.ensureCapacity(meterNames.size()); for(int i = 0; i < meterNames.size(); i++) SCADARTTags.add(null); for(int i = 0; i < meterNames.size(); i++){ int loc = meterTemp.indexOf(meterNames.get(i)); if(loc != -1){ SCADARTTags.set(loc, SCADATemp.get(loc)); j++; } } result.close(); update.close(); con.close(); //not enough? }

Rob Prime wrote:When you use JAR files and the -jar flag, the class path is ignored. Try putting the JavaMail JAR file in a folder relative to your JAR file, then adding it to the Class-Path directive in your MANIFEST.MF file.

Well, I'm using Netbeans, so I don't know of a way of modifying the manifest file. I've put the javamail JAR in both the compile and run-time libraries in Netbeans, but am still getting this error from the JAR that is generated from my project (the JAR in the dist path of my Netbeans project). Do I maybe need to look at building this without the use of Netbeans, so that I have more granularity of control? Surely Netbeans has the capabilities to do what I am wanting to do; maybe I'm just missing a step somewhere? Again, I can double-click the JAR file, and it runs, but when run via the task scheduler under those same account privileges, that's when I get the error.

Wouter Oet wrote:Try using the -classpath (or -cp) option of the java command.

I placed the mail jar in the root of the C drive, then changed the task to the following:

"C:\Program Files\Java\jdk1.6.0_13\jre\bin\java.exe" -cp "C:\mail.jar" -jar "C:\CMMS_SCADA.jar"

I still got the same error. Any ideas?

Thank you!

Hi all,

I have a task running on my WS2003 machine as inforadmin.PASCOUTIL via the task scheduler ( "C:\Program Files\Java\jdk1.6.0_13\jre\bin\java.exe" -jar "C:\CMMS_SCADA.jar" ). When I'm logged on as this user, I can run the jar file by double-clicking on it, but the task scheduler throws the NoClassDefFoundError pointing to javax.mail. I assume this as a javamail JAR file placement issue? I've attached a .gif showing the screenshot of this JAR file on the local computer, so if anyone would like to look and comment, I would greatly appreciate it.

Bump

Also, is there a good resource to learn about the different paths within the JRE/JDK directories? I'm still clueless about this part of it.

OK, thanks for the help :-) I changed the task scheduler's profile for that task to my domain admin login, and voila! I was confused because that username is the same for the local machine and the domain. Now, I'm getting that silly mail messaging exception (class not found) again when it runs, but only when either the task scheduler runs it, or when I navigate to the directory you named below and run it from there. Any thoughts? It apparently has to do with the mail.jar file. I did a search for mail.jar on the entire computer, and got quite a few results. See screenshot of search results if you like; I have a feeling that this a .jar file placement problem, or maybe it is in a directory it should not be and is causing a conflict.

Paul Clapham wrote:

James Brooks wrote: The program creates a .csv file. When run manually, the .csv is output, which I can tell from the file attributes (time created). It does not output the file when the task scheduler supposedly runs it.

No, that just tells you that it didn't work right. You know the task scheduler ran it, so presumably something bad happened and the program crashed. That suggests to me that something is different between your environment and the task scheduler's environment.

By the way, you said it worked correctly when you ran it from the command line. Does it work correctly when you run it from the command line with C:\Program Files\Java\jdk1.6.0_13\jre\bin as the current directory, or did you try it with some other current directory?

And does the command line run the application under your user profile or some other user profile. Could that make a difference?

I'm sure there are plenty of other environment differences that could exist. Keep looking for them.

Hi Paul,

The program creates a .csv file. When run manually, the .csv is output, which I can tell from the file attributes (time created). It does not output the file when the task scheduler supposedly runs it.

Paul Clapham wrote:What makes you think the program doesn't run? Perhaps it does run but the results of its running weren't what you expected.

Hi all,

OK, so, I have my JAR file on a WS2003 machine, and when I double-click on the JAR or run it from the command line, my program executes just fine. The JAR is on the root of my C drive; C:\CMMS_SCADA.jar. I've created a daily scheduled task for this JAR, and when the clock rolls around to its execution time, the task status shows as 'running', but the program does not run. The scheduler is scheduled to run:

"C:\Program Files\Java\jdk1.6.0_13\jre\bin\java.exe" -jar "C:\CMMS_SCADA.jar"

and start in:

"C:\Program Files\Java\jdk1.6.0_13\jre\bin"

Am I missing something?

Thanks in advance, as always.

Also, should I take the mail jar out of my project's library in Netbeans, since I'm putting them in the CLASSPATH variable in my WS2003 machine?

Yes, jdk1.6 and jre6. And sorry, which other jars are you referring to?


Stack trace:

Exception in thread "main" java.lang.NoClassDefFoundError: javax/mail/MessagingE
xception
at cmms_scada.Main.main(Main.java:22)
Caused by: java.lang.ClassNotFoundException: javax.mail.MessagingException
at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320)
... 1 more

Paul Clapham wrote:I see you didn't add the Java Activation Framework to your classpath, so presumably you're using Java 6 where it is built in?

And do any of those other jars contain JavaMail classes?

Also, the stack trace would be useful information, to see where the class is being requested from.

Thank you for the suggestion. I removed SMTP.jar from my CLASSPATH, and it still occured. Any other ideas?