Terry Flint

The issue above has been resolved by the way, though I did have to resort to re-installing to get around it.

Also worth noting is that this is now happening every single time I open Eclipse. A pop-up window displays saying "Building workspace has encountered a problem. Errors occurred during the build". Clicking the details button will reveal this message:

Errors occurred during the build. Errors running builder 'Maven Project Builder' on project 'Loki'. Could not calculate build plan: Plugin org.apache.maven.plugins:maven-war-plugin:2.1.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-war-plugin:jar:2.1.1 Plugin org.apache.maven.plugins:maven-war-plugin:2.1.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-war-plugin:jar:2.1.1 Could not calculate build plan: Plugin org.apache.maven.plugins:maven-war-plugin:2.1.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-war-plugin:jar:2.1.1 Plugin org.apache.maven.plugins:maven-war-plugin:2.1.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-war-plugin:jar:2.1.1

I 'm currently not getting the server failed to start message anymore for some reason, but I'll be sure to record it if it happens again today, which I'm sure it will. Nevertheless, the most recent console output when I tried the Eclipse method was:

11:05:38,942 INFO [org.jboss.modules] JBoss Modules version 1.0.1.GA 11:05:39,269 INFO [org.jboss.msc] JBoss MSC version 1.0.0.GA 11:05:39,321 INFO [org.jboss.as] JBoss AS 7.0.1.Final "Zap" starting 11:05:40,254 WARN [org.jboss.as] No security realm defined for native management service, all access will be unrestricted. 11:05:40,276 INFO [org.jboss.as] creating http management service using network interface (management) port (9990) 11:05:40,278 WARN [org.jboss.as] No security realm defined for http management service, all access will be unrestricted. 11:05:40,284 INFO [org.jboss.as.logging] Removing bootstrap log handlers 11:05:40,302 INFO [org.jboss.as.connector.subsystems.datasources] (Controller Boot Thread) Deploying JDBC-compliant driver class org.h2.Driver (version 1.2) 11:05:40,320 INFO [org.jboss.as.clustering.infinispan.subsystem] (Controller Boot Thread) Activating Infinispan subsystem. 11:05:40,421 INFO [org.jboss.as.naming] (Controller Boot Thread) Activating Naming Subsystem 11:05:40,434 INFO [org.jboss.as.naming] (MSC service thread 1-2) Starting Naming Service 11:05:40,437 INFO [org.jboss.as.osgi] (Controller Boot Thread) Activating OSGi Subsystem 11:05:40,463 INFO [org.jboss.as.security] (Controller Boot Thread) Activating Security Subsystem 11:05:40,471 INFO [org.jboss.remoting] (MSC service thread 1-2) JBoss Remoting version 3.2.0.Beta2 11:05:40,484 INFO [org.xnio] (MSC service thread 1-2) XNIO Version 3.0.0.Beta3 11:05:40,497 INFO [org.xnio.nio] (MSC service thread 1-2) XNIO NIO Implementation Version 3.0.0.Beta3 11:05:40,703 INFO [org.apache.catalina.core.AprLifecycleListener] (MSC service thread 1-3) The Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: .:/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java 11:05:40,718 INFO [org.jboss.as.jmx.JMXConnectorService] (MSC service thread 1-8) Starting remote JMX connector 11:05:40,720 INFO [org.jboss.as.ee] (Controller Boot Thread) Activating EE subsystem 11:05:40,764 INFO [org.apache.coyote.http11.Http11Protocol] (MSC service thread 1-4) Starting Coyote HTTP/1.1 on http--127.0.0.1-8080 11:05:40,765 INFO [org.jboss.as.remoting] (MSC service thread 1-1) Listening on /127.0.0.1:9999 11:05:40,932 INFO [org.jboss.as.connector] (MSC service thread 1-4) Starting JCA Subsystem (JBoss IronJacamar 1.0.3.Final) 11:05:40,975 INFO [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-1) Bound data source [java:jboss/datasources/ExampleDS] 11:05:41,308 INFO [org.jboss.as.deployment] (MSC service thread 1-1) Started FileSystemDeploymentService for directory /Users/dannyflynn/jboss-as-7.0.1.Final/standalone/deployments 11:05:41,326 INFO [org.jboss.as.deployment] (DeploymentScanner-threads - 1) Found Loki.war in deployment directory. To trigger deployment create a file called Loki.war.dodeploy 11:05:41,340 INFO [org.jboss.as] (Controller Boot Thread) JBoss AS 7.0.1.Final "Zap" started in 2672ms - Started 93 of 148 services (55 services are passive or on-demand) 11:05:41,352 INFO [org.jboss.as.server.deployment] (MSC service thread 1-5) Starting deployment of "Loki.war" 11:05:44,616 WARN [org.jboss.as.server.deployment] (MSC service thread 1-6) Class Path entry xml-apis.jar in "/Users/dannyflynn/jboss-as-7.0.1.Final/standalone/deployments/Loki.war/WEB-INF/lib/serializer-2.7.1.jar" does not point to a valid jar for a Class-Path reference. 11:05:44,616 WARN [org.jboss.as.server.deployment] (MSC service thread 1-6) Class Path entry xercesImpl.jar in "/Users/dannyflynn/jboss-as-7.0.1.Final/standalone/deployments/Loki.war/WEB-INF/lib/xalan-2.7.1.jar" does not point to a valid jar for a Class-Path reference. 11:05:44,616 WARN [org.jboss.as.server.deployment] (MSC service thread 1-6) Class Path entry xml-apis.jar in "/Users/dannyflynn/jboss-as-7.0.1.Final/standalone/deployments/Loki.war/WEB-INF/lib/xalan-2.7.1.jar" does not point to a valid jar for a Class-Path reference. 11:05:44,617 WARN [org.jboss.as.server.deployment] (MSC service thread 1-6) Class Path entry serializer.jar in "/Users/dannyflynn/jboss-as-7.0.1.Final/standalone/deployments/Loki.war/WEB-INF/lib/xalan-2.7.1.jar" does not point to a valid jar for a Class-Path reference. 11:05:44,844 INFO [org.jboss.jpa] (MSC service thread 1-6) read persistence.xml for dt340a 11:05:44,862 INFO [org.jboss.as.jpa] (MSC service thread 1-2) added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to Loki.war 11:05:44,862 INFO [org.jboss.as.jpa] (MSC service thread 1-2) added (default provider) org.hibernate dependency to application deployment (since 1 PU(s) didn't specify jboss.as.jpa.providerModule) 11:05:44,863 INFO [org.jboss.as.jpa] (MSC service thread 1-2) added org.hibernate dependency to application deployment 11:05:45,222 WARN [org.jboss.modules] (MSC service thread 1-6) Failed to define class webservice.Users in Module "deployment.Loki.war:main" from Service Module Loader: java.lang.UnsupportedClassVersionError: webservice/Users : Unsupported major.minor version 51.0 at java.lang.ClassLoader.defineClass1(Native Method) [:1.6.0_65] at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637) [:1.6.0_65] at java.lang.ClassLoader.defineClass(ClassLoader.java:621) [:1.6.0_65] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141) [:1.6.0_65] at org.jboss.modules.ModuleClassLoader.defineClass(ModuleClassLoader.java:397) at org.jboss.modules.ModuleClassLoader.loadClassLocal(ModuleClassLoader.java:261) at org.jboss.modules.ModuleClassLoader$1.loadClassLocal(ModuleClassLoader.java:76) at org.jboss.modules.Module.loadModuleClass(Module.java:588) at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:183) at org.jboss.modules.ConcurrentClassLoader.performLoadClassChecked(ConcurrentClassLoader.java:358) at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:307) at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:101) at org.jboss.as.ejb3.deployment.processors.BusinessViewAnnotationProcessor.getEjbClass(BusinessViewAnnotationProcessor.java:195) at org.jboss.as.ejb3.deployment.processors.BusinessViewAnnotationProcessor.deploy(BusinessViewAnnotationProcessor.java:77) at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:115) at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1765) at org.jboss.msc.service.ServiceControllerImpl$ClearTCCLTask.run(ServiceControllerImpl.java:2291) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895) [:1.6.0_65] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918) [:1.6.0_65] at java.lang.Thread.run(Thread.java:695) [:1.6.0_65] 11:05:45,226 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-6) MSC00001: Failed to start service jboss.deployment.unit."Loki.war".POST_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.unit."Loki.war".POST_MODULE: Failed to process phase POST_MODULE of deployment "Loki.war" at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:121) at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1765) at org.jboss.msc.service.ServiceControllerImpl$ClearTCCLTask.run(ServiceControllerImpl.java:2291) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895) [:1.6.0_65] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918) [:1.6.0_65] at java.lang.Thread.run(Thread.java:695) [:1.6.0_65] Caused by: java.lang.UnsupportedClassVersionError: webservice/Users : Unsupported major.minor version 51.0 at java.lang.ClassLoader.defineClass1(Native Method) [:1.6.0_65] at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637) [:1.6.0_65] at java.lang.ClassLoader.defineClass(ClassLoader.java:621) [:1.6.0_65] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141) [:1.6.0_65] at org.jboss.modules.ModuleClassLoader.defineClass(ModuleClassLoader.java:397) at org.jboss.modules.ModuleClassLoader.loadClassLocal(ModuleClassLoader.java:261) at org.jboss.modules.ModuleClassLoader$1.loadClassLocal(ModuleClassLoader.java:76) at org.jboss.modules.Module.loadModuleClass(Module.java:588) at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:183) at org.jboss.modules.ConcurrentClassLoader.performLoadClassChecked(ConcurrentClassLoader.java:358) at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:307) at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:101) at org.jboss.as.ejb3.deployment.processors.BusinessViewAnnotationProcessor.getEjbClass(BusinessViewAnnotationProcessor.java:195) at org.jboss.as.ejb3.deployment.processors.BusinessViewAnnotationProcessor.deploy(BusinessViewAnnotationProcessor.java:77) at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:115) ... 5 more 11:05:45,247 INFO [org.jboss.as.server.controller] (DeploymentScanner-threads - 2) Deployment of "Loki.war" was rolled back with failure message {"Failed services" => {"jboss.deployment.unit.\"Loki.war\".POST_MODULE" => "org.jboss.msc.service.StartException in service jboss.deployment.unit.\"Loki.war\".POST_MODULE: Failed to process phase POST_MODULE of deployment \"Loki.war\""}} 11:05:45,248 INFO [org.jboss.as.controller] (DeploymentScanner-threads - 2) Service status report Services which failed to start: service jboss.deployment.unit."Loki.war".POST_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.unit."Loki.war".POST_MODULE: Failed to process phase POST_MODULE of deployment "Loki.war" 11:05:45,252 ERROR [org.jboss.as.deployment] (DeploymentScanner-threads - 1) {"Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-2" => {"Failed services" => {"jboss.deployment.unit.\"Loki.war\".POST_MODULE" => "org.jboss.msc.service.StartException in service jboss.deployment.unit.\"Loki.war\".POST_MODULE: Failed to process phase POST_MODULE of deployment \"Loki.war\""}}}} 11:05:45,360 INFO [org.jboss.as.server.deployment] (MSC service thread 1-5) Stopped deployment Loki.war in 111ms


Also, in cue this is of any use, I've been trying out your wildly recommendation. I may not be keying in the class path entirely correctly. Maybe you can spot the problem from this image where I have all the relevant files open (I've temporarily moved them to the desktop for clarity's sake).
Here is the link: http://postimg.org/image/fkc9jvxr5/

Also, this is what I keep getting if I try to run a JBoss project in Eclipse by going Run As > Run on server

"Server JBoss 7.1 Runtime Server failed to start."

Just to add further confusion (sorry), a friend linked me to this video: http://www.youtube.com/watch?v=VzxLTGW2gqE and advised me to use 7.1.1.Final instead. Now I have jboss-as-7.1.1.Final downloaded and all the appropriate screens working. I was even able to make a management user on localhost:9990 this time, which is further than I got before. So, how would I adapt it for version 7.1.1.? I'm assuming the path you recommended for 6.1.0 wouldn't work anymore.

Hi guys!

I'm trying to get the HelloWorld from chapter 1 of JBoss in Action to work (chapter available free here: http://www.manning.com/jamae/). First of all a bit of context. I am running a Mac Powerbook pro laptop, using the native Unix OS. I'm running maven 3.2.1 and Java 1.7.0_25. I've downloaded jboss-6.1.0.Final. I've changed permissions on the bin/startup.sh file to chmod 777 and when I go to localhost:8080, I do indeed see the appropriate JBoss screen. So, all of that seems dandy. I really wanted to upload images just to show, but this forum seems to only allow URL images. Did I miss something there?

Where I'm having trouble is the exercise where I need to deploy a Hello World program. As far as I can tell I have created a directory structure exactly like the one he wants. However, when I run this command:
javac -classpath [path-to-jboss]/server/default/lib/servlet-api.jar -d ➥helloapp.war/WEB-INF/classes src/com/manning/jbia/intro/*

Unless I've misunderstood something, that translates to this on my computer:
javac -classpath /Users/[myUserName]/jboss-6.1.0.Final/server/default/lib/servlet-api.jar -d helloapp.war/WEB-INF/classes src/com/manning/jbia/intro/*

This is the result produced when I run the command from inside the helloWorldBuild folder:
src/com/manning/jbia/intro/HelloWorldServlet.java:4: error: package javax.servlet does not exist import javax.servlet.ServletException; ^ src/com/manning/jbia/intro/HelloWorldServlet.java:5: error: package javax.servlet.http does not exist import javax.servlet.http.HttpServlet; ^ src/com/manning/jbia/intro/HelloWorldServlet.java:6: error: package javax.servlet.http does not exist import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; @SuppressWarnings("serial") ^ src/com/manning/jbia/intro/HelloWorldServlet.java:6: error: package javax.servlet.http does not exist import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; @SuppressWarnings("serial") ^ src/com/manning/jbia/intro/HelloWorldServlet.java:6: error: package javax.servlet.http does not exist import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; @SuppressWarnings("serial") ^ src/com/manning/jbia/intro/HelloWorldServlet.java:7: error: cannot find symbol public class HelloWorldServlet extends HttpServlet { ^ symbol: class HttpServlet src/com/manning/jbia/intro/HelloWorldServlet.java:9: error: cannot find symbol public void service( HttpServletRequest request, ^ symbol: class HttpServletRequest location: class HelloWorldServlet src/com/manning/jbia/intro/HelloWorldServlet.java:10: error: cannot find symbol HttpServletResponse response ) throws ServletException, IOException { ^ symbol: class HttpServletResponse location: class HelloWorldServlet src/com/manning/jbia/intro/HelloWorldServlet.java:10: error: cannot find symbol HttpServletResponse response ) throws ServletException, IOException { ^ symbol: class ServletException location: class HelloWorldServlet src/com/manning/jbia/intro/HelloWorldServlet.java:8: error: method does not override or implement a method from a supertype @Override ^ 10 errors

So, where should these javax.servlet packages it seems to be looking for be? I didn't see them referenced in the code from the book. Are they meant to be in the JBoss directory structure, or should they have been put in the helloWorldBuild directory at some point?

By the way, if this is going to be too much, I would be quite happy to find a step-by-step guide that will teach me how to use JBoss with Eclipse rather than the command line. I'm told this is supposed to be easy, but I'm just not finding it so. I really appreciate your help.

Okay, so that's not exactly a short example, but I was afraid of losing context, since the changes aren't just in one place.

Campbell Ritchie wrote:Please show us a simple short example of what you are trying.

Well, for starters, here is an example of how I misunderstood what Randall was saying:

package lineProject; public class ExperimentalClass { private static int click = 0; static ArrayList<Point> pointStore = new ArrayList<Point>(); // as much as possible, don't use the water in the tank when they're off // because it can cause air locks. You'll get no water anyway if the tank is // empty public static void main(String[] args) throws Exception { JFrame f = new JFrame("Draw a red line"); f.setSize(300, 300); f.setLocation(300, 300); f.setResizable(false); JPanel p = new JPanel() { Point pointStart = null; Point pointEnd = null; { addMouseListener(new MouseAdapter() { public void mousePressed(MouseEvent e) { pointStart = e.getPoint(); } public void mouseReleased(MouseEvent e) { if(click==0){ click++; pointStore.add(e.getPoint()); } else{ pointEnd = e.getPoint(); pointStart=pointStore.get(0); pointStore.remove(0); click=0; } } }); addMouseMotionListener(new MouseMotionAdapter() { public void mouseMoved(MouseEvent e) { pointEnd = e.getPoint(); } public void mouseDragged(MouseEvent e) { pointEnd = e.getPoint(); repaint(); } }); } public void paint(Graphics g) { super.paint(g); if (pointStart != null) { g.setColor(Color.red); g.drawLine(pointStart.x, pointStart.y, pointEnd.x, pointEnd.y); } } }; f.add(p); f.setVisible(true); } }

Campbell Ritchie wrote:Have you made any progress with your line?

How pathetic is it that I still can't answer this in the affirmative?

I've found examples of what I was looking for that I was able to tweak, but I never managed to adjust this particular piece of code the way I wanted to.

I'm having difficulty figuring out how to draw a line with two mouse clicks. Every bit of sample code I've seen so far seems to either use a click and drag method, or create one long zig zag going through various selected points. I'm pretty sure it's a matter of knowing how to use the appropriate mouseListeners, but I can never seem to modify them in such a way as to get what I want.

Below is the code I've been trying to modify, which creates one line at a time using a click and drag approach. I've tried to change it in various ways, such as changing mousePressed to mouseClicked or adding in another MouseListener, and various similar approaches. I need some help with this.

import java.awt.Color; import java.awt.Graphics; import java.awt.Point; import java.awt.event.MouseAdapter; import java.awt.event.MouseEvent; import java.awt.event.MouseMotionAdapter; import javax.swing.JFrame; import javax.swing.JPanel; public class ExperimentalClass { // as much as possible, don't use the water in the tank when they're off // because it can cause air locks. You'll get no water anyway if the tank is // empty public static void main(String[] args) throws Exception { JFrame f = new JFrame("Draw a red line"); f.setSize(300, 300); f.setLocation(300, 300); f.setResizable(false); JPanel p = new JPanel() { Point pointStart = null; Point pointEnd = null; { addMouseListener(new MouseAdapter() { public void mousePressed(MouseEvent e) { pointStart = e.getPoint(); } public void mouseReleased(MouseEvent e) { pointStart = null; } }); addMouseMotionListener(new MouseMotionAdapter() { public void mouseMoved(MouseEvent e) { pointEnd = e.getPoint(); } public void mouseDragged(MouseEvent e) { pointEnd = e.getPoint(); repaint(); } }); } public void paint(Graphics g) { super.paint(g); if (pointStart != null) { g.setColor(Color.red); g.drawLine(pointStart.x, pointStart.y, pointEnd.x, pointEnd.y); } } }; f.add(p); f.setVisible(true); } }

Simple question here. I'm wondering how to use the getXOnScreen and getYOnScreen methods from the MouseEvent class mentioned here. As far as I understand them, they're supposed to return ints for each of the co-ordinates for where the cursor is at a given pint in time? Is that correct. If so, that seems incredibly useful, but I'm not sure how to actually implement them. I see you can't just employ them by simply importing the MouseEvent class in java.awt, which I had kind of hoped would be the case. I have two classes below designed to display a 400*400 paint window. If possible, could someone give me an example of one of those methods used in this context? If not, any example of them working is fine, as long as a simpleton like me can understand it .

package drawing; import java.awt.*; import javax.swing.*; import java.awt.event.*; public class Window extends JPanel { public void paintComponent(Graphics g) { super.paintComponent(g); ; this.setBackground(Color.WHITE); } }

package drawing; import javax.swing.JFrame; public class Launcher { public static void main(String[] args) { JFrame f = new JFrame("Title"); f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); Window p = new Window(); f.add(p); f.setSize(400, 400); f.setVisible(true); } }

I had my first lecture on algorithms today and the instructor had an exercise he wanted us to work on in class. I thought I'd be able to get around it, given it was first lecture after all, but I was one of the ones who couldn't complete it (not quite the only one). First off, here's the simple example he gave to get the idea into our heads:

Write down a grid, say, 4£4, of the numbers 0, 1, 2,..., that has the property that each number in the grid is the smallest number not appearing above it in the same column, or to its left in the same row.

Naturally, this produces the following table:

0 1 2 3

1 0 3 2

2 3 0 1

3 2 1 0

So far, so good. He then extracted the idea to make a more general algorithm:

Write down an n * n grid, of the numbers 0, 1, 2,,..., that has the property that each number in the grid is the smallest number not appearing above it in the same column, or to its left in the same row.

He asked us to code this in java. Obviously, he wanted it to be a method which would have the parameter int n.
This n will then be used to produce a grid of n*n. I don't know if a 2D array or a 2D ArrayList is more appropriate for this.
I've now started to think an ArrayList makes more sense, because I don't even know if I can reassign an array to a different size.

I am frankly to ashamed of the abominable coding I tried to do in class to show it, and I want to start from scratch.
I don't want outright solutions, but I do want hints on how to do this. I imagine I will be needing two nested for loops to cycle through the array/ArrayList.
I notice that if the square is at [i][j], all the left cells will have the same i value and a lesser j value, and all of the above cells will have the same j value and a lesser i value (I think).
I thought I'd be able to use booleans to check for whether a cell was above or left, but the way I was doing it, that required associating a boolean with an int, which just made no sense.

Now, since facepalming and headdesking doesn't seem to work to well, I thought I'd admit that I need some help.
What should I do? By the way, links to online courses and documentation on algorithms like this would be appreciated if they are available (Beginner level stuff obviously).

I believe this is a more acceptable version than what I had before.

//############################################################################### GridBagConstraints gbc_lbl = new GridBagConstraints(); gbc_lbl.anchor = GridBagConstraints.NORTHWEST; gbc_lbl.gridx = 0; gbc_lbl.gridy = 0; //First Chart final DefaultCategoryDataset dataset = new DefaultCategoryDataset(); dataset.addValue(34.0, "Series 1", "Category 1"); dataset.addValue(23.0, "Series 1", "Category 2"); dataset.addValue(54.0, "Series 1", "Category 3"); final JFreeChart chart = ChartFactory.createBarChart( "Bar Chart", "Category", "Series", dataset, PlotOrientation.VERTICAL, true, true, false ); //Second Chart ChartPanel chartPanel = new ChartPanel(chart); final XYDataset dataset1 = createDataset("Series 1", 100.0, new Minute(), 200); final JFreeChart chart2 = ChartFactory.createTimeSeriesChart( "Time Series Chart", "Time of Day", "Value", dataset1, true, true, false ); ChartPanel chartPanel2 = new ChartPanel(chart2); //Graphing Panel JPanel graphingPanel = new JPanel(); constraints.anchor = GridBagConstraints.SOUTHWEST; constraints.insets = new Insets(0,0,5,5); constraints.fill = GridBagConstraints.BOTH; addComponent(graphingPanel,6,1,8,11); graphingPanel.add(chartPanel); chartPanel.setPreferredSize(new Dimension(200, 100)); graphingPanel.add(chartPanel2); chartPanel2.setPreferredSize(new Dimension(200,100));

Thanks everyone. All the extra reading was very informative, and now I think I have a better understanding of exactly when to comment my code. Basically, if it adds to the explanation then go for it. If it's redundant, don't bother.

I'm a little confused about something. As far as I understand, there is a rule that all public methods must have javadoc comments, and as far as I can tell an actionperformed method within an action listener is public. Nevertheless, I can't help feeling a bit unsure about whether to comment them or not. Something about it seems incredibly counterintuitive. The fact that I can't find any examples o it also puts me off, so I'd like to know one way or the other.Are you supposed to write javadoc comments for actionperformed methods?