Remco Bos

i.e. in many cases SOA can be accomplished with more restrictive but efficient interfacing technologies

Yes it's off topic, but maybe we can start another thread for this one because I really want to hear your opinion about those "more restrictive but efficient interfacing technologies". I also believe that's the way to go..

P.374
The main problem the folowing statement in the next() method of the CompositeIterator class:
stack.push(component.createIterator());
The createIterator() returns a new CompositeIterator, and so a new Stack!

How I solved it:

1. The Menu should return just an iterator, not an CompositeIterator

public Iterator createIterator() { // return new CompositeIterator(menuComponents.iterator()); return menuComponents.iterator(); }

2. Let the Waitress instantiate the CompositeIterator instead of asking the Menu for one.

public void printVegetarianMenu() { Iterator iterator = new CompositeIterator(allMenus.createIterator()); // Iterator iterator = allMenus.createIterator(); ... }

3. The Menu should not iterate over it's children, we use an external CompositeIterator for that!

public void print() { System.out.print("\n" + getName()); System.out.println(", " + getDescription()); System.out.println("---------------------"); // Iterator iterator = menuComponents.iterator(); // while (iterator.hasNext()) { // MenuComponent menuComponent = (MenuComponent)iterator.next(); // menuComponent.print(); // } }

4. The root (allMenus) is not returned by the iterator. This is because we ask the allMenus for an iterator for it's children, not for the Menu itself!

5. The printMenu() method in the Waitress should also use the CompositeIterator.

public void printMenu() { Iterator iterator = new CompositeIterator(allMenus.createIterator()); while (iterator.hasNext()) { MenuComponent menuComponent = (MenuComponent)iterator.next(); menuComponent.print(); } }

Took me some time to figure this out, maybe I'm totally wrong, please test!!

[ March 30, 2006: Message edited by: Remco Bos ]

[ March 30, 2006: Message edited by: Remco Bos ]
[ March 30, 2006: Message edited by: Remco Bos ]

I was also thinking about using a similar design. It looks very elegant. But now I look at the remote/local database part of the assignment: I wonder if I should implement the DB interface on the local and remote stub, or create a DAO interface and let the remote/local stub implement that interface.Any ideas?